From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86867 invoked by alias); 31 Oct 2016 19:56:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86854 invoked by uid 89); 31 Oct 2016 19:56:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=clever, HTo:U*davem X-HELO: mail-yw0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GlK6YkRHWzOUG7tbWnXP4foDIQMoivrSBJ9AFyiT2Ec=; b=U8LZty0lfFZmUSoINHe4SLsN0j58fcpL6tm3cbTsUHAjjui+AZpm+CdSm5iPmMl0H+ gPLrykoUJtu35rhXoz3UU4lTgaAmP86GkpQFPxL61O7TJEMCtlBAkIN+LHgn50TDXDzy cVZg48hSfjNmnRvPoxNOTE8sEPNqAahCEk8ooXcteG2IlYZn2EceDYLjPQgeLLZP/ebb bVl3jIneqHrdzlGurnUnH/YgYuC2ODW1k8U670L/l5929ujIN1J/YzOfw4T9pZGw2QDT 7Fqp/l1GB1mvkGvc5Fzz29Z1drLHlaQElUKEtJsV1vK8wNh3RVXiIHgh7NzlD1ZAcaRd UUWg== X-Gm-Message-State: ABUngvdsNQ2YKObkrm2gbV+OZkUrnOQKSfTAbSvqBbZrDQYdRuyOUH8Q2Dx1c1zH4DGHMQGY X-Received: by 10.36.51.137 with SMTP id k131mr8921705itk.104.1477943757657; Mon, 31 Oct 2016 12:55:57 -0700 (PDT) Subject: Re: [PATCH v4] Fix -Os related build and test failures. To: David Miller References: <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com> <54572ad0-f92b-14d2-5238-428978285750@redhat.com> <20161031.085559.1939678123281578460.davem@davemloft.net> Cc: schwab@suse.de, joseph@codesourcery.com, fweimer@redhat.com, libc-alpha@sourceware.org From: Carlos O'Donell Message-ID: <523b1244-6144-ede6-6c94-6515fd093ea6@redhat.com> Date: Mon, 31 Oct 2016 19:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161031.085559.1939678123281578460.davem@davemloft.net> Content-Type: text/plain; charset=iso-8859-7 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-10/txt/msg00603.txt.bz2 On 10/31/2016 08:55 AM, David Miller wrote: > From: Carlos O'Donell > Date: Mon, 31 Oct 2016 05:16:29 -0400 > >> On 10/31/2016 04:33 AM, Andreas Schwab wrote: >>> https://build.opensuse.org/project/monitor/home:Andreas_Schwab:glibc >>> >>> In file included from strxfrm_l.c:48:0: >>> ../locale/weight.h: In function ¡findidx¢: >>> ../locale/weight.h:69:4: error: ¡DIAG_PUSH_NEEDS_COMMENT¢ undeclared (first use in this function) >>> DIAG_PUSH_NEEDS_COMMENT; >>> ^~~~~~~~~~~~~~~~~~~~~~~ >>> ../locale/weight.h:69:4: note: each undeclared identifier is reported only once for each function it appears in >>> ../locale/weight.h:70:4: error: implicit declaration of function ¡DIAG_IGNORE_Os_NEEDS_COMMENT¢ [-Werror=implicit-function-declaration] >>> DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> ../locale/weight.h:74:4: error: ¡DIAG_POP_NEEDS_COMMENT¢ undeclared (first use in this function) >>> DIAG_POP_NEEDS_COMMENT; >>> ^~~~~~~~~~~~~~~~~~~~~~ >> >> I'm fixing this. I don't know why this didn't fail on my x86_64 build. >> >> I'm moving the #include into the weight header fragments. > > The thread debugging header nptl_db/thread_dbP.h needs it too. Yes. I'm fixing any file to include the header as required. I was too clever in thinking I could elide it for header fragments included in other source files, I should have just followed the rules we had in place "if it needs it it should include it" since that fixed the messes we previously had. I'm going to setup a non-x86_64 cross-build to test this. I think I can do it easily enough on Fedora so I can keep it up to date for upstream builds. Cheers, Carlos.