From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix x86 build with --enable-tunable=no
Date: Thu, 14 Jan 2021 13:55:14 -0300 [thread overview]
Message-ID: <52cc3f4d-2d69-0c23-8d19-25df82a0d3c7@linaro.org> (raw)
In-Reply-To: <CAMe9rOrK-T434ae4fQpwDJwzsWiiHFwcWtK=4_eG4zXSg3JX_g@mail.gmail.com>
On 14/01/2021 11:48, H.J. Lu wrote:
> On Thu, Jan 14, 2021 at 6:20 AM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>>
>> Checked on x86_64-linux-gnu.
>> ---
>> sysdeps/x86/get-isa-level.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sysdeps/x86/get-isa-level.h b/sysdeps/x86/get-isa-level.h
>> index a86e1e8941..cd9e6945a7 100644
>> --- a/sysdeps/x86/get-isa-level.h
>> +++ b/sysdeps/x86/get-isa-level.h
>> @@ -16,6 +16,8 @@
>> License along with the GNU C Library; if not, see
>> <https://www.gnu.org/licenses/>. */
>>
>> +#include <elf.h>
>> +#include <ldsodefs.h>
>> #include <sys/platform/x86.h>
>>
>> /* Get GNU_PROPERTY_X86_ISA_1_BASELINE and GNU_PROPERTY_X86_ISA_1_V[234]
>> --
>> 2.25.1
In fact the correct fix is the below, by including 'ldsodefs.h' on
get-isa-level.h makes sysdeps/x86_64/tst-glibc-hwcaps.c tests build
fail.
diff --git a/sysdeps/x86/get-isa-level.h b/sysdeps/x86/get-isa-level.h
index a86e1e8941..3f0e27ee59 100644
--- a/sysdeps/x86/get-isa-level.h
+++ b/sysdeps/x86/get-isa-level.h
@@ -16,6 +16,7 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include <elf.h>
#include <sys/platform/x86.h>
/* Get GNU_PROPERTY_X86_ISA_1_BASELINE and GNU_PROPERTY_X86_ISA_1_V[234]
diff --git a/sysdeps/x86_64/dl-hwcaps-subdirs.c b/sysdeps/x86_64/dl-hwcaps-subdirs.c
index e030534f1b..4acd343183 100644
--- a/sysdeps/x86_64/dl-hwcaps-subdirs.c
+++ b/sysdeps/x86_64/dl-hwcaps-subdirs.c
@@ -18,6 +18,7 @@
#include <dl-hwcaps.h>
#include <cpu-features.h>
+#include <ldsodefs.h>
#include <get-isa-level.h>
const char _dl_hwcaps_subdirs[] = "x86-64-v4:x86-64-v3:x86-64-v2";
prev parent reply other threads:[~2021-01-14 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 14:19 Adhemerval Zanella
2021-01-14 14:48 ` H.J. Lu
2021-01-14 16:55 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52cc3f4d-2d69-0c23-8d19-25df82a0d3c7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).