From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126652 invoked by alias); 9 Jan 2020 21:13:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126578 invoked by uid 89); 9 Jan 2020 21:13:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Gm-Message-State:APjAAAV X-HELO: mail-qt1-f182.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ytn40gn9un54zZ7jGgIWcNOsVYOGRzFLXJOBOdarDq4=; b=dS3XswctnYbl6OOlv6JFl13OkvIge+dI6pu82+meAEuzgWYu7Kh4ejMiEeNYflIqAK BRhKTxADVaNHJNliM3m9Xy0R2Xh8Q2s0JBh18n1WAQUocqfTyBoiASMATAuYobEehIoe yeLdfZNVLukoRuXuxeGbkJ1ON/yyo2v023Zr+9UwRzsWE7ahDl+l+q5zbJkOYUupjZvm U5f3yB2NXNCwfKRaakfNZ6UwyU2yt/vu4CcZff4zAA64EHHQWQ/TAmCIuGJPiaVxWAB6 xWIF44DASyDFAiICrxQkQkUciqaidR3Vy38cfou/OlyRn9UYJ4ZMofwQAVneu/2nYoW8 Ys7g== Return-Path: To: libc-alpha@sourceware.org References: <20200108161535.6141-1-hjl.tools@gmail.com> <20200108161535.6141-3-hjl.tools@gmail.com> From: Adhemerval Zanella Subject: Re: V2 [PATCH 2/5] i386/sub_n.S: Add a missing _CET_ENDBR to indirect jump target Message-ID: <52ebe1df-fe0f-8491-8812-82540da68b9e@linaro.org> Date: Thu, 09 Jan 2020 21:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200108161535.6141-3-hjl.tools@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2020-01/txt/msg00172.txt.bz2 LGTM thanks. Reviewed-by: Adhemerval Zanella On 08/01/2020 13:15, H.J. Lu wrote: > diff --git a/sysdeps/i386/sub_n.S b/sysdeps/i386/sub_n.S > index caac89177b..16ebd9169b 100644 > --- a/sysdeps/i386/sub_n.S > +++ b/sysdeps/i386/sub_n.S > @@ -91,6 +91,7 @@ L(oop): movl (%esi),%eax > movl 8(%esi),%eax > sbbl 8(%edx),%eax > movl %eax,8(%edi) > + _CET_ENDBR > movl 12(%esi),%eax > sbbl 12(%edx),%eax > movl %eax,12(%edi)