From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v3 0/4] Remove --with-default-link option
Date: Sat, 4 Mar 2023 12:37:00 -0500 [thread overview]
Message-ID: <53080af8-1818-5b3e-9a8a-015c138fba17@redhat.com> (raw)
In-Reply-To: <20221227211145.3765256-1-adhemerval.zanella@linaro.org>
On 12/27/22 16:11, Adhemerval Zanella via Libc-alpha wrote:
> The vtables hardening are not enabled with --with-default-link=no
s/are/is/g
> (tst-relro-libc fails [1]) and with --with-default-link=yes it also
> requires ld.bfd to be available [2]. Furthermore, only lld 15
> supports custom RELRO sections in linker script, even though older
> version does support building glibc for some architectures.
s/version does/versions do/g
>
> The patchset removes the --with-default-link by replacing
> libc_freeres_ptrs and libc_subfreeres with weak function calls, and by
> refactoring the vtables hardening with a array placed directly on
s/a/an/g
s/on/in the/g
Please post v4.
> RELRO segment.
>
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25812
> [2] https://sourceware.org/git/?p=glibc.git;a=commit;h=2ae7990542e1955097aa21943e416dec70f867fa
>
> Changes from v2:
> - Add pragma weak for weakly called function at malloc/set-freeres.c.
> - Remove _IO_str_*, _IO_new_file_*, and _IO_old_ from pragma weak directive.
>
> Adhemerval Zanella (4):
> Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions
> libio: Remove the usage of __libc_IO_vtables
> Remove --with-default-link configure option
> Remove set-hooks.h from generic includes
>
> INSTALL | 6 -
> Makerules | 52 +-
> config.make.in | 1 -
> configure | 13 -
> configure.ac | 7 -
> crypt/md5-crypt.c | 7 +-
> crypt/sha256-crypt.c | 7 +-
> crypt/sha512-crypt.c | 7 +-
> dlfcn/dlerror.h | 1 -
> elf/Makefile | 18 +-
> elf/dl-libc.c | 5 +-
> grp/fgetgrent.c | 5 +-
> gshadow/fgetsgent.c | 5 +-
> {include => hurd}/set-hooks.h | 0
> iconv/gconv_cache.c | 3 +-
> iconv/gconv_conf.c | 3 +-
> iconv/gconv_db.c | 6 +-
> iconv/gconv_dl.c | 5 +-
> iconvdata/extra-module.mk | 2 +-
> include/libc-symbols.h | 91 +---
> include/set-freeres.h | 142 +++++
> inet/getnameinfo.c | 5 +-
> inet/getnetgrent.c | 5 +-
> inet/rcmd.c | 5 +-
> inet/rexec.c | 5 +-
> intl/dcigettext.c | 3 +-
> intl/finddomain.c | 2 +-
> intl/loadmsgcat.c | 1 -
> intl/localealias.c | 15 +-
> libio/Makefile | 2 +
> libio/fcloseall.c | 1 +
> libio/fileops.c | 81 +--
> libio/genops.c | 8 +-
> libio/iofopncook.c | 60 +--
> libio/iopopen.c | 25 -
> libio/libio-macros.sym | 7 +
> libio/libioP.h | 137 ++++-
> libio/memstream.c | 32 +-
> libio/oldfileops.c | 23 -
> libio/oldiopopen.c | 23 -
> libio/stdio.c | 3 +
> libio/strfile.h | 2 -
> libio/strops.c | 24 -
> libio/tst-vtables-interposed.c | 5 +
> libio/vtables.c | 497 ++++++++++++++++++
> libio/wfileops.c | 79 +--
> libio/wmemstream.c | 32 +-
> libio/wstrops.c | 24 -
> locale/loadarchive.c | 2 +-
> locale/localeinfo.h | 4 +-
> locale/setlocale.c | 4 +-
> login/getutent.c | 5 +-
> login/getutid.c | 6 +-
> login/getutline.c | 5 +-
> malloc/set-freeres.c | 156 +++++-
> malloc/thread-freeres.c | 9 +-
> manual/install.texi | 6 -
> misc/efgcvt-template.c | 5 +-
> misc/efgcvt.c | 1 +
> misc/fstab.c | 3 +-
> misc/hsearch.c | 4 -
> misc/mntent.c | 5 +-
> misc/qefgcvt.c | 1 +
> misc/unwind-link.c | 2 +-
> nptl/nptlfreeres.c | 1 -
> nscd/nscd_getgr_r.c | 3 +-
> nscd/nscd_gethst_r.c | 3 +-
> nscd/nscd_getpw_r.c | 3 +-
> nscd/nscd_getserv_r.c | 3 +-
> nscd/nscd_netgroup.c | 3 +-
> nss/getXXbyYY.c | 7 +-
> nss/getXXent.c | 7 +-
> nss/nss_action.c | 2 +-
> nss/nss_action.h | 3 -
> nss/nss_database.c | 2 +-
> nss/nss_database.h | 3 -
> nss/nss_module.c | 2 +-
> nss/nss_module.h | 3 -
> posix/regcomp.c | 3 +-
> posix/register-atfork.c | 3 +-
> pwd/fgetpwent.c | 5 +-
> resolv/gai_misc.c | 6 +-
> resolv/res-close.c | 2 -
> resolv/res_hconf.c | 16 +-
> resolv/resolv-internal.h | 14 +
> resolv/resolv_conf.c | 3 +-
> resolv/tst-leaks2.c | 2 +
> rt/aio_misc.c | 6 +-
> shadow/fgetspent.c | 5 +-
> stdio-common/printf_buffer_as_file.c | 28 +-
> stdio-common/reg-modifier.c | 3 +-
> stdio-common/reg-printf.c | 6 +-
> stdio-common/reg-type.c | 6 +-
> stdio-common/wprintf_buffer_as_file.c | 28 +-
> stdlib/exit.c | 2 +-
> stdlib/fmtmsg.c | 3 +-
> stdlib/setenv.c | 3 +-
> sunrpc/clnt_perr.c | 4 +-
> sunrpc/rpc_thread.c | 1 -
> sunrpc/tst-svc_register.c | 6 +-
> sysdeps/generic/set-freeres-fp.h | 19 +
> sysdeps/generic/set-freeres-os.h | 19 +
> sysdeps/generic/set-freeres-system.h | 27 +
> .../ldbl-128ibm-compat/ieee128-qefgcvt.c | 1 +
> .../ldbl-128ibm-compat/set-freeres-fp.h | 22 +
> sysdeps/mach/hurd/bits/errno.h | 1 -
> sysdeps/posix/getaddrinfo.c | 5 +-
> sysdeps/posix/ttyname.c | 4 +-
> sysdeps/unix/sysv/linux/check_pf.c | 3 +-
> .../unix/sysv/linux/s390/s390-32/getutent.c | 1 +
> .../unix/sysv/linux/s390/s390-32/getutid.c | 1 +
> .../unix/sysv/linux/s390/s390-32/getutline.c | 1 +
> sysdeps/unix/sysv/linux/set-freeres-os.h | 24 +
> sysdeps/unix/sysv/linux/ttyname.c | 8 +-
> time/tzfile.c | 5 +-
> time/tzset.c | 3 +-
> 116 files changed, 1247 insertions(+), 807 deletions(-)
> rename {include => hurd}/set-hooks.h (100%)
> create mode 100644 include/set-freeres.h
> create mode 100644 libio/libio-macros.sym
> create mode 100644 sysdeps/generic/set-freeres-fp.h
> create mode 100644 sysdeps/generic/set-freeres-os.h
> create mode 100644 sysdeps/generic/set-freeres-system.h
> create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/set-freeres-fp.h
> create mode 100644 sysdeps/unix/sysv/linux/set-freeres-os.h
>
--
Cheers,
Carlos.
next prev parent reply other threads:[~2023-03-04 17:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 21:11 Adhemerval Zanella
2022-12-27 21:11 ` [PATCH v3 1/4] Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions Adhemerval Zanella
2023-03-04 17:37 ` Carlos O'Donell
2022-12-27 21:11 ` [PATCH v3 2/4] libio: Remove the usage of __libc_IO_vtables Adhemerval Zanella
2023-03-04 17:37 ` Carlos O'Donell
2023-03-06 13:43 ` Adhemerval Zanella Netto
2023-03-27 12:53 ` Carlos O'Donell
2023-03-06 14:58 ` Arsen Arsenović
2023-03-06 16:01 ` Adhemerval Zanella Netto
2023-03-06 16:31 ` Andreas Schwab
2023-03-06 16:39 ` Adhemerval Zanella Netto
2023-03-06 16:53 ` Andreas Schwab
2023-03-06 17:24 ` Adhemerval Zanella Netto
2023-03-06 18:17 ` Adhemerval Zanella Netto
2023-03-06 18:47 ` Arsen Arsenović
2023-03-06 18:53 ` Adhemerval Zanella Netto
2023-03-06 19:10 ` Arsen Arsenović
2023-03-06 19:20 ` Adhemerval Zanella Netto
2023-03-06 19:26 ` Arsen Arsenović
2023-03-06 16:23 ` Andreas Schwab
2022-12-27 21:11 ` [PATCH v3 3/4] Remove --with-default-link configure option Adhemerval Zanella
2023-03-04 17:39 ` Carlos O'Donell
2022-12-27 21:11 ` [PATCH v3 4/4] Remove set-hooks.h from generic includes Adhemerval Zanella
2023-03-04 17:42 ` Carlos O'Donell
2023-03-04 17:37 ` Carlos O'Donell [this message]
2023-03-06 13:43 ` [PATCH v3 0/4] Remove --with-default-link option Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53080af8-1818-5b3e-9a8a-015c138fba17@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).