From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by sourceware.org (Postfix) with ESMTPS id C75AF3858D28 for ; Tue, 18 Apr 2023 12:37:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C75AF3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1E33B501FAB; Tue, 18 Apr 2023 12:37:54 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A3C1A501ACC; Tue, 18 Apr 2023 12:37:53 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1681821473; a=rsa-sha256; cv=none; b=JuLGBSKgrA4Fa518GIxEs06dTB9J4F4egtzKbD7ZQPYUg4VaPR2WDqKKMr5vVOi5uo+xSn jSdRtI7pv2h3pDnIAaaxzK5J3J2Qt0OAIk2Z7AX2MqYJHAolSzoJkI62Vgp6XPp7FzZwfV awktBMUlJIbewTOl4qD+r2qfhelKqNEcD00YK+T60l0tfWd00LTzUhmFOzwQR3vZ9l6cGN K7SFq1pF97Lb3XSPqubuRyvOtDNTUHbKxz2V3CskUrqvaaOsJHqXsFSxAwaIcfK/aDARHX tmNYtgBI8MFYf8nbkRYtJxA9nSGkT1qZsF5P1smPIplQTpJ9VxmchSvQzxETug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1681821473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1O0uVQfE3vF18kCmFHo9BpE57JUJsI03PUFK/oYn3Qg=; b=oOY4g7P0qpkodpzADpKWZJulH20YaWuMlExmBakYvKeaXpsDlSR9Md019Oft9reul3GJjS 3/WcvToNVhE+Ol65SAgDHgVvDoSKXtJsRCjAvp/khhsP1CD7j7pbPo306KAC+xX0Zst2N0 1S6dwOxdu9FyZhbQJRQAGxV1Wobwq234+EC6IBM4V8vG56Es0HkYeURpgNPa9sMNw1xDPs N11pTzPeAstt5tN1RJPeV5PwZSBzvSUhP4pOw2P2EzDHdneB5L9Tf2S+7CpXUmRA0JazsC 9yPGy9cWXtEpEK+ljU3uQE3tCcEMKnlVcOm1cVJYnBYyZ896PSeXfYUCAClxSw== ARC-Authentication-Results: i=1; rspamd-548d6c8f77-lxbh4; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Reign-Callous: 6fc460f87d7e941d_1681821473923_1846489692 X-MC-Loop-Signature: 1681821473923:3016303813 X-MC-Ingress-Time: 1681821473923 Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.125.42.190 (trex/6.7.2); Tue, 18 Apr 2023 12:37:53 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-09-174-91-45-80.dsl.bell.ca [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4Q13Nd0rSTzLs; Tue, 18 Apr 2023 05:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1681821473; bh=1O0uVQfE3vF18kCmFHo9BpE57JUJsI03PUFK/oYn3Qg=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=kZi3EYQK0zfK31hbUuhaJbe9znu+ToNkZefJ04SEOxyYOhV3mt2vfBAIs3cu7o3tt OYS6VdIvFB4Y9vhGyRrZmHXZisgWdWNXbrxoPJOgaLacnPbPaA3RUlS/TpX51oe2VJ 0Wx+yoIipKm9OjaWOgArwrKyVY8Dkt00rNTH09HYhr4JCbuowtPlF+YZv6BzviVEDc NkSIXVv4M1ECEEzQ5FZNxbcgVbpUQDiDUit+W8QqKsd4Pvugj3hmjb69o1uDLcxnQT T2c1ShMi2xkwZRBSDXw3Td0w1wI2PN3NyYG6ohDP1RzHSxVK2nCKgx9AJS533BRpy1 9R9RyxlunPDDA== Message-ID: <531b1016-8e93-f4e5-0539-a4efbec828d7@gotplt.org> Date: Tue, 18 Apr 2023 08:37:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 3/8] inet/rcmd.c: fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org Cc: sipoyare@redhat.com References: <20230418121130.844302-1-fberat@redhat.com> <20230418121130.844302-4-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230418121130.844302-4-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3038.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-18 08:11, Frédéric Bérat via Libc-alpha wrote: > Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in > glibc. > --- > inet/rcmd.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) LGTM. Reviewed-by: Siddhesh Poyarekar > > diff --git a/inet/rcmd.c b/inet/rcmd.c > index ad8a894907..c1cd9daeb5 100644 > --- a/inet/rcmd.c > +++ b/inet/rcmd.c > @@ -561,7 +561,9 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, > reading an NFS mounted file system, can't read files that > are protected read/write owner only. */ > uid = __geteuid (); > - seteuid (pwd->pw_uid); > + if (seteuid (pwd->pw_uid) < 0) > + return -1; > + > hostf = iruserfopen (pbuf, pwd->pw_uid); > > if (hostf != NULL) > @@ -570,7 +572,8 @@ ruserok2_sa (struct sockaddr *ra, size_t ralen, int superuser, > fclose (hostf); > } > > - seteuid (uid); > + if (seteuid (uid) < 0) > + return -1; > return isbad; > } > return -1;