* [PATCH 5/8] nptl: Add C11 threads tss_* functions
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 2/8] nptl: Add C11 threads mtx_* functions Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 1/8] nptl: Add C11 threads thrd_* functions Adhemerval Zanella
` (6 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the tss_* definitions from C11 threads (ISO/IEC 9899:2011),
more specifically tss_create, tss_delete, tss_get, tss_set, and required
types.
Mostly of the definitions are composed based on POSIX conterparts, including
tss_t (pthread_key_t).
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* conform/data/threads.h-data (thread_local): New macro.
(TSS_DTOR_ITERATIONS): Likewise.
(tss_t): New type.
(tss_dtor_t): Likewise.
(tss_create): New function.
(tss_get): Likewise.
(tss_set): Likewise.
(tss_delete): Likewise.
* nptl/Makefile (libpthread-routines): Add tss_create, tss_delete,
tss_get, and tss_set objects.
* nptl/Versions (libpthread) [GLIBC_2.27]: Likewise.
* nptl/tss_create.c: New file.
* nptl/tss_delete.c: Likewise.
* nptl/tss_get.c: Likewise.
* nptl/tss_set.c: Likewise.
* sysdeps/nptl/threads.h (thread_local): New define.
(TSS_DTOR_ITERATIONS): Likewise.
(tss_t): New typedef.
(tss_dtor_t): Likewise.
(tss_create): New prototype.
(tss_get): Likewise.
(tss_set): Likewise.
(tss_delete): Likewise.
---
ChangeLog | 24 ++++++++++++++++++++++++
conform/data/threads.h-data | 9 +++++++++
nptl/Makefile | 3 ++-
nptl/Versions | 3 ++-
nptl/tss_create.c | 31 +++++++++++++++++++++++++++++++
nptl/tss_delete.c | 27 +++++++++++++++++++++++++++
nptl/tss_get.c | 27 +++++++++++++++++++++++++++
nptl/tss_set.c | 28 ++++++++++++++++++++++++++++
sysdeps/nptl/threads.h | 23 +++++++++++++++++++++++
9 files changed, 173 insertions(+), 2 deletions(-)
create mode 100644 nptl/tss_create.c
create mode 100644 nptl/tss_delete.c
create mode 100644 nptl/tss_get.c
create mode 100644 nptl/tss_set.c
diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
index d7c562e..406e497 100644
--- a/conform/data/threads.h-data
+++ b/conform/data/threads.h-data
@@ -1,6 +1,8 @@
#if defined ISO11
macro ONCE_FLAG_INIT
+macro thread_local
+macro-int-constant TSS_DTOR_ITERATIONS
constant thrd_success
constant thrd_busy
@@ -17,6 +19,8 @@ type thrd_start_t
type mtx_t
type once_flag
type cnd_t
+type tss_t
+type tss_dtor_t
function int thrd_create (thrd_t*, thrd_start_t, void*)
function int thrd_equal (thrd_t, thrd_t)
@@ -43,6 +47,11 @@ function int cnd_wait (cnd_t*, mtx_t*)
function int cnd_timedwait (cnd_t*, mtx_t*, const struct timespec*)
function void cnd_destroy (cnd_t*)
+function int tss_create (tss_t*, tss_dtor_t)
+function {void*} tss_get (tss_t)
+function int tss_set (tss_t, void*)
+function void tss_delete (tss_t)
+
#include "time.h-data"
#endif
diff --git a/nptl/Makefile b/nptl/Makefile
index ddef534..0bf46ce 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -143,7 +143,8 @@ libpthread-routines = nptl-init vars events version pt-interp \
thrd_exit thrd_join thrd_sleep thrd_yield \
mtx_destroy mtx_init mtx_lock mtx_timedlock \
mtx_trylock mtx_unlock call_once cnd_broadcast \
- cnd_destroy cnd_init cnd_signal cnd_timedwait cnd_wait
+ cnd_destroy cnd_init cnd_signal cnd_timedwait cnd_wait \
+ tss_create tss_delete tss_get tss_set
# pthread_setuid pthread_seteuid pthread_setreuid \
# pthread_setresuid \
# pthread_setgid pthread_setegid pthread_setregid \
diff --git a/nptl/Versions b/nptl/Versions
index 53e6b9a..d4dc750 100644
--- a/nptl/Versions
+++ b/nptl/Versions
@@ -270,7 +270,8 @@ libpthread {
thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join;
thrd_sleep; thrd_yield; mtx_init; mtx_lock; mtx_timedlock; mtx_trylock;
mtx_unlock; mtx_destroy; call_once; cnd_broadcast; cnd_destroy; cnd_init;
- cnd_signal; cnd_timedwait; cnd_wait; mtx_destroy;
+ cnd_signal; cnd_timedwait; cnd_wait; mtx_destroy; tss_create; tss_delete;
+ tss_get; tss_set;
}
GLIBC_PRIVATE {
diff --git a/nptl/tss_create.c b/nptl/tss_create.c
new file mode 100644
index 0000000..ef6d7bb
--- /dev/null
+++ b/nptl/tss_create.c
@@ -0,0 +1,31 @@
+/* C11 threads thread-specific creation implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Create new thread-specific storage key and stores it in the object
+ pointed by tss_id. If destructor is not NULL, destructor function is
+ called when the thread terminates. */
+int
+tss_create (tss_t *tss_id, tss_dtor_t destructor)
+{
+ _Static_assert (sizeof (tss_t) == sizeof (pthread_key_t), "tss_t size");
+
+ int err_code = __pthread_key_create (tss_id, destructor);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/tss_delete.c b/nptl/tss_delete.c
new file mode 100644
index 0000000..bcbc748
--- /dev/null
+++ b/nptl/tss_delete.c
@@ -0,0 +1,27 @@
+/* C11 threads thread-specific delete implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Destroys the thread-specific storage identified by tss_id. The
+ destructor is not called until thrd_exit is called. */
+void
+tss_delete (tss_t tss_id)
+{
+ __pthread_key_delete (tss_id);
+}
diff --git a/nptl/tss_get.c b/nptl/tss_get.c
new file mode 100644
index 0000000..784a1cf
--- /dev/null
+++ b/nptl/tss_get.c
@@ -0,0 +1,27 @@
+/* C11 threads thread-specific get implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Return the value held in thread-specific storage for the current
+ thread identified by tss_id. */
+void *
+tss_get (tss_t tss_id)
+{
+ return __pthread_getspecific (tss_id);
+}
diff --git a/nptl/tss_set.c b/nptl/tss_set.c
new file mode 100644
index 0000000..16a0b04
--- /dev/null
+++ b/nptl/tss_set.c
@@ -0,0 +1,28 @@
+/* C11 threads thread-specific set implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Sets the value of the thread-specific storage identified by tss_id for
+ the current thread to val. */
+int
+tss_set (tss_t tss_id, void *val)
+{
+ int err_code = __pthread_setspecific (tss_id, val);
+ return thrd_err_map (err_code);
+}
diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h
index 568e2d4..9ca3695 100644
--- a/sysdeps/nptl/threads.h
+++ b/sysdeps/nptl/threads.h
@@ -28,6 +28,10 @@ __BEGIN_DECLS
#include <bits/types/struct_timespec.h>
#define ONCE_FLAG_INIT 0
+#define thread_local _Thread_local
+#define TSS_DTOR_ITERATIONS 4
+typedef unsigned int tss_t;
+typedef void (*tss_dtor_t) (void*);
typedef unsigned long int thrd_t;
typedef int (*thrd_start_t) (void*);
@@ -170,6 +174,25 @@ extern int cnd_timedwait (cnd_t *__restrict __cond,
resources. */
extern void cnd_destroy (cnd_t *__cond);
+/* Thread specific storage functions. */
+
+/* Create new thread-specific storage key and stores it in the object pointed
+ by __tss_id. If __destructor is not NULL, __destructor function is called
+ when the thread terminates. */
+extern int tss_create (tss_t *__tss_id, tss_dtor_t __destructor);
+
+/* Return the value held in thread-specific storage for the current thread
+ identified by __tss_id. */
+extern void *tss_get (tss_t __tss_id);
+
+/* Sets the value of the thread-specific storage identified by __tss_id for
+ the current thread to __val. */
+extern int tss_set (tss_t __tss_id, void *__val);
+
+/* Destroys the thread-specific storage identified by __tss_id. The
+ destructor is not called until thrd_exit is called. */
+extern void tss_delete (tss_t __tss_id);
+
__END_DECLS
#endif /* _THREADS_H */
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 6/8] nptl: Add abilist symbols for C11 threads
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (5 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 8/8] Add manual documentation for threads.h Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 4/8] nptl: Add C11 threads cnd_* functions Adhemerval Zanella
2017-10-03 19:07 ` [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the required abilist symbols for C11 thread support.
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* sysdeps/unix/sysv/linux/aarch64/libpthread.abilist: Add C11 thread
symbols.
* sysdeps/unix/sysv/linux/alpha/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/arm/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/hppa/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/i386/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/ia64/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/microblaze/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/nios2/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist:
Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist:
Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist:
Likewise.
* sysdpes/unix/sysv/linux/s390/s390-32/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/sh/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libpthread.abilist:
Likewise.
* sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libpthread.abilist:
Likewise.
* sysdeps/unix/sysv/linux/tile/tilepro/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist: Likewise.
* sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist: Likewise.
---
ChangeLog | 32 ++++++++++++++++++++++
sysdeps/unix/sysv/linux/aarch64/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/alpha/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/arm/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/hppa/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/i386/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/ia64/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/m68k/coldfire/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/m68k/m680x0/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/microblaze/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/mips/mips32/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/mips/mips64/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/nios2/libpthread.abilist | 26 ++++++++++++++++++
.../linux/powerpc/powerpc32/libpthread.abilist | 26 ++++++++++++++++++
.../linux/powerpc/powerpc64/libpthread-le.abilist | 26 ++++++++++++++++++
.../linux/powerpc/powerpc64/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/s390/s390-32/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/s390/s390-64/libpthread.abilist | 26 ++++++++++++++++++
sysdeps/unix/sysv/linux/sh/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/sparc/sparc32/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/sparc/sparc64/libpthread.abilist | 26 ++++++++++++++++++
.../linux/tile/tilegx/tilegx32/libpthread.abilist | 26 ++++++++++++++++++
.../linux/tile/tilegx/tilegx64/libpthread.abilist | 26 ++++++++++++++++++
.../sysv/linux/tile/tilepro/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/x86_64/64/libpthread.abilist | 26 ++++++++++++++++++
.../unix/sysv/linux/x86_64/x32/libpthread.abilist | 26 ++++++++++++++++++
26 files changed, 682 insertions(+)
diff --git a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist
index 0cf30ee..dceef50 100644
--- a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist
@@ -224,3 +224,29 @@ GLIBC_2.17 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist
index 7e121d4..b55f124 100644
--- a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist
@@ -216,6 +216,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/arm/libpthread.abilist b/sysdeps/unix/sysv/linux/arm/libpthread.abilist
index 91545c1..2ca90a1 100644
--- a/sysdeps/unix/sysv/linux/arm/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/arm/libpthread.abilist
@@ -9,6 +9,32 @@ GLIBC_2.12 pthread_setname_np F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.4 GLIBC_2.4 A
GLIBC_2.4 _IO_flockfile F
GLIBC_2.4 _IO_ftrylockfile F
diff --git a/sysdeps/unix/sysv/linux/hppa/libpthread.abilist b/sysdeps/unix/sysv/linux/hppa/libpthread.abilist
index a73aa43..f44d016 100644
--- a/sysdeps/unix/sysv/linux/hppa/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/hppa/libpthread.abilist
@@ -204,6 +204,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/i386/libpthread.abilist b/sysdeps/unix/sysv/linux/i386/libpthread.abilist
index 8f9c325..81f3c10 100644
--- a/sysdeps/unix/sysv/linux/i386/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/i386/libpthread.abilist
@@ -216,6 +216,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/ia64/libpthread.abilist b/sysdeps/unix/sysv/linux/ia64/libpthread.abilist
index d4c8ded..71be092 100644
--- a/sysdeps/unix/sysv/linux/ia64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/ia64/libpthread.abilist
@@ -204,6 +204,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist
index 91545c1..2ca90a1 100644
--- a/sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libpthread.abilist
@@ -9,6 +9,32 @@ GLIBC_2.12 pthread_setname_np F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.4 GLIBC_2.4 A
GLIBC_2.4 _IO_flockfile F
GLIBC_2.4 _IO_ftrylockfile F
diff --git a/sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist b/sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist
index 8f9c325..81f3c10 100644
--- a/sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/m680x0/libpthread.abilist
@@ -216,6 +216,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/microblaze/libpthread.abilist b/sysdeps/unix/sysv/linux/microblaze/libpthread.abilist
index 00d948b..697fe71 100644
--- a/sysdeps/unix/sysv/linux/microblaze/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/microblaze/libpthread.abilist
@@ -223,3 +223,29 @@ GLIBC_2.18 vfork F
GLIBC_2.18 wait F
GLIBC_2.18 waitpid F
GLIBC_2.18 write F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist
index 280d99d..f65d65c 100644
--- a/sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips32/libpthread.abilist
@@ -213,6 +213,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist b/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
index ad55bdd..e70182a 100644
--- a/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist
@@ -213,6 +213,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/nios2/libpthread.abilist b/sysdeps/unix/sysv/linux/nios2/libpthread.abilist
index a10bbde..c16a527 100644
--- a/sysdeps/unix/sysv/linux/nios2/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/nios2/libpthread.abilist
@@ -221,3 +221,29 @@ GLIBC_2.21 tcdrain F
GLIBC_2.21 wait F
GLIBC_2.21 waitpid F
GLIBC_2.21 write F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist
index 14c3a86..0d007e3 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist
@@ -216,6 +216,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist
index 0cf30ee..dceef50 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist
@@ -224,3 +224,29 @@ GLIBC_2.17 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist
index 464b91a..da8acf2 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist
@@ -9,6 +9,32 @@ GLIBC_2.12 pthread_setname_np F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3 GLIBC_2.3 A
GLIBC_2.3 _IO_flockfile F
GLIBC_2.3 _IO_ftrylockfile F
diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/libpthread.abilist b/sysdeps/unix/sysv/linux/s390/s390-32/libpthread.abilist
index 3c5e11a..6db9021 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-32/libpthread.abilist
@@ -219,6 +219,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist b/sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist
index 83a1fcd..82a82b9 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/libpthread.abilist
@@ -207,6 +207,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/sh/libpthread.abilist b/sysdeps/unix/sysv/linux/sh/libpthread.abilist
index a73aa43..f44d016 100644
--- a/sysdeps/unix/sysv/linux/sh/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/sh/libpthread.abilist
@@ -204,6 +204,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist b/sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist
index 7e121d4..b55f124 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/libpthread.abilist
@@ -216,6 +216,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist b/sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist
index d4c8ded..71be092 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/libpthread.abilist
@@ -204,6 +204,32 @@ GLIBC_2.2.3 GLIBC_2.2.3 A
GLIBC_2.2.3 pthread_getattr_np F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libpthread.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libpthread.abilist
index d16158f..9193461 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libpthread.abilist
@@ -224,3 +224,29 @@ GLIBC_2.12 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libpthread.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libpthread.abilist
index d16158f..9193461 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libpthread.abilist
@@ -224,3 +224,29 @@ GLIBC_2.12 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/tile/tilepro/libpthread.abilist b/sysdeps/unix/sysv/linux/tile/tilepro/libpthread.abilist
index d16158f..9193461 100644
--- a/sysdeps/unix/sysv/linux/tile/tilepro/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilepro/libpthread.abilist
@@ -224,3 +224,29 @@ GLIBC_2.12 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
index 85365c0..c942c64 100644
--- a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
@@ -203,6 +203,32 @@ GLIBC_2.2.5 waitpid F
GLIBC_2.2.5 write F
GLIBC_2.2.6 GLIBC_2.2.6 A
GLIBC_2.2.6 __nanosleep F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
GLIBC_2.3.2 GLIBC_2.3.2 A
GLIBC_2.3.2 pthread_cond_broadcast F
GLIBC_2.3.2 pthread_cond_destroy F
diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist b/sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist
index 6cd0fc3..5908592 100644
--- a/sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/x32/libpthread.abilist
@@ -224,3 +224,29 @@ GLIBC_2.16 write F
GLIBC_2.18 GLIBC_2.18 A
GLIBC_2.18 pthread_getattr_default_np F
GLIBC_2.18 pthread_setattr_default_np F
+GLIBC_2.27 GLIBC_2.27 A
+GLIBC_2.27 call_once F
+GLIBC_2.27 cnd_broadcast F
+GLIBC_2.27 cnd_destroy F
+GLIBC_2.27 cnd_init F
+GLIBC_2.27 cnd_signal F
+GLIBC_2.27 cnd_timedwait F
+GLIBC_2.27 cnd_wait F
+GLIBC_2.27 mtx_destroy F
+GLIBC_2.27 mtx_init F
+GLIBC_2.27 mtx_lock F
+GLIBC_2.27 mtx_timedlock F
+GLIBC_2.27 mtx_trylock F
+GLIBC_2.27 mtx_unlock F
+GLIBC_2.27 thrd_create F
+GLIBC_2.27 thrd_current F
+GLIBC_2.27 thrd_detach F
+GLIBC_2.27 thrd_equal F
+GLIBC_2.27 thrd_exit F
+GLIBC_2.27 thrd_join F
+GLIBC_2.27 thrd_sleep F
+GLIBC_2.27 thrd_yield F
+GLIBC_2.27 tss_create F
+GLIBC_2.27 tss_delete F
+GLIBC_2.27 tss_get F
+GLIBC_2.27 tss_set F
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 4/8] nptl: Add C11 threads cnd_* functions
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (6 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 6/8] nptl: Add abilist symbols for C11 threads Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-10-03 19:07 ` [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the cnd_* definitions from C11 threads (ISO/IEC 9899:2011),
more specifically cnd_broadcast, cnd_destroy, cnd_init, cnd_signal,
cnd_timedwait, cnd_wait, and required types.
Mostly of the definitions are composed based on POSIX conterparts, and
cnd_t is also based on internal pthreads fields, but with distinct internal
layout to avoid possible issues with code interchange (such as trying to pass
POSIX structure on C11 functions and to avoid inclusion of pthread.h). The
idea is to make it possible to share POSIX internal implementation for mostly
of the code making adjust where only required.
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* conform/data/threads.h-data (cnd_t): New type.
(cnd_init): New function.
(cnd_signal): Likewise.
(cnd_broadcast): Likewise.
(cnd_wait): Likewise.
(cnd_timedwait): Likewise.
(cnd_destroy): Likewise.
* nptl/Makefile (libpthread-routines): Add cnd_broadcast,
cnd_destroy, cnd_init, cnd_signal, cnd_timedwait, and cnd_wait
object.
* nptl/Versions (libpthread) [GLIBC_2.27]: Likewise.
* nptl/cnd_broadcast.c: New file.
* nptl/cnd_destroy.c: Likewise.
* nptl/cnd_init.c: Likewise.
* nptl/cnd_signal.c: Likewise.
* nptl/cnd_timedwait.c: Likewise.
* nptl/cnd_wait.c: Likewise.
* sysdeps/nptl/threads.h (cnd_t): New type.
(cnd_init): New prototype.
(cnd_signa): Likewise.
(cnd_broadcast): Likewise.
(cnd_wait): Likewise.
(cnd_timedwait): Likewise.
(cnd_destroy): Likewise.
---
ChangeLog | 25 +++++++++++++++++++++++++
conform/data/threads.h-data | 8 ++++++++
nptl/Makefile | 3 ++-
nptl/Versions | 3 ++-
nptl/cnd_broadcast.c | 28 ++++++++++++++++++++++++++++
nptl/cnd_destroy.c | 28 ++++++++++++++++++++++++++++
nptl/cnd_init.c | 33 +++++++++++++++++++++++++++++++++
nptl/cnd_signal.c | 28 ++++++++++++++++++++++++++++
nptl/cnd_timedwait.c | 31 +++++++++++++++++++++++++++++++
nptl/cnd_wait.c | 28 ++++++++++++++++++++++++++++
sysdeps/nptl/threads.h | 34 ++++++++++++++++++++++++++++++++++
11 files changed, 247 insertions(+), 2 deletions(-)
create mode 100644 nptl/cnd_broadcast.c
create mode 100644 nptl/cnd_destroy.c
create mode 100644 nptl/cnd_init.c
create mode 100644 nptl/cnd_signal.c
create mode 100644 nptl/cnd_timedwait.c
create mode 100644 nptl/cnd_wait.c
diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
index 70b2fe0..d7c562e 100644
--- a/conform/data/threads.h-data
+++ b/conform/data/threads.h-data
@@ -16,6 +16,7 @@ type thrd_t
type thrd_start_t
type mtx_t
type once_flag
+type cnd_t
function int thrd_create (thrd_t*, thrd_start_t, void*)
function int thrd_equal (thrd_t, thrd_t)
@@ -35,6 +36,13 @@ function void mtx_destroy (mtx_t*)
function void call_once (once_flag*, void (*)(void))
+function int cnd_init (cnd_t*)
+function int cnd_signal (cnd_t*)
+function int cnd_broadcast (cnd_t*)
+function int cnd_wait (cnd_t*, mtx_t*)
+function int cnd_timedwait (cnd_t*, mtx_t*, const struct timespec*)
+function void cnd_destroy (cnd_t*)
+
#include "time.h-data"
#endif
diff --git a/nptl/Makefile b/nptl/Makefile
index 7d2b83f..ddef534 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -142,7 +142,8 @@ libpthread-routines = nptl-init vars events version pt-interp \
thrd_create thrd_current thrd_detach thrd_equal \
thrd_exit thrd_join thrd_sleep thrd_yield \
mtx_destroy mtx_init mtx_lock mtx_timedlock \
- mtx_trylock mtx_unlock call_once
+ mtx_trylock mtx_unlock call_once cnd_broadcast \
+ cnd_destroy cnd_init cnd_signal cnd_timedwait cnd_wait
# pthread_setuid pthread_seteuid pthread_setreuid \
# pthread_setresuid \
# pthread_setgid pthread_setegid pthread_setregid \
diff --git a/nptl/Versions b/nptl/Versions
index b055860..53e6b9a 100644
--- a/nptl/Versions
+++ b/nptl/Versions
@@ -269,7 +269,8 @@ libpthread {
GLIBC_2.27 {
thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join;
thrd_sleep; thrd_yield; mtx_init; mtx_lock; mtx_timedlock; mtx_trylock;
- mtx_unlock; mtx_destroy; call_once;
+ mtx_unlock; mtx_destroy; call_once; cnd_broadcast; cnd_destroy; cnd_init;
+ cnd_signal; cnd_timedwait; cnd_wait; mtx_destroy;
}
GLIBC_PRIVATE {
diff --git a/nptl/cnd_broadcast.c b/nptl/cnd_broadcast.c
new file mode 100644
index 0000000..8e5f165
--- /dev/null
+++ b/nptl/cnd_broadcast.c
@@ -0,0 +1,28 @@
+/* C11 thread conditional broadcast implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Unblock all threads currently waiting on condition variable pointed
+ by cond. */
+int
+cnd_broadcast (cnd_t *cond)
+{
+ int err_code = __pthread_cond_broadcast ((pthread_cond_t*) cond);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/cnd_destroy.c b/nptl/cnd_destroy.c
new file mode 100644
index 0000000..4b46132
--- /dev/null
+++ b/nptl/cnd_destroy.c
@@ -0,0 +1,28 @@
+/* C11 threads conditional destroy implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+#include "pthreadP.h"
+
+/* Destroy condition variable pointed by cond and free all of its
+ resources. */
+void
+cnd_destroy (cnd_t *cond)
+{
+ __pthread_cond_destroy ((pthread_cond_t *) cond);
+}
diff --git a/nptl/cnd_init.c b/nptl/cnd_init.c
new file mode 100644
index 0000000..eb8a544
--- /dev/null
+++ b/nptl/cnd_init.c
@@ -0,0 +1,33 @@
+/* C11 thread conditional initialization implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <stdalign.h>
+
+#include "thrd_priv.h"
+
+/* Initialize new condition variable pointed by cond. */
+int
+cnd_init (cnd_t *cond)
+{
+ _Static_assert (sizeof (cnd_t) == sizeof (pthread_cond_t), "cnd_t size");
+ _Static_assert (alignof (cnd_t) == alignof (pthread_cond_t),
+ "cnd_t alignment");
+
+ int err_code = __pthread_cond_init ((pthread_cond_t *)cond, NULL);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/cnd_signal.c b/nptl/cnd_signal.c
new file mode 100644
index 0000000..e843957
--- /dev/null
+++ b/nptl/cnd_signal.c
@@ -0,0 +1,28 @@
+/* C11 threads conditional signal implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Unblock one thread that currently waits on condition variable pointed
+ by cond. */
+int
+cnd_signal (cnd_t *cond)
+{
+ int err_code = __pthread_cond_signal ((pthread_cond_t *) cond);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/cnd_timedwait.c b/nptl/cnd_timedwait.c
new file mode 100644
index 0000000..b3c60e8
--- /dev/null
+++ b/nptl/cnd_timedwait.c
@@ -0,0 +1,31 @@
+/* C11 threads conditional timed wait implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Block current thread on the condition variable until condition variable
+ pointed by cond is signaled or time pointed by time_point is reached. */
+int
+cnd_timedwait (cnd_t *restrict cond, mtx_t *restrict mutex,
+ const struct timespec* restrict time_point)
+{
+ int err_code = __pthread_cond_timedwait ((pthread_cond_t *) cond,
+ (pthread_mutex_t *) mutex,
+ time_point);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/cnd_wait.c b/nptl/cnd_wait.c
new file mode 100644
index 0000000..298d049
--- /dev/null
+++ b/nptl/cnd_wait.c
@@ -0,0 +1,28 @@
+/* C11 threads conditional wait implementaiton.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Block current thread on the condition variable pointed by cond. */
+int
+cnd_wait (cnd_t *cond, mtx_t *mutex)
+{
+ int err_code = __pthread_cond_wait ((pthread_cond_t *) cond,
+ (pthread_mutex_t *) mutex);
+ return thrd_err_map (err_code);
+}
diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h
index 53fe731..568e2d4 100644
--- a/sysdeps/nptl/threads.h
+++ b/sysdeps/nptl/threads.h
@@ -57,6 +57,12 @@ typedef union
long int __align __LOCK_ALIGNMENT;
} mtx_t;
+typedef union
+{
+ char __size[__SIZEOF_PTHREAD_COND_T];
+ __extension__ long long int __align __LOCK_ALIGNMENT;
+} cnd_t;
+
/* Threads functions. */
/* Create a new thread executing the function __func. Arguments to __func
@@ -136,6 +142,34 @@ extern void mtx_destroy (mtx_t *__mutex);
All calls must be made with the same __flag object. */
extern void call_once (once_flag *__flag, void (*__func)(void));
+
+/* Condition variable functions. */
+
+/* Initialize new condition variable pointed by __cond. */
+extern int cnd_init (cnd_t *__cond);
+
+/* Unblock one thread that currently waits on condition variable pointed
+ by __cond. */
+extern int cnd_signal (cnd_t *__cond);
+
+/* Unblock all threads currently waiting on condition variable pointed by
+ __cond. */
+extern int cnd_broadcast (cnd_t *__cond);
+
+/* Block current thread on the condition variable pointed by __cond. */
+extern int cnd_wait (cnd_t *__cond, mtx_t *__mutex);
+
+/* Block current thread on the condition variable until condition variable
+ pointed by __cond is signaled or time pointed by __time_point is
+ reached. */
+extern int cnd_timedwait (cnd_t *__restrict __cond,
+ mtx_t *__restrict __mutex,
+ const struct timespec *__restrict __time_point);
+
+/* Destroy condition variable pointed by __cond and free all of its
+ resources. */
+extern void cnd_destroy (cnd_t *__cond);
+
__END_DECLS
#endif /* _THREADS_H */
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v7 0/8] Add support for ISO C threads.h
@ 2017-09-22 20:27 Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 2/8] nptl: Add C11 threads mtx_* functions Adhemerval Zanella
` (8 more replies)
0 siblings, 9 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This is a new update for C11 threads support based on my previous [1]
version. The main changes from previous version are:
- From discussion in last Cauldron, mtx_t and cnd_t are no longer
based on internal pthread types (__pthread_{mutex,cond}_s. It is
mainly to avoid the user to direct access the types internal
fields in a way not expected by API.
- Add static asserts for size and alignment for all required types
as an additional consistency check.
- Fix some ChangeLog references for 2.27 version.
I tested this without regression with a full make/check on
x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
powerpc-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf,
sparc64-linux-gnu, and sparcv9-linux-gnu.
[1] https://sourceware.org/ml/libc-alpha/2017-06/msg01413.html
Adhemerval Zanella (7):
nptl: Add C11 threads thrd_* functions
nptl: Add C11 threads mtx_* functions
nptl: Add C11 threads call_once functions
nptl: Add C11 threads cnd_* functions
nptl: Add C11 threads tss_* functions
nptl: Add abilist symbols for C11 threads
nptl: Add test cases for ISO C11 threads
Juan Manuel Torres Palma (1):
Add manual documentation for threads.h
ChangeLog | 174 ++++++++++
conform/Makefile | 7 +-
conform/data/threads.h-data | 57 ++++
include/stdc-predef.h | 3 -
manual/Makefile | 2 +-
manual/isothreads.texi | 355 +++++++++++++++++++++
nptl/Makefile | 15 +-
nptl/Versions | 9 +
nptl/call_once.c | 33 ++
nptl/cnd_broadcast.c | 28 ++
nptl/cnd_destroy.c | 28 ++
nptl/cnd_init.c | 33 ++
nptl/cnd_signal.c | 28 ++
nptl/cnd_timedwait.c | 31 ++
nptl/cnd_wait.c | 28 ++
nptl/descr.h | 2 +
nptl/mtx_destroy.c | 27 ++
nptl/mtx_init.c | 54 ++++
nptl/mtx_lock.c | 28 ++
nptl/mtx_timedlock.c | 31 ++
nptl/mtx_trylock.c | 29 ++
nptl/mtx_unlock.c | 28 ++
nptl/pthreadP.h | 3 +
nptl/pthread_create.c | 18 +-
nptl/thrd_create.c | 32 ++
nptl/thrd_current.c | 26 ++
nptl/thrd_detach.c | 30 ++
nptl/thrd_equal.c | 26 ++
nptl/thrd_exit.c | 27 ++
nptl/thrd_join.c | 32 ++
nptl/thrd_priv.h | 46 +++
nptl/thrd_sleep.c | 41 +++
nptl/thrd_yield.c | 29 ++
nptl/tss_create.c | 31 ++
nptl/tss_delete.c | 27 ++
nptl/tss_get.c | 27 ++
nptl/tss_set.c | 28 ++
nptl/tst-call-once.c | 66 ++++
nptl/tst-cnd-basic.c | 68 ++++
nptl/tst-cnd-broadcast.c | 83 +++++
nptl/tst-cnd-timedwait.c | 70 ++++
nptl/tst-mtx-basic.c | 73 +++++
nptl/tst-mtx-recursive.c | 45 +++
nptl/tst-mtx-timedlock.c | 98 ++++++
nptl/tst-mtx-trylock.c | 90 ++++++
nptl/tst-thrd-detach.c | 52 +++
nptl/tst-thrd-sleep.c | 51 +++
nptl/tst-tss-basic.c | 75 +++++
sysdeps/nptl/threads.h | 198 ++++++++++++
sysdeps/unix/sysv/linux/aarch64/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/alpha/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/arm/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/hppa/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/i386/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/ia64/libpthread.abilist | 26 ++
.../sysv/linux/m68k/coldfire/libpthread.abilist | 26 ++
.../unix/sysv/linux/m68k/m680x0/libpthread.abilist | 26 ++
.../unix/sysv/linux/microblaze/libpthread.abilist | 26 ++
.../unix/sysv/linux/mips/mips32/libpthread.abilist | 26 ++
.../unix/sysv/linux/mips/mips64/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/nios2/libpthread.abilist | 26 ++
.../linux/powerpc/powerpc32/libpthread.abilist | 26 ++
.../linux/powerpc/powerpc64/libpthread-le.abilist | 26 ++
.../linux/powerpc/powerpc64/libpthread.abilist | 26 ++
.../sysv/linux/s390/s390-32/libpthread.abilist | 26 ++
.../sysv/linux/s390/s390-64/libpthread.abilist | 26 ++
sysdeps/unix/sysv/linux/sh/libpthread.abilist | 26 ++
.../sysv/linux/sparc/sparc32/libpthread.abilist | 26 ++
.../sysv/linux/sparc/sparc64/libpthread.abilist | 26 ++
.../linux/tile/tilegx/tilegx32/libpthread.abilist | 26 ++
.../linux/tile/tilegx/tilegx64/libpthread.abilist | 26 ++
.../sysv/linux/tile/tilepro/libpthread.abilist | 26 ++
.../unix/sysv/linux/x86_64/64/libpthread.abilist | 26 ++
.../unix/sysv/linux/x86_64/x32/libpthread.abilist | 26 ++
74 files changed, 3060 insertions(+), 12 deletions(-)
create mode 100644 conform/data/threads.h-data
create mode 100644 manual/isothreads.texi
create mode 100644 nptl/call_once.c
create mode 100644 nptl/cnd_broadcast.c
create mode 100644 nptl/cnd_destroy.c
create mode 100644 nptl/cnd_init.c
create mode 100644 nptl/cnd_signal.c
create mode 100644 nptl/cnd_timedwait.c
create mode 100644 nptl/cnd_wait.c
create mode 100644 nptl/mtx_destroy.c
create mode 100644 nptl/mtx_init.c
create mode 100644 nptl/mtx_lock.c
create mode 100644 nptl/mtx_timedlock.c
create mode 100644 nptl/mtx_trylock.c
create mode 100644 nptl/mtx_unlock.c
create mode 100644 nptl/thrd_create.c
create mode 100644 nptl/thrd_current.c
create mode 100644 nptl/thrd_detach.c
create mode 100644 nptl/thrd_equal.c
create mode 100644 nptl/thrd_exit.c
create mode 100644 nptl/thrd_join.c
create mode 100644 nptl/thrd_priv.h
create mode 100644 nptl/thrd_sleep.c
create mode 100644 nptl/thrd_yield.c
create mode 100644 nptl/tss_create.c
create mode 100644 nptl/tss_delete.c
create mode 100644 nptl/tss_get.c
create mode 100644 nptl/tss_set.c
create mode 100644 nptl/tst-call-once.c
create mode 100644 nptl/tst-cnd-basic.c
create mode 100644 nptl/tst-cnd-broadcast.c
create mode 100644 nptl/tst-cnd-timedwait.c
create mode 100644 nptl/tst-mtx-basic.c
create mode 100644 nptl/tst-mtx-recursive.c
create mode 100644 nptl/tst-mtx-timedlock.c
create mode 100644 nptl/tst-mtx-trylock.c
create mode 100644 nptl/tst-thrd-detach.c
create mode 100644 nptl/tst-thrd-sleep.c
create mode 100644 nptl/tst-tss-basic.c
create mode 100644 sysdeps/nptl/threads.h
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 8/8] Add manual documentation for threads.h
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (4 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 3/8] nptl: Add C11 threads call_once functions Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 6/8] nptl: Add abilist symbols for C11 threads Adhemerval Zanella
` (2 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha; +Cc: Juan Manuel Torres Palma
From: Juan Manuel Torres Palma <j.m.torrespalma@gmail.com>
This patch updates the manual and adds a new chapter to the manual,
explaining types macros, constants and functions defined by ISO C11
threads.h standard.
* manual/Makefile (chapters): Add isothreads.texi.
* manual/isothreads.texi: New file. Add new chapter for ISO C11
threads documentation.
---
ChangeLog | 4 +
manual/Makefile | 2 +-
manual/isothreads.texi | 355 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 360 insertions(+), 1 deletion(-)
create mode 100644 manual/isothreads.texi
diff --git a/manual/Makefile b/manual/Makefile
index 4ed63a8..e54e0cf 100644
--- a/manual/Makefile
+++ b/manual/Makefile
@@ -39,7 +39,7 @@ chapters = $(addsuffix .texi, \
pipe socket terminal syslog math arith time \
resource setjmp signal startup process ipc job \
nss users sysinfo conf crypt debug threads \
- probes tunables)
+ probes tunables isothreads)
add-chapters = $(wildcard $(foreach d, $(add-ons), ../$d/$d.texi))
appendices = lang.texi header.texi install.texi maint.texi platform.texi \
contrib.texi
diff --git a/manual/isothreads.texi b/manual/isothreads.texi
new file mode 100644
index 0000000..bcdf127
--- /dev/null
+++ b/manual/isothreads.texi
@@ -0,0 +1,355 @@
+@node ISO Threads, , , Top
+@chapter ISO C11 threads
+
+This chapter describes @theglibc{} ISO C11 threads implementation.
+To have a deeper understanding of this API, is strongly recomended
+to read ISO/IEC 9899:2011, section 7.26 where ISO C11 threads
+are specified.
+All types and function prototypes are declared in
+@file{threads.h} header.
+@pindex threads.h
+
+@menu
+* Thread Creation and Control:: Support for basic threading.
+* Call Once:: Single call macros and functions.
+* Mutex:: Low level mechanism for mutual exclusion.
+* Condition variable:: High level objects for thread synchronization.
+* Thread-local storage:: Functions to support thread-local storage.
+* C11 error types:: Symbolic constants that represent functions return value.
+@end menu
+
+@node Thread Creation and Control, Call Once, , ISO Threads
+@section Thread Creation and Control
+
+@Theglibc{} implements a set of functions that allow the user to easily
+create and use threads. Many extra functionalities are provided to control
+the behaviour of threads. The following functions and types are defined:
+
+@deftp {Data Type} {thrd_t}
+Unique object that identifies a thread unequivocally.
+@end deftp
+
+@deftp {Data Type} {thrd_start_t}
+It is a (@code{int (*)(void *)}) typedef that is passed to @code{thrd_create}
+when creating a new thread. Should point to the first function that thread
+will run.
+@end deftp
+
+@deftypefun int thrd_create (thrd_t *@var{thr}, thrd_start_t @var{func}, void *@var{arg})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Create a new thread executing the function @var{func}. The object pointed
+by @var{arg} will be taken as @var{func} arguments. If successful,
+@var{thr} is set to the new thread identifier.
+@end deftypefun
+
+@deftypefun int thrd_equal (thrd_t @var{lhs}, thrd_t @var{rhs})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Checks whether @var{lhs} and @var{rhs} refer to the same thread.
+@end deftypefun
+
+@deftypefun thrd_t thrd_current (void)
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Returns the identifier of the calling thread.
+@end deftypefun
+
+@deftypefun int thrd_sleep (const struct timespec *@var{time_point}, struct timespec *@var{remaining})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Blocks the execution of the current thread for at least until the wall-clock
+time point pointed to by @var{time_point} has been reached. This function
+does not take an absolute time, but a duration that the thread is required
+to be blocked.
+
+The sleep may resume earlier if a signal that is not ignored is received.
+In such case, if remaining is not NULL, the remaining time duration is stored
+into the object pointed to by @var{remaining}
+@end deftypefun
+
+@deftypefun void thrd_yield (void)
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Provides a hint to the implementation to reschedule the execution of threads,
+allowing other threads to run.
+@end deftypefun
+
+@deftypefun _Noreturn void thrd_exit (int @var{res})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Terminates execution of the calling thread and sets its result code to
+@var{res}.
+If this function is called from a single thread process, the call to this
+function is equivalent to @code{exit(0)}. Returning from a thread-start
+function is equivalent to calling @code{thrd_exit}.
+@end deftypefun
+
+@deftypefun int thrd_detach (thrd_t @var{thr})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Detaches the thread identified by @var{thr} from the current control thread.
+The resources held by the thread will be freed automatically once the thread
+exits. The parent thread will never be notified by any @var{thr} signal.
+@end deftypefun
+
+@deftypefun int thrd_join (thrd_t @var{thr}, int *@var{res})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Blocks the current thread until the thread identified by @var{thr} finishes
+execution. If @var{res} is not a null pointer, the result code of the thread
+is put to the location pointed to by @var{res}. The termination of the thread
+synchronizes-with the completion of this function.
+The behavior is undefined if the thread was previously detached or joined by
+another thread.
+@end deftypefun
+
+@node Call Once, Mutex, Thread Creation and Control, ISO Threads
+@section Call Once
+
+In order to guarantee single access to a function, @theglibc implements a call
+once function to allow unique access in case a function is required to be
+called only once in presence of several threads.
+
+@deftp {Data Type} {once_flag}
+Complete object type capable of holding a flag used by @code{call_once}
+@end deftp
+
+@deftypevr Macro {} ONCE_FLAG_INIT
+Value established to initialize an object of type @code{once_flag}.
+@end deftypevr
+
+@deftypefun void call_once (once_flag *@var{flag}, void (*@var{func})(void))
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Calls function @var{func} exactly once, even if invoked from several threads.
+The completion of the function @var{func} synchronizes with all previous or
+subsequent calls to @code{call_once} with the same @var{flag} variable.
+@end deftypefun
+
+@node Mutex, Condition variable, Call Once, ISO Threads
+@section Mutex
+
+To have a better control of resources and how threads access them, @theglibc{}
+also implements a mutex object, that allows to avoid race conditions and some
+other concurrency issues.
+
+@deftp {Data Type} {mtx_t}
+Mutex object identifier.
+@end deftp
+
+@deftypefun int mtx_init (mtx_t *@var{mutex}, int @var{type})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Creates a new mutex object with type @var{type}. The object pointed to by
+@var{mutex} is set to an identifier of the newly created mutex.
+@end deftypefun
+
+@deftypefun int mtx_lock (mtx_t *@var{mutex})
+@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}} Blocks
+the current thread until the mutex pointed to by @var{mutex} is locked.
+The behavior is undefined if the current thread has already locked the mutex
+and the mutex is not recursive.
+Prior calls to @code{mtx_unlock} on the same mutex synchronize-with this
+operation, and all lock/unlock operations on any given mutex form a single
+total order (similar to the modification order of an atomic).
+@end deftypefun
+
+@deftypefun int mtx_timedlock (mtx_t *restrict @var{mutex}, const struct timespec *restrict @var{time_point})
+@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
+Blocks the current thread until the mutex pointed to by @var{mutex} is locked
+or until the wall-clock time pointed to by @var{time_point} has been reached.
+This function takes an absolute time, so if a duration is required, must be
+calculated manually and passed to this function.
+
+The behavior is undefined if the current thread has already locked the mutex
+and the mutex is not recursive. The behavior is undefined if the mutex does
+not support timeout.
+Prior calls to @code{mtx_unlock} on the same mutex synchronize-with this
+operation (if this operation succeeds), and all lock/unlock operations on any
+given mutex form a single total order (similar to the modification order of
+an atomic).
+@end deftypefun
+
+@deftypefun int mtx_trylock (mtx_t *@var{mutex})
+@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
+Tries to lock the mutex pointed to by @var{mutex} without blocking. Returns
+immediately if the mutex is already locked.
+Prior calls to @code{mtx_unlock} on the same mutex synchronize-with this
+operation (if this operation succeeds), and all lock/unlock operations on any
+given mutex form a single total order (similar to the modification order of
+an atomic).
+@end deftypefun
+
+@deftypefun int mtx_unlock (mtx_t *@var{mutex})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Unlocks the mutex pointed to by @var{mutex}. The behavior is undefined if the
+mutex is not locked by the calling thread. This function synchronizes-with
+subsequent @code{mtx_lock}, @code{mtx_trylock}, or @code{mtx_timedlock} on
+the same mutex. All lock/unlock operations on any given mutex form a single
+total order (similar to the modification order of an atomic).
+@end deftypefun
+
+@deftypefun void mtx_destroy (mtx_t *@var{mutex})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Destroys the mutex pointed to by @var{mutex}. If there are threads waiting
+on mutex, the behavior is undefined.
+@end deftypefun
+
+The ISO C11 standard also defines several types of mutex that are also
+supported. They are represented with symbolic constants (enumeration type
+values) and are the following:
+
+@vtable @code
+
+@item mtx_plain
+Mutex type that does not support timeout or test and return.
+
+@item mtx_recursive
+Mutex type that supports recursive locking, what means that owner thread can
+lock it twice or more without causing deadlock.
+
+@item mtx_timed
+Mutex type that supports timeout.
+
+@end vtable
+
+@node Condition variable, Thread-local storage, Mutex, ISO Threads
+@section Condition Variable
+
+Mutexes are not the only synchronization mechanisms available. For some more
+complex tasks, @theglibc{} also implements conditional variables, that allow
+the user to think in a higher level to solve complex synchronization problems.
+They are used to synchronize threads waiting on a certain condition to happen.
+
+@deftp {Data Type} {cnd_t}
+Condition variable object identifier.
+@end deftp
+
+@deftypefun int cnd_init (cnd_t *@var{cond})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Initializes new conditional variable. The object pointed to by @var{cond}
+will be set to value that identifies the conditional variable.
+@end deftypefun
+
+@deftypefun int cnd_signal (cnd_t *@var{cond})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Unblocks one thread that currently waits on conditional variable pointed to
+by @var{cond}. If no threads are blocked, does nothing and returns
+@code{thrd_success}.
+@end deftypefun
+
+@deftypefun int cnd_broadcast (cnd_t *@var{cond})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Unblocks all threads that currently wait on conditional variable pointed to
+by @var{cond}. If no threads are blocked, does nothing and returns
+@code{thrd_success}.
+@end deftypefun
+
+@deftypefun int cnd_wait (cnd_t *@var{cond}, mtx_t *@var{mutex})
+@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
+Atomically unlocks the mutex pointed to by @var{mutex} and blocks on the
+conditional variable pointed to by @var{cond} until the thread is signalled
+by @code{cnd_signal} or @code{cnd_broadcast}. The mutex is locked again
+before the function returns.
+@end deftypefun
+
+@deftypefun int cnd_timedwait (cnd_t *restrict @var{cond}, mtx_t *restrict @var{mutex}, const struct timespec *restrict @var{time_point})
+@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
+Atomically unlocks the mutex pointed to by @var{mutex} and blocks on the
+conditional variable pointed to by @var{cond} until the thread is signalled
+by @code{cnd_signal} or @code{cnd_broadcast}, or until the wall-clock time
+pointed to by @var{time_point} has been reached. The mutex is locked again
+before the function returns.
+As for @code{mtx_timedlock}, this function also takes an absolute time
+rather than a duration.
+@end deftypefun
+
+@deftypefun void cnd_destroy (cnd_t *@var{cond})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Destroys the conditional variable pointed to by @var{cond}. If there are
+threads waiting on @var{cond}, the behavior is undefined.
+@end deftypefun
+
+@node Thread-local storage, C11 error types, Condition variable, ISO Threads
+@section Thread-local Storage
+
+@Theglibc{} also implements different functions that adds funtionality for
+thread-local storage. That means that each thread can have their own
+variables and are not visible by other threads. The functions and types
+provided are:
+
+@deftp {Data Type} {tss_t}
+Thread-specific storage object. Even if shared, every thread will have
+its own instance of that variable with different values.
+@end deftp
+
+@deftp {Data Type} {tss_dtor_t}
+Function pointer of type @code{void(*)(void*)}, used for TSS destructor.
+This function will be called when the current thread calls @code{thrd_exit},
+but never when calling @code{tss_delete} or @code{exit}
+@end deftp
+
+@deftypevr Macro {} thread_local
+Used to mark a variable with thread storage duration, that means created
+when the thread starts and cleaned up when the thread ends.
+@end deftypevr
+
+@deftypevr Macro {} TSS_DTOR_ITERATIONS
+Integer constant expression representing the maximum number of times that
+destructors will be called when a thread terminates.
+@end deftypevr
+
+@deftypefun int tss_create (tss_t *@var{tss_key}, tss_dtor_t @var{destructor})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Creates new thread-specific storage key and stores it in the object pointed
+to by @var{tss_key}. Although the same key value may be used by different
+threads, the values bound to the key by @code{tss_set} are maintained on a
+per-thread basis and persist for the life of the calling thread.
+
+If @var{destructor} is different to NULL, a destructor function will be set,
+and called when the thread finishes its execution by calling @code{thrd_exit}.
+@end deftypefun
+
+@deftypefun void *tss_get (tss_t @var{tss_key})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Returns the value held in thread-specific storage for the current thread
+identified by @var{tss_key}. Different threads may get different values
+identified by the same key.
+@end deftypefun
+
+@deftypefun int tss_set (tss_t @var{tss_id}, void *@var{val})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Sets the value of the thread-specific storage identified by @var{tss_id} for
+the current thread to @var{val}. Different threads may set different values
+to the same key. The destructor, if available, is not invoked.
+@end deftypefun
+
+@deftypefun void tss_delete (tss_t @var{tss_id})
+@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}}
+Destroys the thread-specific storage identified by @var{tss_id}. The
+destructor, if one was registered by @code{tss_create}, is not called.
+@end deftypefun
+
+@node C11 error types, , Thread-local storage, ISO Threads
+@section Error Types
+
+The ISO C11 specification also provides new error types that belong
+specifically to @code{threads.h}. @Theglibc{} has also implemented this
+feature and every function in this API always returns one of the following
+error codes:
+
+@vtable @code
+
+@item thrd_timedout
+Value returned by a function to indicate that a specified time was reached
+without acquiring the requested resource, usually a mutex or conditional
+variable.
+
+@item thrd_sucess
+Value returned by a function to indicate that the requested operation
+succeded.
+
+@item thrd_busy
+Value returned by a function to indicate that the requested operation
+failed because a resource requested is already in use.
+
+@item thrd_error
+Value returned by a function to indicate that the requested operation
+failed.
+
+@item thrd_nomem
+Value returned by a function to indicate that the requested operation
+failed because it was unable to allocate enough memory.
+
+@end vtable
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/8] nptl: Add C11 threads mtx_* functions
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 5/8] nptl: Add C11 threads tss_* functions Adhemerval Zanella
` (7 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the mtx_* definitions from C11 threads (ISO/IEC 9899:2011),
more specifically mtx_init, mtx_destroy, mtx_lock, mtx_timedlock, mtx_trylock,
mtx_unlock, and required types.
Mostly of the definitions are composed based on POSIX conterparts, and mtx_t
is also based on internal pthread fields, but with a distinct internal layout
to avoid possible issues with code interchange (such as trying to pass POSIX
structure on C11 functions and to avoid inclusion of pthread.h). The idea
is to make possible to share POSIX internal implementations for mostly of
the code (and making adjustment only when required).
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* conform/data/threads.h-data (mtx_plain): New constant.
(mtx_recursive): Likewise.
(mtx_timed): Likewise.
(mtx_t): New type.
(mtx_init): New function.
(mtx_lock): Likewise.
(mtx_timedlock): Likewise.
(mtx_trylock): Likewise.
(mtx_unlock): Likewise.
(mtx_destroy): Likewise.
* nptl/Makefile (libpthread-routines): Add mtx_destroy, mtx_init,
mtx_lock, mtx_timedlock, mtx_trylock, and mtx_unlock object.
* nptl/Versions (libpthread) [GLIBC_2.27]): Add mtx_init, mtx_lock,
mtx_timedlock, mtx_trylock, mtx_unlock, and mtx_destroy.
* nptl/mtx_destroy.c: New file.
* nptl/mtx_init.c: Likewise.
* nptl/mtx_lock.c: Likewise.
* nptl/mtx_timedlock.c: Likewise.
* nptl/mtx_trylock.c: Likewise.
* nptl/mtx_unlock.c: Likewise.
* sysdeps/nptl/threads.h (mtx_plain): New enumeration.
(mtx_recursive): Likewise.
(mtx_timed): Likewise.
(mtx_t): New type.
(mtx_init): New prototype.
(mtx_lock): Likewise.
(mtx_timedlock): Likewise.
(mtx_trylock): Likewise.
(mtx_unlock): Likewise.
(mtx_destroy): Likewise.
---
ChangeLog | 31 ++++++++++++++++++++++++++
conform/data/threads.h-data | 12 ++++++++++
nptl/Makefile | 4 +++-
nptl/Versions | 3 ++-
nptl/mtx_destroy.c | 27 +++++++++++++++++++++++
nptl/mtx_init.c | 54 +++++++++++++++++++++++++++++++++++++++++++++
nptl/mtx_lock.c | 28 +++++++++++++++++++++++
nptl/mtx_timedlock.c | 31 ++++++++++++++++++++++++++
nptl/mtx_trylock.c | 29 ++++++++++++++++++++++++
nptl/mtx_unlock.c | 28 +++++++++++++++++++++++
sysdeps/nptl/threads.h | 44 ++++++++++++++++++++++++++++++++++++
11 files changed, 289 insertions(+), 2 deletions(-)
create mode 100644 nptl/mtx_destroy.c
create mode 100644 nptl/mtx_init.c
create mode 100644 nptl/mtx_lock.c
create mode 100644 nptl/mtx_timedlock.c
create mode 100644 nptl/mtx_trylock.c
create mode 100644 nptl/mtx_unlock.c
diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
index bc2d857..bb5ca75 100644
--- a/conform/data/threads.h-data
+++ b/conform/data/threads.h-data
@@ -6,8 +6,13 @@ constant thrd_error
constant thrd_nomem
constant thrd_timedout
+constant mtx_plain
+constant mtx_recursive
+constant mtx_timed
+
type thrd_t
type thrd_start_t
+type mtx_t
function int thrd_create (thrd_t*, thrd_start_t, void*)
function int thrd_equal (thrd_t, thrd_t)
@@ -18,6 +23,13 @@ function int thrd_detach (thrd_t)
function int thrd_join (thrd_t, int*)
function void thrd_yield (void)
+function int mtx_init (mtx_t*, int)
+function int mtx_lock (mtx_t*)
+function int mtx_timedlock (mtx_t*, const struct timespec*)
+function int mtx_trylock (mtx_t*)
+function int mtx_unlock (mtx_t*)
+function void mtx_destroy (mtx_t*)
+
#include "time.h-data"
#endif
diff --git a/nptl/Makefile b/nptl/Makefile
index 31761a6..c4f6970 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -140,7 +140,9 @@ libpthread-routines = nptl-init vars events version pt-interp \
pthread_setname pthread_getname \
pthread_setattr_default_np pthread_getattr_default_np \
thrd_create thrd_current thrd_detach thrd_equal \
- thrd_exit thrd_join thrd_sleep thrd_yield
+ thrd_exit thrd_join thrd_sleep thrd_yield \
+ mtx_destroy mtx_init mtx_lock mtx_timedlock \
+ mtx_trylock mtx_unlock
# pthread_setuid pthread_seteuid pthread_setreuid \
# pthread_setresuid \
# pthread_setgid pthread_setegid pthread_setregid \
diff --git a/nptl/Versions b/nptl/Versions
index a282ceb..5cf581a 100644
--- a/nptl/Versions
+++ b/nptl/Versions
@@ -268,7 +268,8 @@ libpthread {
# C11 thread symbols.
GLIBC_2.27 {
thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join;
- thrd_sleep; thrd_yield;
+ thrd_sleep; thrd_yield; mtx_init; mtx_lock; mtx_timedlock; mtx_trylock;
+ mtx_unlock; mtx_destroy;
}
GLIBC_PRIVATE {
diff --git a/nptl/mtx_destroy.c b/nptl/mtx_destroy.c
new file mode 100644
index 0000000..1fcc534
--- /dev/null
+++ b/nptl/mtx_destroy.c
@@ -0,0 +1,27 @@
+/* C11 threads mutex destroy implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+#include "pthreadP.h"
+
+/* Destroy the mutex object pointed by mutex. */
+void
+mtx_destroy (mtx_t *mutex)
+{
+ __pthread_mutex_destroy ((pthread_mutex_t *) mutex);
+}
diff --git a/nptl/mtx_init.c b/nptl/mtx_init.c
new file mode 100644
index 0000000..da27156
--- /dev/null
+++ b/nptl/mtx_init.c
@@ -0,0 +1,54 @@
+/* C11 threads mutex initialization implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <stdalign.h>
+
+#include "thrd_priv.h"
+
+/* Creates a new mutex object with type type. If successful the new object
+ is pointed by mutex. */
+int
+mtx_init (mtx_t *mutex, int type)
+{
+ _Static_assert (sizeof (mtx_t) == sizeof (pthread_mutex_t), "mtx_t size");
+ _Static_assert (alignof (mtx_t) == alignof (pthread_mutex_t),
+ "mtx_t alignment");
+
+ pthread_mutexattr_t attr;
+
+ __pthread_mutexattr_init (&attr);
+
+ /* Another possible solution would be to set the flags directly in
+ mutex object. */
+ switch (type)
+ {
+ case mtx_plain | mtx_recursive:
+ case mtx_timed | mtx_recursive:
+ __pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_RECURSIVE);
+ break;
+ case mtx_plain:
+ case mtx_timed: /* No difference between both in standard */
+ default:
+ __pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_NORMAL);
+ break;
+ }
+
+ int err_code = __pthread_mutex_init ((pthread_mutex_t *) mutex, &attr);
+ /* pthread_mutexattr_destroy implementation is a noop. */
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/mtx_lock.c b/nptl/mtx_lock.c
new file mode 100644
index 0000000..bd4c530
--- /dev/null
+++ b/nptl/mtx_lock.c
@@ -0,0 +1,28 @@
+/* C11 threads mutex lock implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Block the current thread until the mutex pointed to by mutex is
+ unlocked. In that case current thread will not be blocked. */
+int
+mtx_lock (mtx_t *mutex)
+{
+ int err_code = __pthread_mutex_lock ((pthread_mutex_t *) mutex);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/mtx_timedlock.c b/nptl/mtx_timedlock.c
new file mode 100644
index 0000000..3770d5c
--- /dev/null
+++ b/nptl/mtx_timedlock.c
@@ -0,0 +1,31 @@
+/* C11 threads mutex timed lock implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Block the current thread until the mutex pointed by mutex is unlocked
+ or time pointed by time_point is reached. In case the mutex is unlocked
+ current thread will not be blocked. */
+int
+mtx_timedlock (mtx_t *restrict mutex,
+ const struct timespec *restrict time_point)
+{
+ int err_code = __pthread_mutex_timedlock ((pthread_mutex_t *)mutex,
+ time_point);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/mtx_trylock.c b/nptl/mtx_trylock.c
new file mode 100644
index 0000000..406229a
--- /dev/null
+++ b/nptl/mtx_trylock.c
@@ -0,0 +1,29 @@
+/* C11 threads mutex try lock implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Try to lock the mutex pointed by mutex without blocking. If the mutex
+ is free the current threads takes control of it, otherwise it returns
+ immediately. */
+int
+mtx_trylock (mtx_t *mutex)
+{
+ int err_code = __pthread_mutex_trylock ((pthread_mutex_t *) mutex);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/mtx_unlock.c b/nptl/mtx_unlock.c
new file mode 100644
index 0000000..d5f9c32
--- /dev/null
+++ b/nptl/mtx_unlock.c
@@ -0,0 +1,28 @@
+/* C11 threads mutex unlock implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Unlock the mutex pointed by mutex. It may potentially awake other
+ threads waiting on this mutex. */
+int
+mtx_unlock (mtx_t *mutex)
+{
+ int err_code = __pthread_mutex_unlock ((pthread_mutex_t *) mutex);
+ return thrd_err_map (err_code);
+}
diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h
index 4b89a30..cd811f4 100644
--- a/sysdeps/nptl/threads.h
+++ b/sysdeps/nptl/threads.h
@@ -24,6 +24,7 @@
__BEGIN_DECLS
+#include <bits/pthreadtypes-arch.h>
#include <bits/types/struct_timespec.h>
typedef unsigned long int thrd_t;
@@ -39,6 +40,20 @@ enum
thrd_timedout = 4
};
+/* Mutex types. */
+enum
+{
+ mtx_plain = 0,
+ mtx_recursive = 1,
+ mtx_timed = 2
+};
+
+typedef union
+{
+ char __size[__SIZEOF_PTHREAD_MUTEX_T];
+ long int __align __LOCK_ALIGNMENT;
+} mtx_t;
+
/* Threads functions. */
/* Create a new thread executing the function __func. Arguments to __func
@@ -85,6 +100,35 @@ thrd_equal (thrd_t __thread1, thrd_t __thread2)
}
#endif
+
+/* Mutex functions. */
+
+/* Creates a new mutex object with type __type. If successful the new
+ object is pointed by __mutex. */
+extern int mtx_init (mtx_t *__mutex, int __type);
+
+/* Block the current thread until the mutex pointed to by __mutex is
+ unlocked. In that case current thread will not be blocked. */
+extern int mtx_lock (mtx_t *__mutex);
+
+/* Block the current thread until the mutex pointed by __mutex is unlocked
+ or time pointed by __time_point is reached. In case the mutex is unlock,
+ the current thread will not be blocked. */
+extern int mtx_timedlock (mtx_t *__restrict __mutex,
+ const struct timespec *__restrict __time_point);
+
+/* Try to lock the mutex pointed by __mutex without blocking. If the mutex
+ is free the current threads takes control of it, otherwise it returns
+ immediately. */
+extern int mtx_trylock (mtx_t *__mutex);
+
+/* Unlock the mutex pointed by __mutex. It may potentially awake other
+ threads waiting on this mutex. */
+extern int mtx_unlock (mtx_t *__mutex);
+
+/* Destroy the mutex object pointed by __mutex. */
+extern void mtx_destroy (mtx_t *__mutex);
+
__END_DECLS
#endif /* _THREADS_H */
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 7/8] nptl: Add test cases for ISO C11 threads
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (2 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 1/8] nptl: Add C11 threads thrd_* functions Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 3/8] nptl: Add C11 threads call_once functions Adhemerval Zanella
` (4 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds to testsuite new test cases to test all new introduced
C11 threads functions, types and macros are tested.
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Juan Manuel Torres Palma <jmtorrespalma@gmail.com>
* nptl/Makefile (tests): Add new test files.
* nptl/tst-call-once.c : New file. Tests C11 functions and types.
* nptl/tst-cnd-basic.c: Likewise.
* nptl/tst-cnd-broadcast.c: Likewise.
* nptl/tst-cnd-timedwait.c: Likewise.
* nptl/tst-mtx-basic.c: Likewise.
* nptl/tst-mtx-recursive.c: Likewise.
* nptl/tst-mtx-timedlock.c: Likewise.
* nptl/tst-mtx-trylock.c: Likewise.
* nptl/tst-thrd-basic.c: Likewise.
* nptl/tst-thrd-detach.c: Likewise.
* nptl/tst-thrd-sleep.c: Likewise.
* nptl/tst-tss-basic.c: Likewise.
---
ChangeLog | 17 +++++++++
nptl/Makefile | 5 ++-
nptl/tst-call-once.c | 66 ++++++++++++++++++++++++++++++++
nptl/tst-cnd-basic.c | 68 +++++++++++++++++++++++++++++++++
nptl/tst-cnd-broadcast.c | 83 ++++++++++++++++++++++++++++++++++++++++
nptl/tst-cnd-timedwait.c | 70 ++++++++++++++++++++++++++++++++++
nptl/tst-mtx-basic.c | 73 ++++++++++++++++++++++++++++++++++++
nptl/tst-mtx-recursive.c | 45 ++++++++++++++++++++++
nptl/tst-mtx-timedlock.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++
nptl/tst-mtx-trylock.c | 90 ++++++++++++++++++++++++++++++++++++++++++++
nptl/tst-thrd-detach.c | 52 +++++++++++++++++++++++++
nptl/tst-thrd-sleep.c | 51 +++++++++++++++++++++++++
nptl/tst-tss-basic.c | 75 ++++++++++++++++++++++++++++++++++++
13 files changed, 792 insertions(+), 1 deletion(-)
create mode 100644 nptl/tst-call-once.c
create mode 100644 nptl/tst-cnd-basic.c
create mode 100644 nptl/tst-cnd-broadcast.c
create mode 100644 nptl/tst-cnd-timedwait.c
create mode 100644 nptl/tst-mtx-basic.c
create mode 100644 nptl/tst-mtx-recursive.c
create mode 100644 nptl/tst-mtx-timedlock.c
create mode 100644 nptl/tst-mtx-trylock.c
create mode 100644 nptl/tst-thrd-detach.c
create mode 100644 nptl/tst-thrd-sleep.c
create mode 100644 nptl/tst-tss-basic.c
diff --git a/nptl/Makefile b/nptl/Makefile
index 0bf46ce..6e179b0 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -308,7 +308,10 @@ tests = tst-attr1 tst-attr2 tst-attr3 tst-default-attr \
c89 gnu89 c99 gnu99 c11 gnu11) \
tst-bad-schedattr \
tst-thread_local1 tst-mutex-errorcheck tst-robust10 \
- tst-robust-fork tst-create-detached tst-memstream
+ tst-robust-fork tst-create-detached tst-memstream \
+ tst-cnd-basic tst-mtx-trylock tst-cnd-broadcast \
+ tst-cnd-timedwait tst-thrd-detach tst-mtx-basic tst-thrd-sleep \
+ tst-mtx-recursive tst-tss-basic tst-call-once tst-mtx-timedlock
tests-internal := tst-typesizes \
tst-rwlock19 tst-rwlock20 \
diff --git a/nptl/tst-call-once.c b/nptl/tst-call-once.c
new file mode 100644
index 0000000..331174e
--- /dev/null
+++ b/nptl/tst-call-once.c
@@ -0,0 +1,66 @@
+/* C11 threads call_once test.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Flag that controls the first thread access. */
+static once_flag flag = ONCE_FLAG_INIT;
+
+static int value = 0;
+
+static void
+do_once (void)
+{
+ value++;
+}
+
+static int
+func (void* data)
+{
+ call_once (&flag, do_once);
+ thrd_exit (thrd_success);
+}
+
+#define N 20
+
+int
+do_test (void)
+{
+ thrd_t ids[N];
+
+ for (int i = 0; i < N; ++i)
+ {
+ if (thrd_create (&ids[i], func, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+ }
+
+ /* Join threads. */
+ for (int i = 0; i < N; ++i)
+ {
+ if (thrd_join (ids[i], NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+ }
+
+ return (value != 1);
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-cnd-basic.c b/nptl/tst-cnd-basic.c
new file mode 100644
index 0000000..56de4d7
--- /dev/null
+++ b/nptl/tst-cnd-basic.c
@@ -0,0 +1,68 @@
+/* C11 threads condition variable tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Shared condition variable between child and parent. */
+static cnd_t cond;
+
+/* Mutex needed to signal and wait threads. */
+static mtx_t mutex;
+
+static int
+signal_parent (void)
+{
+ if (cnd_signal (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_signal");
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+
+ if (cnd_init (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_init failed");
+ if (mtx_init (&mutex, mtx_plain) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ if (thrd_create (&id, (thrd_start_t) signal_parent, NULL)
+ != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ if (cnd_wait (&cond, &mutex) != thrd_success)
+ FAIL_EXIT1 ("cnd_wait failed");
+
+ /* Joining is not mandatory here, but still done to assure child thread
+ ends correctly. */
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+
+ mtx_destroy (&mutex);
+ cnd_destroy (&cond);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-cnd-broadcast.c b/nptl/tst-cnd-broadcast.c
new file mode 100644
index 0000000..1ca87a3
--- /dev/null
+++ b/nptl/tst-cnd-broadcast.c
@@ -0,0 +1,83 @@
+/* C11 threads condition broadcast variable tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Condition variable where child threads will wait. */
+static cnd_t cond;
+
+/* Mutex to control wait on cond. */
+static mtx_t mutex;
+
+/* Code executed by each thread. */
+static int
+child_wait (void* data)
+{
+ /* Wait until parent thread sends broadcast here. */
+ mtx_lock (&mutex);
+ cnd_wait (&cond, &mutex);
+ mtx_unlock (&mutex);
+
+ thrd_exit (thrd_success);
+}
+
+#define N 5
+
+static int
+do_test (void)
+{
+ thrd_t ids[N];
+ unsigned char i;
+
+ if (cnd_init (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_init failed");
+ if (mtx_init (&mutex, mtx_plain) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ /* Create N new threads. */
+ for (i = 0; i < N; ++i)
+ {
+ if (thrd_create (&ids[i], child_wait, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+ }
+
+ /* Wait for other threads to reach their wait func. */
+ thrd_sleep (&((struct timespec){.tv_sec = 2}), NULL);
+
+ mtx_lock (&mutex);
+ if (cnd_broadcast (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_broadcast failed");
+ mtx_unlock (&mutex);
+
+ for (i = 0; i < N; ++i)
+ {
+ if (thrd_join (ids[i], NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+ }
+
+ mtx_destroy (&mutex);
+ cnd_destroy (&cond);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-cnd-timedwait.c b/nptl/tst-cnd-timedwait.c
new file mode 100644
index 0000000..64a9546
--- /dev/null
+++ b/nptl/tst-cnd-timedwait.c
@@ -0,0 +1,70 @@
+/* C11 threads condition timed wait variable tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Shared condition variable between child and parent. */
+static cnd_t cond;
+
+/* Mutex needed to signal and wait threads. */
+static mtx_t mutex;
+
+static int
+signal_parent (void *arg)
+{
+ if (cnd_signal (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_signal failed");
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+ struct timespec w_time;
+
+ if (cnd_init (&cond) != thrd_success)
+ FAIL_EXIT1 ("cnd_init failed");
+ if (mtx_init (&mutex, mtx_plain) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ if (clock_gettime (CLOCK_REALTIME, &w_time) != 0)
+ FAIL_EXIT1 ("clock_gettime failed");
+ w_time.tv_nsec += 150000;
+
+ if (thrd_create (&id, signal_parent, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ if (cnd_timedwait (&cond, &mutex, &w_time) != thrd_success)
+ FAIL_EXIT1 ("cnd_timedwait failed");
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+
+ mtx_destroy (&mutex);
+ cnd_destroy (&cond);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-mtx-basic.c b/nptl/tst-mtx-basic.c
new file mode 100644
index 0000000..c064405
--- /dev/null
+++ b/nptl/tst-mtx-basic.c
@@ -0,0 +1,73 @@
+/* C11 threads basic mutex tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Shared mutex between child and parent. */
+static mtx_t mutex;
+
+/* Shared counter to check possible race conditions. */
+static int counter;
+
+static int
+child_add (void *arg)
+{
+ if (mtx_lock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_lock failed");
+
+ counter++;
+
+ if (mtx_unlock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_unlock failed");
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ mtx_init (&mutex, mtx_plain);
+
+ thrd_t id;
+ if (thrd_create (&id, child_add, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ if (mtx_lock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_lock failed");
+
+ counter++;
+
+ if (mtx_unlock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_unlock failed");
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+
+ if (counter != 2)
+ FAIL_EXIT1 ("counter (%d) != 2", counter);
+
+ mtx_destroy (&mutex);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-mtx-recursive.c b/nptl/tst-mtx-recursive.c
new file mode 100644
index 0000000..df959c7
--- /dev/null
+++ b/nptl/tst-mtx-recursive.c
@@ -0,0 +1,45 @@
+/* C11 threads recursive mutex tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+static int
+do_test (void)
+{
+ static mtx_t mutex;
+
+ if (mtx_init (&mutex, mtx_recursive) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ if (mtx_lock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_lock failed");
+
+ /* Lock mutex second time, if not recursive should deadlock. */
+ if (mtx_lock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_lock failed");
+
+ mtx_destroy (&mutex);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-mtx-timedlock.c b/nptl/tst-mtx-timedlock.c
new file mode 100644
index 0000000..1f02bd4
--- /dev/null
+++ b/nptl/tst-mtx-timedlock.c
@@ -0,0 +1,98 @@
+/* C11 threads timed mutex tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Shared mutex between child and parent. */
+static mtx_t mutex;
+
+/* Shared counter to check possible race conditions. */
+static char shrd_counter;
+
+/* Maximum amount of time waiting for mutex. */
+static struct timespec wait_time;
+
+/* Function to choose an action to do, depending on mtx_timedlock
+ return value. */
+static inline void
+choose_action (int action, char* thread_name)
+{
+ switch (action)
+ {
+ case thrd_success:
+ ++shrd_counter;
+
+ if (mtx_unlock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_unlock failed");
+ break;
+
+ case thrd_timedout:
+ break;
+
+ case thrd_error:
+ FAIL_EXIT1 ("%s lock error", thread_name);
+ break;
+ }
+}
+
+static int
+child_add (void *arg)
+{
+ char child_name[] = "child";
+
+ /* Try to lock mutex. */
+ choose_action (mtx_timedlock (&mutex, &wait_time), child_name);
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+ char parent_name[] = "parent";
+
+ if (mtx_init (&mutex, mtx_timed) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ if (clock_gettime (CLOCK_REALTIME, &wait_time) != 0)
+ FAIL_EXIT1 ("clock_gettime failed");
+ /* Tiny amount of time, to assure that if any thread finds it busy.
+ It will receive thrd_timedout. */
+ wait_time.tv_nsec += 1;
+
+ if (thrd_create (&id, child_add, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ choose_action (mtx_timedlock (&mutex, &wait_time), parent_name);
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+
+ if (shrd_counter != 2 && shrd_counter != 1)
+ FAIL_EXIT1 ("shrd_counter != {1,2} (%d)", shrd_counter);
+
+ mtx_destroy (&mutex);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-mtx-trylock.c b/nptl/tst-mtx-trylock.c
new file mode 100644
index 0000000..5c1e804
--- /dev/null
+++ b/nptl/tst-mtx-trylock.c
@@ -0,0 +1,90 @@
+/* C11 threads trylock mutex tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Shared mutex between child and parent. */
+static mtx_t mutex;
+
+/* Shared counter to check possible race conditions. */
+static char shrd_counter;
+
+/* Function to choose an action to do, depending on mtx_trylock
+ return value. */
+static inline void
+choose_action (int action, char* thread_name)
+{
+ switch (action)
+ {
+ case thrd_success:
+ ++shrd_counter;
+
+ if (mtx_unlock (&mutex) != thrd_success)
+ FAIL_EXIT1 ("mtx_unlock failed");
+ break;
+
+ case thrd_busy:
+ break;
+
+ case thrd_error:
+ FAIL_EXIT1 ("%s lock error", thread_name);
+ break;
+ }
+}
+
+static int
+child_add (void *arg)
+{
+ char child_name[] = "child";
+
+ /* Try to lock mutex. */
+ choose_action (mtx_trylock (&mutex), child_name);
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+ char parent_name[] = "parent";
+
+ if (mtx_init (&mutex, mtx_timed) != thrd_success)
+ FAIL_EXIT1 ("mtx_init failed");
+
+ if (thrd_create (&id, child_add, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ choose_action (mtx_trylock (&mutex), parent_name);
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_join failed");
+
+ if (shrd_counter != 2 && shrd_counter != 1)
+ FAIL_EXIT1 ("shrd_counter != {1,2} (%d)", shrd_counter);
+
+ mtx_destroy (&mutex);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-thrd-detach.c b/nptl/tst-thrd-detach.c
new file mode 100644
index 0000000..ec28173
--- /dev/null
+++ b/nptl/tst-thrd-detach.c
@@ -0,0 +1,52 @@
+/* C11 threads thread detach tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <time.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+static int
+detach_thrd (void *arg)
+{
+ if (thrd_detach (thrd_current ()) != thrd_success)
+ FAIL_EXIT1 ("thrd_detach failed");
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+
+ /* Create new thread. */
+ if (thrd_create (&id, detach_thrd, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ /* Give some time so the thread can finish. */
+ thrd_sleep (&(struct timespec){.tv_sec = 2}, NULL);
+
+ if (thrd_join (id, NULL) == thrd_success)
+ FAIL_EXIT1 ("thrd_join succeed where it should fail");
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-thrd-sleep.c b/nptl/tst-thrd-sleep.c
new file mode 100644
index 0000000..17380b2
--- /dev/null
+++ b/nptl/tst-thrd-sleep.c
@@ -0,0 +1,51 @@
+/* C11 threads thread sleep tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <time.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+static int
+sleep_thrd (void *arg)
+{
+ struct timespec const *tl = (struct timespec const *) arg;
+ if (thrd_sleep (tl, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_sleep failed");
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ thrd_t id;
+ struct timespec wait_time = {.tv_sec = 3};
+
+ if (thrd_create (&id, sleep_thrd, (void *) (&wait_time)) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd failed");
+
+ return 0;
+}
+
+#include <support/test-driver.c>
diff --git a/nptl/tst-tss-basic.c b/nptl/tst-tss-basic.c
new file mode 100644
index 0000000..8181dc1
--- /dev/null
+++ b/nptl/tst-tss-basic.c
@@ -0,0 +1,75 @@
+/* C11 threads specific storage tests.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <threads.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include <support/check.h>
+
+/* Thread specific storage. */
+static tss_t key;
+
+#define TSS_VALUE (void*) 0xFF
+
+static int
+tss_thrd (void *arg)
+{
+ if (tss_create (&key, NULL) != thrd_success)
+ FAIL_EXIT1 ("tss_create failed");
+
+ if (tss_set (key, TSS_VALUE))
+ FAIL_EXIT1 ("tss_set failed");
+
+ void *value = tss_get (key);
+ if (value == 0)
+ FAIL_EXIT1 ("tss_get failed");
+ if (value != TSS_VALUE)
+ FAIL_EXIT1 ("tss_get returned %p, expected %p", value, TSS_VALUE);
+
+ thrd_exit (thrd_success);
+}
+
+static int
+do_test (void)
+{
+ /* Setting an invalid key should return an error. */
+ if (tss_set (key, TSS_VALUE) == thrd_success)
+ FAIL_EXIT1 ("tss_set succeed where it should have failed");
+
+ if (tss_create (&key, NULL) != thrd_success)
+ FAIL_EXIT1 ("tss_create failed");
+
+ thrd_t id;
+ if (thrd_create (&id, tss_thrd, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd_create failed");
+
+ if (thrd_join (id, NULL) != thrd_success)
+ FAIL_EXIT1 ("thrd failed");
+
+ /* The value set in tss_thrd should not be visible here. */
+ void *value = tss_get (key);
+ if (value != 0)
+ FAIL_EXIT1 ("tss_get succeed where it should have failed");
+
+ tss_delete (key);
+
+ return 0;
+}
+
+#include <support/test-driver.c>
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 2/8] nptl: Add C11 threads mtx_* functions Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 5/8] nptl: Add C11 threads tss_* functions Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-11-15 8:09 ` Florian Weimer
2017-09-22 20:27 ` [PATCH 7/8] nptl: Add test cases for ISO C11 threads Adhemerval Zanella
` (5 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the thrd_* definitions from C11 threads (ISO/IEC 9899:2011),
more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
Mostly of the definitions are composed based on POSIX conterparts, such as
thrd_t (using pthread_t). For thrd_* function internally direct
POSIX pthread call are used with the exceptions:
1. thrd_start uses pthread_create internal implementation, but changes
how to actually calls the start routine. This is due the difference
in signature between POSIX and C11, where former return a 'void *'
and latter 'int'.
To avoid calling convention issues due 'void *' to int cast, routines
from C11 threads are started slight different than default pthread one.
Explicit cast to expected return are used internally on pthread_create
and the result is stored back to void also with an explicit cast.
2. thrd_sleep uses nanosleep internal direct syscall to avoid clobbering
errno, to handle expected standard return codes, and to avoid making
the call a POSIX cancellation entrypoint.
3. thrd_yield also uses internal direct syscall to avoid errno clobbering.
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* conform/Makefile (conformtest-headers-ISO11): Add threads.h.
(linknamespace-libs-ISO11): Add libpthread.a.
* conform/data/threads.h-data: New file: add C11 thrd_* types and
functions.
* include/stdc-predef.h (__STDC_NO_THREADS__): Remove definition.
* nptl/Makefile (headers): Add threads.h.
(libpthread-routines): Add new C11 thread thrd_create, thrd_current,
thrd_detach, thrd_equal, thrd_exit, thrd_join, thrd_sleep, and
thrd_yield.
* nptl/Versions (libpthread) [GLIBC_2.27]): Add new C11 thread
thrd_create, thrd_current, thrd_detach, thrd_equal, thrd_exit,
thrd_join, thrd_sleep, and thrd_yield symbols.
* nptl/descr.h (struct pthread): Add c11 field.
* nptl/pthreadP.h (ATTR_C11_THREAD): New define.
* nptl/pthread_create.c (START_THREAD_DEFN): Call C11 thread start
routine with expected function prototype.
(__pthread_create_2_1): Add C11 threads check based on attribute
value.
* nptl/thrd_create.c: New file.
* nptl/thrd_current.c: Likewise.
* nptl/thrd_detach.c: Likewise.
* nptl/thrd_equal.c: Likewise.
* nptl/thrd_exit.c: Likewise.
* nptl/thrd_join.c: Likewise.
* nptl/thrd_priv.h: Likewise.
* nptl/thrd_sleep.c: Likewise.
* nptl/thrd_yield.c: Likewise.
* sysdeps/nptl/threads.h: Likewise.
---
ChangeLog | 31 ++++++++++++++++
conform/Makefile | 7 ++--
conform/data/threads.h-data | 23 ++++++++++++
include/stdc-predef.h | 3 --
nptl/Makefile | 6 ++-
nptl/Versions | 6 +++
nptl/descr.h | 2 +
nptl/pthreadP.h | 3 ++
nptl/pthread_create.c | 18 ++++++++-
nptl/thrd_create.c | 32 ++++++++++++++++
nptl/thrd_current.c | 26 +++++++++++++
nptl/thrd_detach.c | 30 +++++++++++++++
nptl/thrd_equal.c | 26 +++++++++++++
nptl/thrd_exit.c | 27 ++++++++++++++
nptl/thrd_join.c | 32 ++++++++++++++++
nptl/thrd_priv.h | 46 +++++++++++++++++++++++
nptl/thrd_sleep.c | 41 +++++++++++++++++++++
nptl/thrd_yield.c | 29 +++++++++++++++
sysdeps/nptl/threads.h | 90 +++++++++++++++++++++++++++++++++++++++++++++
19 files changed, 468 insertions(+), 10 deletions(-)
create mode 100644 conform/data/threads.h-data
create mode 100644 nptl/thrd_create.c
create mode 100644 nptl/thrd_current.c
create mode 100644 nptl/thrd_detach.c
create mode 100644 nptl/thrd_equal.c
create mode 100644 nptl/thrd_exit.c
create mode 100644 nptl/thrd_join.c
create mode 100644 nptl/thrd_priv.h
create mode 100644 nptl/thrd_sleep.c
create mode 100644 nptl/thrd_yield.c
create mode 100644 sysdeps/nptl/threads.h
diff --git a/conform/Makefile b/conform/Makefile
index 3883a4b..9e00d41 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -34,9 +34,9 @@ conformtest-headers-ISO := assert.h ctype.h errno.h float.h limits.h locale.h \
conformtest-headers-ISO99 := $(conformtest-headers-ISO) complex.h fenv.h \
inttypes.h iso646.h stdbool.h stdint.h tgmath.h \
wchar.h wctype.h
-# Missing ISO11 expectations for: stdatomic.h threads.h.
+# Missing ISO11 expectations for: stdatomic.h
conformtest-headers-ISO11 := $(conformtest-headers-ISO99) stdalign.h \
- stdnoreturn.h uchar.h
+ stdnoreturn.h threads.h uchar.h
conformtest-headers-POSIX := $(conformtest-headers-ISO) aio.h dirent.h \
fcntl.h fnmatch.h glob.h grp.h mqueue.h \
pthread.h pwd.h regex.h sched.h semaphore.h \
@@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \
$(common-objpfx)crypt/libcrypt.a
linknamespace-libs-ISO = $(linknamespace-libs-isoc)
linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
-linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
+linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
+ $(common-objpfx)nptl/libpthread.a
linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
$(common-objpfx)crypt/libcrypt.a
linknamespace-libs-XPG42 = $(linknamespace-libs-XPG4)
diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
new file mode 100644
index 0000000..bc2d857
--- /dev/null
+++ b/conform/data/threads.h-data
@@ -0,0 +1,23 @@
+#if defined ISO11
+
+constant thrd_success
+constant thrd_busy
+constant thrd_error
+constant thrd_nomem
+constant thrd_timedout
+
+type thrd_t
+type thrd_start_t
+
+function int thrd_create (thrd_t*, thrd_start_t, void*)
+function int thrd_equal (thrd_t, thrd_t)
+function thrd_t thrd_current (void)
+function int thrd_sleep (const struct timespec*, struct timespec*)
+function void thrd_exit (int)
+function int thrd_detach (thrd_t)
+function int thrd_join (thrd_t, int*)
+function void thrd_yield (void)
+
+#include "time.h-data"
+
+#endif
diff --git a/include/stdc-predef.h b/include/stdc-predef.h
index 74ade90..1cd3d73 100644
--- a/include/stdc-predef.h
+++ b/include/stdc-predef.h
@@ -57,7 +57,4 @@
- 3 additional Zanabazar Square characters */
#define __STDC_ISO_10646__ 201706L
-/* We do not support C11 <threads.h>. */
-#define __STDC_NO_THREADS__ 1
-
#endif
diff --git a/nptl/Makefile b/nptl/Makefile
index d819349..31761a6 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -22,7 +22,7 @@ subdir := nptl
include ../Makeconfig
-headers := pthread.h semaphore.h bits/semaphore.h
+headers := pthread.h semaphore.h bits/semaphore.h threads.h
extra-libs := libpthread
extra-libs-others := $(extra-libs)
@@ -138,7 +138,9 @@ libpthread-routines = nptl-init vars events version pt-interp \
pthread_mutex_getprioceiling \
pthread_mutex_setprioceiling \
pthread_setname pthread_getname \
- pthread_setattr_default_np pthread_getattr_default_np
+ pthread_setattr_default_np pthread_getattr_default_np \
+ thrd_create thrd_current thrd_detach thrd_equal \
+ thrd_exit thrd_join thrd_sleep thrd_yield
# pthread_setuid pthread_seteuid pthread_setreuid \
# pthread_setresuid \
# pthread_setgid pthread_setegid pthread_setregid \
diff --git a/nptl/Versions b/nptl/Versions
index 0ae5def..a282ceb 100644
--- a/nptl/Versions
+++ b/nptl/Versions
@@ -265,6 +265,12 @@ libpthread {
GLIBC_2.22 {
}
+ # C11 thread symbols.
+ GLIBC_2.27 {
+ thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join;
+ thrd_sleep; thrd_yield;
+ }
+
GLIBC_PRIVATE {
__pthread_initialize_minimal;
__pthread_clock_gettime; __pthread_clock_settime;
diff --git a/nptl/descr.h b/nptl/descr.h
index c5ad0c8..c1ff711 100644
--- a/nptl/descr.h
+++ b/nptl/descr.h
@@ -371,6 +371,8 @@ struct pthread
to the function. */
void *(*start_routine) (void *);
void *arg;
+ /* Indicates whether is a C11 thread created by thrd_creat. */
+ bool c11;
/* Debug state. */
td_eventbuf_t eventbuf;
diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h
index dbf46b0..ded7547 100644
--- a/nptl/pthreadP.h
+++ b/nptl/pthreadP.h
@@ -173,6 +173,9 @@ enum
#define __PTHREAD_ONCE_DONE 2
#define __PTHREAD_ONCE_FORK_GEN_INCR 4
+/* Attribute to indicate thread creation was issued from C11 thrd_create. */
+#define ATTR_C11_THREAD ((void*)(uintptr_t)-1)
+
/* Condition variable definitions. See __pthread_cond_wait_common.
Need to be defined here so there is one place from which
diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c
index 992331e..bef3042 100644
--- a/nptl/pthread_create.c
+++ b/nptl/pthread_create.c
@@ -460,7 +460,19 @@ START_THREAD_DEFN
LIBC_PROBE (pthread_start, 3, (pthread_t) pd, pd->start_routine, pd->arg);
/* Run the code the user provided. */
- THREAD_SETMEM (pd, result, pd->start_routine (pd->arg));
+ void *ret;
+ if (pd->c11)
+ {
+ /* The function pointer of the c11 thread start is cast to an incorrect
+ type on __pthread_create_2_1 call, however it is casted back to correct
+ one so the call behavior is well-defined (it is assumed that pointers
+ to void are able to represent all values of int. */
+ int (*start)(void*) = (int (*) (void*)) pd->start_routine;
+ ret = (void*) (intptr_t) start (pd->arg);
+ }
+ else
+ ret = pd->start_routine (pd->arg);
+ THREAD_SETMEM (pd, result, ret);
}
/* Call destructors for the thread_local TLS variables. */
@@ -613,7 +625,8 @@ __pthread_create_2_1 (pthread_t *newthread, const pthread_attr_t *attr,
const struct pthread_attr *iattr = (struct pthread_attr *) attr;
struct pthread_attr default_attr;
bool free_cpuset = false;
- if (iattr == NULL)
+ bool c11 = (attr == ATTR_C11_THREAD);
+ if (iattr == NULL || c11)
{
lll_lock (__default_pthread_attr_lock, LLL_PRIVATE);
default_attr = __default_pthread_attr;
@@ -671,6 +684,7 @@ __pthread_create_2_1 (pthread_t *newthread, const pthread_attr_t *attr,
get the information from its thread descriptor. */
pd->start_routine = start_routine;
pd->arg = arg;
+ pd->c11 = c11;
/* Copy the thread attribute flags. */
struct pthread *self = THREAD_SELF;
diff --git a/nptl/thrd_create.c b/nptl/thrd_create.c
new file mode 100644
index 0000000..0b6b822
--- /dev/null
+++ b/nptl/thrd_create.c
@@ -0,0 +1,32 @@
+/* C11 threads thread creation implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Create a new thread executing the function func. Arguments to func
+ are passed through arg. If succesful, thr is set to new thread
+ identifier. */
+int
+thrd_create (thrd_t *thr, thrd_start_t func, void *arg)
+{
+ _Static_assert (sizeof (thr) == sizeof (pthread_t), "thrd_t size");
+
+ int err_code = __pthread_create_2_1 (thr, ATTR_C11_THREAD,
+ (void* (*) (void*))func, arg);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/thrd_current.c b/nptl/thrd_current.c
new file mode 100644
index 0000000..7269d4b
--- /dev/null
+++ b/nptl/thrd_current.c
@@ -0,0 +1,26 @@
+/* C11 threads current thread implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Return current thread identifier. */
+thrd_t
+thrd_current (void)
+{
+ return __pthread_self ();
+}
diff --git a/nptl/thrd_detach.c b/nptl/thrd_detach.c
new file mode 100644
index 0000000..187d078
--- /dev/null
+++ b/nptl/thrd_detach.c
@@ -0,0 +1,30 @@
+/* C11 threads thread detach implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Detache the thread identified by thr from the current environment.
+ It does not allow join or wait for the thread. */
+int
+thrd_detach (thrd_t thr)
+{
+ int err_code;
+
+ err_code = __pthread_detach (thr);
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/thrd_equal.c b/nptl/thrd_equal.c
new file mode 100644
index 0000000..fcda488
--- /dev/null
+++ b/nptl/thrd_equal.c
@@ -0,0 +1,26 @@
+/* C11 threads thread equality check implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Check if lhs and rhs point to the same thread. */
+int
+thrd_equal (thrd_t lhs, thrd_t rhs)
+{
+ return __pthread_equal (lhs, rhs);
+}
diff --git a/nptl/thrd_exit.c b/nptl/thrd_exit.c
new file mode 100644
index 0000000..a49d8e0
--- /dev/null
+++ b/nptl/thrd_exit.c
@@ -0,0 +1,27 @@
+/* C11 threads thread exit implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Terminate current thread execution, cleaning up any thread local
+ storage and freeing resources. Returns the value specified in res. */
+_Noreturn void
+thrd_exit (int res)
+{
+ __pthread_exit ((void*)(uintptr_t) res);
+}
diff --git a/nptl/thrd_join.c b/nptl/thrd_join.c
new file mode 100644
index 0000000..1d69918
--- /dev/null
+++ b/nptl/thrd_join.c
@@ -0,0 +1,32 @@
+/* C11 threads thread join implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Block current thread until execution of thr is complete. In case that
+ res is not NULL, will store the return value of thr when exiting. */
+int
+thrd_join (thrd_t thr, int *res)
+{
+ void *pthread_res;
+ int err_code = __pthread_join (thr, &pthread_res);
+ if (res)
+ *res = (int)((uintptr_t) pthread_res);
+
+ return thrd_err_map (err_code);
+}
diff --git a/nptl/thrd_priv.h b/nptl/thrd_priv.h
new file mode 100644
index 0000000..a431d60
--- /dev/null
+++ b/nptl/thrd_priv.h
@@ -0,0 +1,46 @@
+/* Internal C11 threads definitions.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef THRD_PRIV_H
+# define THRD_PRIV_H
+
+#include <features.h>
+#include <threads.h>
+#include <errno.h>
+#include "pthreadP.h" /* For pthread_{mutex,cond}_t definitions. */
+
+/* Maps pthread error codes with thrd error codes. */
+static __always_inline int
+thrd_err_map (int err_code)
+{
+ switch (err_code)
+ {
+ case 0:
+ return thrd_success;
+ case ENOMEM:
+ return thrd_nomem;
+ case ETIMEDOUT:
+ return thrd_timedout;
+ case EBUSY:
+ return thrd_busy;
+ default:
+ return thrd_error;
+ }
+}
+
+#endif
diff --git a/nptl/thrd_sleep.c b/nptl/thrd_sleep.c
new file mode 100644
index 0000000..a49fdc4
--- /dev/null
+++ b/nptl/thrd_sleep.c
@@ -0,0 +1,41 @@
+/* C11 threads thread sleep implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+#include <time.h>
+
+/* Block current thread execution for at least the time pointed by time_point.
+ The current thread may resume if receives a signal. In that case, if
+ remaining is not NULL, the remaining time is stored in the object pointed
+ by it. */
+int
+thrd_sleep (const struct timespec* time_point, struct timespec* remaining)
+{
+ INTERNAL_SYSCALL_DECL (err);
+ int ret = INTERNAL_SYSCALL_CALL (nanosleep, err, time_point, remaining);
+ if (INTERNAL_SYSCALL_ERROR_P (ret, err))
+ {
+ /* C11 states thrd_sleep function returns -1 if it has been interrupted
+ by a signal, or a negative value if it fails. */
+ ret = INTERNAL_SYSCALL_ERRNO (ret, err);
+ if (ret == EINTR)
+ return -1;
+ return -2;
+ }
+ return 0;
+}
diff --git a/nptl/thrd_yield.c b/nptl/thrd_yield.c
new file mode 100644
index 0000000..13a02f3
--- /dev/null
+++ b/nptl/thrd_yield.c
@@ -0,0 +1,29 @@
+/* C11 threads thread yield implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include "thrd_priv.h"
+
+/* Stop current thread execution and call the scheduler to decide which
+ thread should execute next. The current thread may be selected by the
+ scheduler to keep running. */
+void
+thrd_yield (void)
+{
+ INTERNAL_SYSCALL_DECL (err);
+ INTERNAL_SYSCALL_CALL (sched_yield, err);
+}
diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h
new file mode 100644
index 0000000..4b89a30
--- /dev/null
+++ b/sysdeps/nptl/threads.h
@@ -0,0 +1,90 @@
+/* ISO C11 Standard: 7.26 - Thread support library <threads.h>.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _THREADS_H
+#define _THREADS_H 1
+
+#include <features.h>
+#include <time.h>
+
+__BEGIN_DECLS
+
+#include <bits/types/struct_timespec.h>
+
+typedef unsigned long int thrd_t;
+typedef int (*thrd_start_t) (void*);
+
+/* Exit and error codes. */
+enum
+{
+ thrd_success = 0,
+ thrd_busy = 1,
+ thrd_error = 2,
+ thrd_nomem = 3,
+ thrd_timedout = 4
+};
+
+/* Threads functions. */
+
+/* Create a new thread executing the function __func. Arguments to __func
+ are passed through __arg. If succesful, __thr is set to new thread
+ identifier. */
+extern int thrd_create (thrd_t *__thr, thrd_start_t __func, void *__arg);
+
+/* Check if __lhs and __rhs point to the same thread. */
+extern int thrd_equal (thrd_t __lhs, thrd_t __rhs);
+
+/* Return current thread identifier. */
+extern thrd_t thrd_current (void);
+
+/* Block current thread execution for at least the time pointed by
+ __time_point. The current thread may resume if receives a signal. In
+ that case, if __remaining is not NULL, the remaining time is stored in
+ the object pointed by it. */
+extern int thrd_sleep (const struct timespec *__time_point,
+ struct timespec *__remaining);
+
+/* Terminate current thread execution, cleaning up any thread local
+ storage and freeing resources. Returns the value specified in __res. */
+extern void thrd_exit (int __res) __attribute__ ((__noreturn__));
+
+/* Detache the thread identified by __thr from the current environment.
+ It does not allow join or wait for __thr. */
+extern int thrd_detach (thrd_t __thr);
+
+/* Block current thread until execution of __thr is complete. In case that
+ __res is not NULL, will store the return value of __thr when exiting. */
+extern int thrd_join (thrd_t __thr, int *__res);
+
+/* Stop current thread execution and call the scheduler to decide which
+ thread should execute next. The current thread may be selected by the
+ scheduler to keep running. */
+extern void thrd_yield (void);
+
+#ifdef __USE_EXTERN_INLINES
+/* Optimizations. */
+__extern_inline int
+thrd_equal (thrd_t __thread1, thrd_t __thread2)
+{
+ return __thread1 == __thread2;
+}
+#endif
+
+__END_DECLS
+
+#endif /* _THREADS_H */
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/8] nptl: Add C11 threads call_once functions
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (3 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 7/8] nptl: Add test cases for ISO C11 threads Adhemerval Zanella
@ 2017-09-22 20:27 ` Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 8/8] Add manual documentation for threads.h Adhemerval Zanella
` (3 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-09-22 20:27 UTC (permalink / raw)
To: libc-alpha
This patch adds the call_* definitions from C11 threads (ISO/IEC 9899:2011),
more specifically call_once and required types.
Mostly of the definitions are composed based on POSIX conterparts,including
once_flag (pthread_once_t). The idea is to make possible to share POSIX
internal implementations for mostly of the code (and making adjustment only
when required).
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu,
arm-linux-gnueabhf, and powerpc64le-linux-gnu.
* conform/data/threads.h-data (ONCE_FLAG_INIT): New macro.
(once_flag): New type.
(call_once): New function.
* nptl/Makefile (libpthread-routines): Add call_once object.
* nptl/Versions (libphread) [GLIBC_2.27]: Add call_once symbol.
* nptl/call_once.c: New file.
* sysdeps/nptl/threads.h (ONCE_FLAG_INIT): New define.
(once_flag): New type.
(call_once): New prototype.
---
ChangeLog | 10 ++++++++++
conform/data/threads.h-data | 5 +++++
nptl/Makefile | 2 +-
nptl/Versions | 2 +-
nptl/call_once.c | 33 +++++++++++++++++++++++++++++++++
sysdeps/nptl/threads.h | 7 +++++++
6 files changed, 57 insertions(+), 2 deletions(-)
create mode 100644 nptl/call_once.c
diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data
index bb5ca75..70b2fe0 100644
--- a/conform/data/threads.h-data
+++ b/conform/data/threads.h-data
@@ -1,5 +1,7 @@
#if defined ISO11
+macro ONCE_FLAG_INIT
+
constant thrd_success
constant thrd_busy
constant thrd_error
@@ -13,6 +15,7 @@ constant mtx_timed
type thrd_t
type thrd_start_t
type mtx_t
+type once_flag
function int thrd_create (thrd_t*, thrd_start_t, void*)
function int thrd_equal (thrd_t, thrd_t)
@@ -30,6 +33,8 @@ function int mtx_trylock (mtx_t*)
function int mtx_unlock (mtx_t*)
function void mtx_destroy (mtx_t*)
+function void call_once (once_flag*, void (*)(void))
+
#include "time.h-data"
#endif
diff --git a/nptl/Makefile b/nptl/Makefile
index c4f6970..7d2b83f 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -142,7 +142,7 @@ libpthread-routines = nptl-init vars events version pt-interp \
thrd_create thrd_current thrd_detach thrd_equal \
thrd_exit thrd_join thrd_sleep thrd_yield \
mtx_destroy mtx_init mtx_lock mtx_timedlock \
- mtx_trylock mtx_unlock
+ mtx_trylock mtx_unlock call_once
# pthread_setuid pthread_seteuid pthread_setreuid \
# pthread_setresuid \
# pthread_setgid pthread_setegid pthread_setregid \
diff --git a/nptl/Versions b/nptl/Versions
index 5cf581a..b055860 100644
--- a/nptl/Versions
+++ b/nptl/Versions
@@ -269,7 +269,7 @@ libpthread {
GLIBC_2.27 {
thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join;
thrd_sleep; thrd_yield; mtx_init; mtx_lock; mtx_timedlock; mtx_trylock;
- mtx_unlock; mtx_destroy;
+ mtx_unlock; mtx_destroy; call_once;
}
GLIBC_PRIVATE {
diff --git a/nptl/call_once.c b/nptl/call_once.c
new file mode 100644
index 0000000..8a15f1f
--- /dev/null
+++ b/nptl/call_once.c
@@ -0,0 +1,33 @@
+/* C11 threads call once implementation.
+ Copyright (C) 2017 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <stdalign.h>
+
+#include "thrd_priv.h"
+
+/* Call function func exactly once, even if invoked from several threads.
+ All calls must be made with the same flag object. */
+void
+call_once (once_flag *flag, void (*func)(void))
+{
+ _Static_assert (sizeof (once_flag) == sizeof (pthread_once_t),
+ "once_flag size");
+ _Static_assert (alignof (once_flag) == alignof (pthread_once_t),
+ "once_flag alignment");
+ __pthread_once (flag, func);
+}
diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h
index cd811f4..53fe731 100644
--- a/sysdeps/nptl/threads.h
+++ b/sysdeps/nptl/threads.h
@@ -27,8 +27,11 @@ __BEGIN_DECLS
#include <bits/pthreadtypes-arch.h>
#include <bits/types/struct_timespec.h>
+#define ONCE_FLAG_INIT 0
+
typedef unsigned long int thrd_t;
typedef int (*thrd_start_t) (void*);
+typedef int __ONCE_ALIGNMENT once_flag;
/* Exit and error codes. */
enum
@@ -129,6 +132,10 @@ extern int mtx_unlock (mtx_t *__mutex);
/* Destroy the mutex object pointed by __mutex. */
extern void mtx_destroy (mtx_t *__mutex);
+/* Call function func exactly once, even if invoked from several threads.
+ All calls must be made with the same __flag object. */
+extern void call_once (once_flag *__flag, void (*__func)(void));
+
__END_DECLS
#endif /* _THREADS_H */
--
2.7.4
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v7 0/8] Add support for ISO C threads.h
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
` (7 preceding siblings ...)
2017-09-22 20:27 ` [PATCH 4/8] nptl: Add C11 threads cnd_* functions Adhemerval Zanella
@ 2017-10-03 19:07 ` Adhemerval Zanella
2017-10-10 18:48 ` Adhemerval Zanella
8 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-10-03 19:07 UTC (permalink / raw)
To: libc-alpha
Ping.
On 22/09/2017 17:26, Adhemerval Zanella wrote:
> This is a new update for C11 threads support based on my previous [1]
> version. The main changes from previous version are:
>
> - From discussion in last Cauldron, mtx_t and cnd_t are no longer
> based on internal pthread types (__pthread_{mutex,cond}_s. It is
> mainly to avoid the user to direct access the types internal
> fields in a way not expected by API.
>
> - Add static asserts for size and alignment for all required types
> as an additional consistency check.
>
> - Fix some ChangeLog references for 2.27 version.
>
> I tested this without regression with a full make/check on
> x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
> powerpc-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf,
> sparc64-linux-gnu, and sparcv9-linux-gnu.
>
> [1] https://sourceware.org/ml/libc-alpha/2017-06/msg01413.html
>
> Adhemerval Zanella (7):
> nptl: Add C11 threads thrd_* functions
> nptl: Add C11 threads mtx_* functions
> nptl: Add C11 threads call_once functions
> nptl: Add C11 threads cnd_* functions
> nptl: Add C11 threads tss_* functions
> nptl: Add abilist symbols for C11 threads
> nptl: Add test cases for ISO C11 threads
>
> Juan Manuel Torres Palma (1):
> Add manual documentation for threads.h
>
> ChangeLog | 174 ++++++++++
> conform/Makefile | 7 +-
> conform/data/threads.h-data | 57 ++++
> include/stdc-predef.h | 3 -
> manual/Makefile | 2 +-
> manual/isothreads.texi | 355 +++++++++++++++++++++
> nptl/Makefile | 15 +-
> nptl/Versions | 9 +
> nptl/call_once.c | 33 ++
> nptl/cnd_broadcast.c | 28 ++
> nptl/cnd_destroy.c | 28 ++
> nptl/cnd_init.c | 33 ++
> nptl/cnd_signal.c | 28 ++
> nptl/cnd_timedwait.c | 31 ++
> nptl/cnd_wait.c | 28 ++
> nptl/descr.h | 2 +
> nptl/mtx_destroy.c | 27 ++
> nptl/mtx_init.c | 54 ++++
> nptl/mtx_lock.c | 28 ++
> nptl/mtx_timedlock.c | 31 ++
> nptl/mtx_trylock.c | 29 ++
> nptl/mtx_unlock.c | 28 ++
> nptl/pthreadP.h | 3 +
> nptl/pthread_create.c | 18 +-
> nptl/thrd_create.c | 32 ++
> nptl/thrd_current.c | 26 ++
> nptl/thrd_detach.c | 30 ++
> nptl/thrd_equal.c | 26 ++
> nptl/thrd_exit.c | 27 ++
> nptl/thrd_join.c | 32 ++
> nptl/thrd_priv.h | 46 +++
> nptl/thrd_sleep.c | 41 +++
> nptl/thrd_yield.c | 29 ++
> nptl/tss_create.c | 31 ++
> nptl/tss_delete.c | 27 ++
> nptl/tss_get.c | 27 ++
> nptl/tss_set.c | 28 ++
> nptl/tst-call-once.c | 66 ++++
> nptl/tst-cnd-basic.c | 68 ++++
> nptl/tst-cnd-broadcast.c | 83 +++++
> nptl/tst-cnd-timedwait.c | 70 ++++
> nptl/tst-mtx-basic.c | 73 +++++
> nptl/tst-mtx-recursive.c | 45 +++
> nptl/tst-mtx-timedlock.c | 98 ++++++
> nptl/tst-mtx-trylock.c | 90 ++++++
> nptl/tst-thrd-detach.c | 52 +++
> nptl/tst-thrd-sleep.c | 51 +++
> nptl/tst-tss-basic.c | 75 +++++
> sysdeps/nptl/threads.h | 198 ++++++++++++
> sysdeps/unix/sysv/linux/aarch64/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/alpha/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/arm/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/hppa/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/i386/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/ia64/libpthread.abilist | 26 ++
> .../sysv/linux/m68k/coldfire/libpthread.abilist | 26 ++
> .../unix/sysv/linux/m68k/m680x0/libpthread.abilist | 26 ++
> .../unix/sysv/linux/microblaze/libpthread.abilist | 26 ++
> .../unix/sysv/linux/mips/mips32/libpthread.abilist | 26 ++
> .../unix/sysv/linux/mips/mips64/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/nios2/libpthread.abilist | 26 ++
> .../linux/powerpc/powerpc32/libpthread.abilist | 26 ++
> .../linux/powerpc/powerpc64/libpthread-le.abilist | 26 ++
> .../linux/powerpc/powerpc64/libpthread.abilist | 26 ++
> .../sysv/linux/s390/s390-32/libpthread.abilist | 26 ++
> .../sysv/linux/s390/s390-64/libpthread.abilist | 26 ++
> sysdeps/unix/sysv/linux/sh/libpthread.abilist | 26 ++
> .../sysv/linux/sparc/sparc32/libpthread.abilist | 26 ++
> .../sysv/linux/sparc/sparc64/libpthread.abilist | 26 ++
> .../linux/tile/tilegx/tilegx32/libpthread.abilist | 26 ++
> .../linux/tile/tilegx/tilegx64/libpthread.abilist | 26 ++
> .../sysv/linux/tile/tilepro/libpthread.abilist | 26 ++
> .../unix/sysv/linux/x86_64/64/libpthread.abilist | 26 ++
> .../unix/sysv/linux/x86_64/x32/libpthread.abilist | 26 ++
> 74 files changed, 3060 insertions(+), 12 deletions(-)
> create mode 100644 conform/data/threads.h-data
> create mode 100644 manual/isothreads.texi
> create mode 100644 nptl/call_once.c
> create mode 100644 nptl/cnd_broadcast.c
> create mode 100644 nptl/cnd_destroy.c
> create mode 100644 nptl/cnd_init.c
> create mode 100644 nptl/cnd_signal.c
> create mode 100644 nptl/cnd_timedwait.c
> create mode 100644 nptl/cnd_wait.c
> create mode 100644 nptl/mtx_destroy.c
> create mode 100644 nptl/mtx_init.c
> create mode 100644 nptl/mtx_lock.c
> create mode 100644 nptl/mtx_timedlock.c
> create mode 100644 nptl/mtx_trylock.c
> create mode 100644 nptl/mtx_unlock.c
> create mode 100644 nptl/thrd_create.c
> create mode 100644 nptl/thrd_current.c
> create mode 100644 nptl/thrd_detach.c
> create mode 100644 nptl/thrd_equal.c
> create mode 100644 nptl/thrd_exit.c
> create mode 100644 nptl/thrd_join.c
> create mode 100644 nptl/thrd_priv.h
> create mode 100644 nptl/thrd_sleep.c
> create mode 100644 nptl/thrd_yield.c
> create mode 100644 nptl/tss_create.c
> create mode 100644 nptl/tss_delete.c
> create mode 100644 nptl/tss_get.c
> create mode 100644 nptl/tss_set.c
> create mode 100644 nptl/tst-call-once.c
> create mode 100644 nptl/tst-cnd-basic.c
> create mode 100644 nptl/tst-cnd-broadcast.c
> create mode 100644 nptl/tst-cnd-timedwait.c
> create mode 100644 nptl/tst-mtx-basic.c
> create mode 100644 nptl/tst-mtx-recursive.c
> create mode 100644 nptl/tst-mtx-timedlock.c
> create mode 100644 nptl/tst-mtx-trylock.c
> create mode 100644 nptl/tst-thrd-detach.c
> create mode 100644 nptl/tst-thrd-sleep.c
> create mode 100644 nptl/tst-tss-basic.c
> create mode 100644 sysdeps/nptl/threads.h
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v7 0/8] Add support for ISO C threads.h
2017-10-03 19:07 ` [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
@ 2017-10-10 18:48 ` Adhemerval Zanella
2017-10-26 12:19 ` Adhemerval Zanella
0 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-10-10 18:48 UTC (permalink / raw)
To: libc-alpha
Ping (x2).
On 03/10/2017 16:07, Adhemerval Zanella wrote:
> Ping.
>
> On 22/09/2017 17:26, Adhemerval Zanella wrote:
>> This is a new update for C11 threads support based on my previous [1]
>> version. The main changes from previous version are:
>>
>> - From discussion in last Cauldron, mtx_t and cnd_t are no longer
>> based on internal pthread types (__pthread_{mutex,cond}_s. It is
>> mainly to avoid the user to direct access the types internal
>> fields in a way not expected by API.
>>
>> - Add static asserts for size and alignment for all required types
>> as an additional consistency check.
>>
>> - Fix some ChangeLog references for 2.27 version.
>>
>> I tested this without regression with a full make/check on
>> x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
>> powerpc-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf,
>> sparc64-linux-gnu, and sparcv9-linux-gnu.
>>
>> [1] https://sourceware.org/ml/libc-alpha/2017-06/msg01413.html
>>
>> Adhemerval Zanella (7):
>> nptl: Add C11 threads thrd_* functions
>> nptl: Add C11 threads mtx_* functions
>> nptl: Add C11 threads call_once functions
>> nptl: Add C11 threads cnd_* functions
>> nptl: Add C11 threads tss_* functions
>> nptl: Add abilist symbols for C11 threads
>> nptl: Add test cases for ISO C11 threads
>>
>> Juan Manuel Torres Palma (1):
>> Add manual documentation for threads.h
>>
>> ChangeLog | 174 ++++++++++
>> conform/Makefile | 7 +-
>> conform/data/threads.h-data | 57 ++++
>> include/stdc-predef.h | 3 -
>> manual/Makefile | 2 +-
>> manual/isothreads.texi | 355 +++++++++++++++++++++
>> nptl/Makefile | 15 +-
>> nptl/Versions | 9 +
>> nptl/call_once.c | 33 ++
>> nptl/cnd_broadcast.c | 28 ++
>> nptl/cnd_destroy.c | 28 ++
>> nptl/cnd_init.c | 33 ++
>> nptl/cnd_signal.c | 28 ++
>> nptl/cnd_timedwait.c | 31 ++
>> nptl/cnd_wait.c | 28 ++
>> nptl/descr.h | 2 +
>> nptl/mtx_destroy.c | 27 ++
>> nptl/mtx_init.c | 54 ++++
>> nptl/mtx_lock.c | 28 ++
>> nptl/mtx_timedlock.c | 31 ++
>> nptl/mtx_trylock.c | 29 ++
>> nptl/mtx_unlock.c | 28 ++
>> nptl/pthreadP.h | 3 +
>> nptl/pthread_create.c | 18 +-
>> nptl/thrd_create.c | 32 ++
>> nptl/thrd_current.c | 26 ++
>> nptl/thrd_detach.c | 30 ++
>> nptl/thrd_equal.c | 26 ++
>> nptl/thrd_exit.c | 27 ++
>> nptl/thrd_join.c | 32 ++
>> nptl/thrd_priv.h | 46 +++
>> nptl/thrd_sleep.c | 41 +++
>> nptl/thrd_yield.c | 29 ++
>> nptl/tss_create.c | 31 ++
>> nptl/tss_delete.c | 27 ++
>> nptl/tss_get.c | 27 ++
>> nptl/tss_set.c | 28 ++
>> nptl/tst-call-once.c | 66 ++++
>> nptl/tst-cnd-basic.c | 68 ++++
>> nptl/tst-cnd-broadcast.c | 83 +++++
>> nptl/tst-cnd-timedwait.c | 70 ++++
>> nptl/tst-mtx-basic.c | 73 +++++
>> nptl/tst-mtx-recursive.c | 45 +++
>> nptl/tst-mtx-timedlock.c | 98 ++++++
>> nptl/tst-mtx-trylock.c | 90 ++++++
>> nptl/tst-thrd-detach.c | 52 +++
>> nptl/tst-thrd-sleep.c | 51 +++
>> nptl/tst-tss-basic.c | 75 +++++
>> sysdeps/nptl/threads.h | 198 ++++++++++++
>> sysdeps/unix/sysv/linux/aarch64/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/alpha/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/arm/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/hppa/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/i386/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/ia64/libpthread.abilist | 26 ++
>> .../sysv/linux/m68k/coldfire/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/m68k/m680x0/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/microblaze/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/mips/mips32/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/mips/mips64/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/nios2/libpthread.abilist | 26 ++
>> .../linux/powerpc/powerpc32/libpthread.abilist | 26 ++
>> .../linux/powerpc/powerpc64/libpthread-le.abilist | 26 ++
>> .../linux/powerpc/powerpc64/libpthread.abilist | 26 ++
>> .../sysv/linux/s390/s390-32/libpthread.abilist | 26 ++
>> .../sysv/linux/s390/s390-64/libpthread.abilist | 26 ++
>> sysdeps/unix/sysv/linux/sh/libpthread.abilist | 26 ++
>> .../sysv/linux/sparc/sparc32/libpthread.abilist | 26 ++
>> .../sysv/linux/sparc/sparc64/libpthread.abilist | 26 ++
>> .../linux/tile/tilegx/tilegx32/libpthread.abilist | 26 ++
>> .../linux/tile/tilegx/tilegx64/libpthread.abilist | 26 ++
>> .../sysv/linux/tile/tilepro/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/x86_64/64/libpthread.abilist | 26 ++
>> .../unix/sysv/linux/x86_64/x32/libpthread.abilist | 26 ++
>> 74 files changed, 3060 insertions(+), 12 deletions(-)
>> create mode 100644 conform/data/threads.h-data
>> create mode 100644 manual/isothreads.texi
>> create mode 100644 nptl/call_once.c
>> create mode 100644 nptl/cnd_broadcast.c
>> create mode 100644 nptl/cnd_destroy.c
>> create mode 100644 nptl/cnd_init.c
>> create mode 100644 nptl/cnd_signal.c
>> create mode 100644 nptl/cnd_timedwait.c
>> create mode 100644 nptl/cnd_wait.c
>> create mode 100644 nptl/mtx_destroy.c
>> create mode 100644 nptl/mtx_init.c
>> create mode 100644 nptl/mtx_lock.c
>> create mode 100644 nptl/mtx_timedlock.c
>> create mode 100644 nptl/mtx_trylock.c
>> create mode 100644 nptl/mtx_unlock.c
>> create mode 100644 nptl/thrd_create.c
>> create mode 100644 nptl/thrd_current.c
>> create mode 100644 nptl/thrd_detach.c
>> create mode 100644 nptl/thrd_equal.c
>> create mode 100644 nptl/thrd_exit.c
>> create mode 100644 nptl/thrd_join.c
>> create mode 100644 nptl/thrd_priv.h
>> create mode 100644 nptl/thrd_sleep.c
>> create mode 100644 nptl/thrd_yield.c
>> create mode 100644 nptl/tss_create.c
>> create mode 100644 nptl/tss_delete.c
>> create mode 100644 nptl/tss_get.c
>> create mode 100644 nptl/tss_set.c
>> create mode 100644 nptl/tst-call-once.c
>> create mode 100644 nptl/tst-cnd-basic.c
>> create mode 100644 nptl/tst-cnd-broadcast.c
>> create mode 100644 nptl/tst-cnd-timedwait.c
>> create mode 100644 nptl/tst-mtx-basic.c
>> create mode 100644 nptl/tst-mtx-recursive.c
>> create mode 100644 nptl/tst-mtx-timedlock.c
>> create mode 100644 nptl/tst-mtx-trylock.c
>> create mode 100644 nptl/tst-thrd-detach.c
>> create mode 100644 nptl/tst-thrd-sleep.c
>> create mode 100644 nptl/tst-tss-basic.c
>> create mode 100644 sysdeps/nptl/threads.h
>>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v7 0/8] Add support for ISO C threads.h
2017-10-10 18:48 ` Adhemerval Zanella
@ 2017-10-26 12:19 ` Adhemerval Zanella
0 siblings, 0 replies; 21+ messages in thread
From: Adhemerval Zanella @ 2017-10-26 12:19 UTC (permalink / raw)
To: libc-alpha
Ping (x3).
On 10/10/2017 15:48, Adhemerval Zanella wrote:
> Ping (x2).
>
> On 03/10/2017 16:07, Adhemerval Zanella wrote:
>> Ping.
>>
>> On 22/09/2017 17:26, Adhemerval Zanella wrote:
>>> This is a new update for C11 threads support based on my previous [1]
>>> version. The main changes from previous version are:
>>>
>>> - From discussion in last Cauldron, mtx_t and cnd_t are no longer
>>> based on internal pthread types (__pthread_{mutex,cond}_s. It is
>>> mainly to avoid the user to direct access the types internal
>>> fields in a way not expected by API.
>>>
>>> - Add static asserts for size and alignment for all required types
>>> as an additional consistency check.
>>>
>>> - Fix some ChangeLog references for 2.27 version.
>>>
>>> I tested this without regression with a full make/check on
>>> x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
>>> powerpc-linux-gnu, aarch64-linux-gnu, arm-linux-gnueabihf,
>>> sparc64-linux-gnu, and sparcv9-linux-gnu.
>>>
>>> [1] https://sourceware.org/ml/libc-alpha/2017-06/msg01413.html
>>>
>>> Adhemerval Zanella (7):
>>> nptl: Add C11 threads thrd_* functions
>>> nptl: Add C11 threads mtx_* functions
>>> nptl: Add C11 threads call_once functions
>>> nptl: Add C11 threads cnd_* functions
>>> nptl: Add C11 threads tss_* functions
>>> nptl: Add abilist symbols for C11 threads
>>> nptl: Add test cases for ISO C11 threads
>>>
>>> Juan Manuel Torres Palma (1):
>>> Add manual documentation for threads.h
>>>
>>> ChangeLog | 174 ++++++++++
>>> conform/Makefile | 7 +-
>>> conform/data/threads.h-data | 57 ++++
>>> include/stdc-predef.h | 3 -
>>> manual/Makefile | 2 +-
>>> manual/isothreads.texi | 355 +++++++++++++++++++++
>>> nptl/Makefile | 15 +-
>>> nptl/Versions | 9 +
>>> nptl/call_once.c | 33 ++
>>> nptl/cnd_broadcast.c | 28 ++
>>> nptl/cnd_destroy.c | 28 ++
>>> nptl/cnd_init.c | 33 ++
>>> nptl/cnd_signal.c | 28 ++
>>> nptl/cnd_timedwait.c | 31 ++
>>> nptl/cnd_wait.c | 28 ++
>>> nptl/descr.h | 2 +
>>> nptl/mtx_destroy.c | 27 ++
>>> nptl/mtx_init.c | 54 ++++
>>> nptl/mtx_lock.c | 28 ++
>>> nptl/mtx_timedlock.c | 31 ++
>>> nptl/mtx_trylock.c | 29 ++
>>> nptl/mtx_unlock.c | 28 ++
>>> nptl/pthreadP.h | 3 +
>>> nptl/pthread_create.c | 18 +-
>>> nptl/thrd_create.c | 32 ++
>>> nptl/thrd_current.c | 26 ++
>>> nptl/thrd_detach.c | 30 ++
>>> nptl/thrd_equal.c | 26 ++
>>> nptl/thrd_exit.c | 27 ++
>>> nptl/thrd_join.c | 32 ++
>>> nptl/thrd_priv.h | 46 +++
>>> nptl/thrd_sleep.c | 41 +++
>>> nptl/thrd_yield.c | 29 ++
>>> nptl/tss_create.c | 31 ++
>>> nptl/tss_delete.c | 27 ++
>>> nptl/tss_get.c | 27 ++
>>> nptl/tss_set.c | 28 ++
>>> nptl/tst-call-once.c | 66 ++++
>>> nptl/tst-cnd-basic.c | 68 ++++
>>> nptl/tst-cnd-broadcast.c | 83 +++++
>>> nptl/tst-cnd-timedwait.c | 70 ++++
>>> nptl/tst-mtx-basic.c | 73 +++++
>>> nptl/tst-mtx-recursive.c | 45 +++
>>> nptl/tst-mtx-timedlock.c | 98 ++++++
>>> nptl/tst-mtx-trylock.c | 90 ++++++
>>> nptl/tst-thrd-detach.c | 52 +++
>>> nptl/tst-thrd-sleep.c | 51 +++
>>> nptl/tst-tss-basic.c | 75 +++++
>>> sysdeps/nptl/threads.h | 198 ++++++++++++
>>> sysdeps/unix/sysv/linux/aarch64/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/alpha/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/arm/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/hppa/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/i386/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/ia64/libpthread.abilist | 26 ++
>>> .../sysv/linux/m68k/coldfire/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/m68k/m680x0/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/microblaze/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/mips/mips32/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/mips/mips64/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/nios2/libpthread.abilist | 26 ++
>>> .../linux/powerpc/powerpc32/libpthread.abilist | 26 ++
>>> .../linux/powerpc/powerpc64/libpthread-le.abilist | 26 ++
>>> .../linux/powerpc/powerpc64/libpthread.abilist | 26 ++
>>> .../sysv/linux/s390/s390-32/libpthread.abilist | 26 ++
>>> .../sysv/linux/s390/s390-64/libpthread.abilist | 26 ++
>>> sysdeps/unix/sysv/linux/sh/libpthread.abilist | 26 ++
>>> .../sysv/linux/sparc/sparc32/libpthread.abilist | 26 ++
>>> .../sysv/linux/sparc/sparc64/libpthread.abilist | 26 ++
>>> .../linux/tile/tilegx/tilegx32/libpthread.abilist | 26 ++
>>> .../linux/tile/tilegx/tilegx64/libpthread.abilist | 26 ++
>>> .../sysv/linux/tile/tilepro/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/x86_64/64/libpthread.abilist | 26 ++
>>> .../unix/sysv/linux/x86_64/x32/libpthread.abilist | 26 ++
>>> 74 files changed, 3060 insertions(+), 12 deletions(-)
>>> create mode 100644 conform/data/threads.h-data
>>> create mode 100644 manual/isothreads.texi
>>> create mode 100644 nptl/call_once.c
>>> create mode 100644 nptl/cnd_broadcast.c
>>> create mode 100644 nptl/cnd_destroy.c
>>> create mode 100644 nptl/cnd_init.c
>>> create mode 100644 nptl/cnd_signal.c
>>> create mode 100644 nptl/cnd_timedwait.c
>>> create mode 100644 nptl/cnd_wait.c
>>> create mode 100644 nptl/mtx_destroy.c
>>> create mode 100644 nptl/mtx_init.c
>>> create mode 100644 nptl/mtx_lock.c
>>> create mode 100644 nptl/mtx_timedlock.c
>>> create mode 100644 nptl/mtx_trylock.c
>>> create mode 100644 nptl/mtx_unlock.c
>>> create mode 100644 nptl/thrd_create.c
>>> create mode 100644 nptl/thrd_current.c
>>> create mode 100644 nptl/thrd_detach.c
>>> create mode 100644 nptl/thrd_equal.c
>>> create mode 100644 nptl/thrd_exit.c
>>> create mode 100644 nptl/thrd_join.c
>>> create mode 100644 nptl/thrd_priv.h
>>> create mode 100644 nptl/thrd_sleep.c
>>> create mode 100644 nptl/thrd_yield.c
>>> create mode 100644 nptl/tss_create.c
>>> create mode 100644 nptl/tss_delete.c
>>> create mode 100644 nptl/tss_get.c
>>> create mode 100644 nptl/tss_set.c
>>> create mode 100644 nptl/tst-call-once.c
>>> create mode 100644 nptl/tst-cnd-basic.c
>>> create mode 100644 nptl/tst-cnd-broadcast.c
>>> create mode 100644 nptl/tst-cnd-timedwait.c
>>> create mode 100644 nptl/tst-mtx-basic.c
>>> create mode 100644 nptl/tst-mtx-recursive.c
>>> create mode 100644 nptl/tst-mtx-timedlock.c
>>> create mode 100644 nptl/tst-mtx-trylock.c
>>> create mode 100644 nptl/tst-thrd-detach.c
>>> create mode 100644 nptl/tst-thrd-sleep.c
>>> create mode 100644 nptl/tst-tss-basic.c
>>> create mode 100644 sysdeps/nptl/threads.h
>>>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-09-22 20:27 ` [PATCH 1/8] nptl: Add C11 threads thrd_* functions Adhemerval Zanella
@ 2017-11-15 8:09 ` Florian Weimer
2017-11-15 11:22 ` Adhemerval Zanella
0 siblings, 1 reply; 21+ messages in thread
From: Florian Weimer @ 2017-11-15 8:09 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
> This patch adds the thrd_* definitions from C11 threads (ISO/IEC 9899:2011),
> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>
> Mostly of the definitions are composed based on POSIX conterparts, such as
> thrd_t (using pthread_t).
I have skimmed the C11 discussion of these types, and C11 says that
mtx_t et al. are “identifiersâ€. To me, this suggests they are handles,
just like pthread_t in the POSIX threads implementation.
I'm sorry, but this would make the current implementation based on
pthread types (without indirection) invalid. 8-(
Thanks,
Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 8:09 ` Florian Weimer
@ 2017-11-15 11:22 ` Adhemerval Zanella
2017-11-15 12:03 ` Florian Weimer
0 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-11-15 11:22 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 15/11/2017 06:09, Florian Weimer wrote:
> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>> 9899:2011),
>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>
>> Mostly of the definitions are composed based on POSIX conterparts,
>> such as
>> thrd_t (using pthread_t).
>
> I have skimmed the C11 discussion of these types, and C11 says that
> mtx_t et al. are “identifiers”. To me, this suggests they are
> handles, just like pthread_t in the POSIX threads implementation.
My understanding is "identifiers" follow the definition from C11 6.2.1
which does
not exclude a tag/struct to represent it. A possible issue is POSIX has
a model
o flat address space that is shared between all thread while C standard
makes it
implementation defined (allowing for instance segmented address space or
different vmas for hybrid computing). However I think C11 standard makes
no amend to address it and although there is some suggestions [1] to add
feature tests to handle it, it was no incorporated.
[1]
https://gustedt.wordpress.com/2012/10/14/c11-defects-c-threads-are-not-realizable-with-posix-threads/
>
> I'm sorry, but this would make the current implementation based on
> pthread types (without indirection) invalid. 8-(
That is not my understanding. Could you point in C11 standard where
identifier
in thread.h definition exclude the use of tag types?
>
> Thanks,
> Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 11:22 ` Adhemerval Zanella
@ 2017-11-15 12:03 ` Florian Weimer
2017-11-15 12:43 ` Adhemerval Zanella
0 siblings, 1 reply; 21+ messages in thread
From: Florian Weimer @ 2017-11-15 12:03 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>
>
> On 15/11/2017 06:09, Florian Weimer wrote:
>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>> 9899:2011),
>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>
>>> Mostly of the definitions are composed based on POSIX conterparts,
>>> such as
>>> thrd_t (using pthread_t).
>>
>> I have skimmed the C11 discussion of these types, and C11 says that
>> mtx_t et al. are “identifiersâ€. To me, this suggests they are
>> handles, just like pthread_t in the POSIX threads implementation.
> My understanding is "identifiers" follow the definition from C11 6.2.1
> which does not exclude a tag/struct to represent it.
I don't think “identifier†is used in this sense here.
The standard says (7.2.6.1/4):
“
The types are
\begin{quote}
\verb|cnd_t|
\end{quote}
which is a complete object type that holds an identifier for a condition
variable;
â€
The “holds an identifier†suggests to me that this use of the term
“identifier†does not refer to the C language construct. The
definitions in ISO/IEC 2382:2015(en) do not seem to be applicable, either.
The POSIX model assumes that the identity of a condition variable is
determined by its address. This means that pthread_cond_t cannot hold
an identifier, it is the thing itself, which means, among other things,
that you cannot make a copy (e.g. using memcpy) and the copy will behave
in the same way as the original, accessing the same condition variable.
If something is just an identifier for something else, it strongly
suggests to me that the underlying object is separate, and I can use a
bit-wise identical identifier to reference the identical underlying object.
Thanks,
Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 12:03 ` Florian Weimer
@ 2017-11-15 12:43 ` Adhemerval Zanella
2017-11-15 12:49 ` Florian Weimer
0 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-11-15 12:43 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 15/11/2017 10:03, Florian Weimer wrote:
> On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>>
>>
>> On 15/11/2017 06:09, Florian Weimer wrote:
>>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>>> 9899:2011),
>>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>>
>>>> Mostly of the definitions are composed based on POSIX conterparts,
>>>> such as
>>>> thrd_t (using pthread_t).
>>>
>>> I have skimmed the C11 discussion of these types, and C11 says that
>>> mtx_t et al. are “identifiers”. To me, this suggests they are
>>> handles, just like pthread_t in the POSIX threads implementation.
>
>> My understanding is "identifiers" follow the definition from C11 6.2.1
>> which does not exclude a tag/struct to represent it.
>
> I don't think “identifier” is used in this sense here.
>
> The standard says (7.2.6.1/4):
>
> “
> The types are
> \begin{quote}
> \verb|cnd_t|
> \end{quote}
> which is a complete object type that holds an identifier for a
> condition variable;
> ”
>
> The “holds an identifier” suggests to me that this use of the term
> “identifier” does not refer to the C language construct. The
> definitions in ISO/IEC 2382:2015(en) do not seem to be applicable,
> either.
I find it quite inconsistent and improbable that the threads definition
in C11
standard is using a defined vocabulary in a different meaning than the rest
of document.
>
> The POSIX model assumes that the identity of a condition variable is
> determined by its address. This means that pthread_cond_t cannot hold
> an identifier, it is the thing itself, which means, among other
> things, that you cannot make a copy (e.g. using memcpy) and the copy
> will behave in the same way as the original, accessing the same
> condition variable.
>
> If something is just an identifier for something else, it strongly
> suggests to me that the underlying object is separate, and I can use a
> bit-wise identical identifier to reference the identical underlying
> object.
My understanding is C11 threads standard does not create a tightly
definition
to try accommodate possible implementations where POSIX assumptions are
not required or exercised. However I do not see that a more constrict
implementation (based on POSIX for instance) is incompatible, the link I
provided
earlier is a suggestion to add features test to define which constraints are
defined in the environment.
Also the defined C11 threads API does not suggest me that the idea of the
types are to point to a concrete identifier. For instance, to compare
threads
C11 does provide thrd_equal instead of relying of memcmp for the defined
objects (as for bitwise underlying objects).
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 12:43 ` Adhemerval Zanella
@ 2017-11-15 12:49 ` Florian Weimer
2017-11-15 13:21 ` Adhemerval Zanella
0 siblings, 1 reply; 21+ messages in thread
From: Florian Weimer @ 2017-11-15 12:49 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On 11/15/2017 01:43 PM, Adhemerval Zanella wrote:
>
>
> On 15/11/2017 10:03, Florian Weimer wrote:
>> On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>>>
>>>
>>> On 15/11/2017 06:09, Florian Weimer wrote:
>>>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>>>> 9899:2011),
>>>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>>>
>>>>> Mostly of the definitions are composed based on POSIX conterparts,
>>>>> such as
>>>>> thrd_t (using pthread_t).
>>>>
>>>> I have skimmed the C11 discussion of these types, and C11 says that
>>>> mtx_t et al. are “identifiersâ€. To me, this suggests they are
>>>> handles, just like pthread_t in the POSIX threads implementation.
>>
>>> My understanding is "identifiers" follow the definition from C11 6.2.1
>>> which does not exclude a tag/struct to represent it.
>>
>> I don't think “identifier†is used in this sense here.
>>
>> The standard says (7.2.6.1/4):
>>
>> “
>> The types are
>> \begin{quote}
>> Â \verb|cnd_t|
>> \end{quote}
>> which is a complete object type that holds an identifier for a
>> condition variable;
>> â€
>>
>> The “holds an identifier†suggests to me that this use of the term
>> “identifier†does not refer to the C language construct. The
>> definitions in ISO/IEC 2382:2015(en) do not seem to be applicable,
>> either.
> I find it quite inconsistent and improbable that the threads definition
> in C11
> standard is using a defined vocabulary in a different meaning than the rest
> of document.
But how can a complete object *type* hold a C identifier? The language
does not support that. We don't have call-by-name or anything like that.
So this usage doesn't make sense to me, so I assume that something else
is meant here.
I'm trying to get access to the WG papers on which the text is based.
Maybe those illuminate what is meant here.
Thanks,
Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 12:49 ` Florian Weimer
@ 2017-11-15 13:21 ` Adhemerval Zanella
2017-11-15 13:35 ` Florian Weimer
0 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-11-15 13:21 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 15/11/2017 10:49, Florian Weimer wrote:
> On 11/15/2017 01:43 PM, Adhemerval Zanella wrote:
>>
>>
>> On 15/11/2017 10:03, Florian Weimer wrote:
>>> On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>>>>
>>>>
>>>> On 15/11/2017 06:09, Florian Weimer wrote:
>>>>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>>>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>>>>> 9899:2011),
>>>>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>>>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>>>>
>>>>>> Mostly of the definitions are composed based on POSIX conterparts,
>>>>>> such as
>>>>>> thrd_t (using pthread_t).
>>>>>
>>>>> I have skimmed the C11 discussion of these types, and C11 says that
>>>>> mtx_t et al. are “identifiersâ€. To me, this suggests they are
>>>>> handles, just like pthread_t in the POSIX threads implementation.
>>>
>>>> My understanding is "identifiers" follow the definition from C11 6.2.1
>>>> which does not exclude a tag/struct to represent it.
>>>
>>> I don't think “identifier†is used in this sense here.
>>>
>>> The standard says (7.2.6.1/4):
>>>
>>> “
>>> The types are
>>> \begin{quote}
>>> Â Â \verb|cnd_t|
>>> \end{quote}
>>> which is a complete object type that holds an identifier for a
>>> condition variable;
>>> â€
>>>
>>> The “holds an identifier†suggests to me that this use of the term
>>> “identifier†does not refer to the C language construct. The
>>> definitions in ISO/IEC 2382:2015(en) do not seem to be applicable,
>>> either.
>
>> I find it quite inconsistent and improbable that the threads definition
>> in C11
>> standard is using a defined vocabulary in a different meaning than the rest
>> of document.
>
> But how can a complete object *type* hold a C identifier? The language does not support that. We don't have call-by-name or anything like that.
Why do we need call-by-name to provide a complete identifier for C11 mtx_t
type? My understanding is we have the init functions to initialize the
objects and C11 threads avoid static initializers.
>
> So this usage doesn't make sense to me, so I assume that something else is meant here.
>
> I'm trying to get access to the WG papers on which the text is based. Maybe those illuminate what is meant here.
Similar objections were already raised in DR#493 [1], more specifically for
"1. What is the behavior of mtx_init() when called with a pointer to an object
initialized to all zeros (such as a mutex object with static storage duration)?
Are such calls valid, or if not, must the function fail by returning thrd_error,
or is its behavior unspecified, or perhaps undefined? (If it is the same as
calling it on an uninitialized object then how does one statically initialize a
mutex?)"
The committee discussion for this specific topic is aiming for:
"Problems with mtx_t
The semantics of copying a mtx_t are not specified, much like FILE §7.21.3p6."
[1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/summary.htm#dr_493
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 13:21 ` Adhemerval Zanella
@ 2017-11-15 13:35 ` Florian Weimer
2017-11-15 15:46 ` Adhemerval Zanella
0 siblings, 1 reply; 21+ messages in thread
From: Florian Weimer @ 2017-11-15 13:35 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On 11/15/2017 02:21 PM, Adhemerval Zanella wrote:
>
>
> On 15/11/2017 10:49, Florian Weimer wrote:
>> On 11/15/2017 01:43 PM, Adhemerval Zanella wrote:
>>>
>>>
>>> On 15/11/2017 10:03, Florian Weimer wrote:
>>>> On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>>>>>
>>>>>
>>>>> On 15/11/2017 06:09, Florian Weimer wrote:
>>>>>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>>>>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>>>>>> 9899:2011),
>>>>>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>>>>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>>>>>
>>>>>>> Mostly of the definitions are composed based on POSIX conterparts,
>>>>>>> such as
>>>>>>> thrd_t (using pthread_t).
>>>>>>
>>>>>> I have skimmed the C11 discussion of these types, and C11 says that
>>>>>> mtx_t et al. are “identifiersâ€. To me, this suggests they are
>>>>>> handles, just like pthread_t in the POSIX threads implementation.
>>>>
>>>>> My understanding is "identifiers" follow the definition from C11 6.2.1
>>>>> which does not exclude a tag/struct to represent it.
>>>>
>>>> I don't think “identifier†is used in this sense here.
>>>>
>>>> The standard says (7.2.6.1/4):
>>>>
>>>> “
>>>> The types are
>>>> \begin{quote}
>>>> Â Â \verb|cnd_t|
>>>> \end{quote}
>>>> which is a complete object type that holds an identifier for a
>>>> condition variable;
>>>> â€
>>>>
>>>> The “holds an identifier†suggests to me that this use of the term
>>>> “identifier†does not refer to the C language construct. The
>>>> definitions in ISO/IEC 2382:2015(en) do not seem to be applicable,
>>>> either.
>>
>>> I find it quite inconsistent and improbable that the threads definition
>>> in C11
>>> standard is using a defined vocabulary in a different meaning than the rest
>>> of document.
>>
>> But how can a complete object *type* hold a C identifier? The language does not support that. We don't have call-by-name or anything like that.
>
> Why do we need call-by-name to provide a complete identifier for C11 mtx_t
> type? My understanding is we have the init functions to initialize the
> objects and C11 threads avoid static initializers.
I read “holds†as “stores†in this context, as in:
“
\begin{quote}
\verb|struct timespec|
\end{quote}
which holds an interval specified in seconds and nanoseconds
â€
I think using this wording in the context of identifiers is extremely
sloppy because an object cannot store an identifier.
I would have expected language like this if indirection is not required:
“
The types are
\begin{quote}
\verb|cnd_t|
\end{quote}
which denotes a complete object type which holds a condition variable;
â€
>> So this usage doesn't make sense to me, so I assume that something else is meant here.
>>
>> I'm trying to get access to the WG papers on which the text is based. Maybe those illuminate what is meant here.
>
>
> Similar objections were already raised in DR#493 [1], more specifically for
>
> "1. What is the behavior of mtx_init() when called with a pointer to an object
> initialized to all zeros (such as a mutex object with static storage duration)?
> Are such calls valid, or if not, must the function fail by returning thrd_error,
> or is its behavior unspecified, or perhaps undefined? (If it is the same as
> calling it on an uninitialized object then how does one statically initialize a
> mutex?)"
>
> The committee discussion for this specific topic is aiming for:
>
> "Problems with mtx_t
>
> The semantics of copying a mtx_t are not specified, much like FILE §7.21.3p6."
>
> [1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/summary.htm#dr_493
Oh, this and the rest of the committee response assumes that the
synchronization objects are not just identifiers. I really wish this
was specified more explicitly.
So my concerns are apparently not shared by the committee.
Thanks,
Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 13:35 ` Florian Weimer
@ 2017-11-15 15:46 ` Adhemerval Zanella
2017-11-15 15:50 ` Florian Weimer
0 siblings, 1 reply; 21+ messages in thread
From: Adhemerval Zanella @ 2017-11-15 15:46 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 15/11/2017 11:35, Florian Weimer wrote:
> On 11/15/2017 02:21 PM, Adhemerval Zanella wrote:
>>
>>
>> On 15/11/2017 10:49, Florian Weimer wrote:
>>> On 11/15/2017 01:43 PM, Adhemerval Zanella wrote:
>>>>
>>>>
>>>> On 15/11/2017 10:03, Florian Weimer wrote:
>>>>> On 11/15/2017 12:22 PM, Adhemerval Zanella wrote:
>>>>>>
>>>>>>
>>>>>> On 15/11/2017 06:09, Florian Weimer wrote:
>>>>>>> On 09/22/2017 10:26 PM, Adhemerval Zanella wrote:
>>>>>>>> This patch adds the thrd_* definitions from C11 threads (ISO/IEC
>>>>>>>> 9899:2011),
>>>>>>>> more specifically thrd_create, thrd_curent, rhd_detach, thrd_equal,
>>>>>>>> thrd_exit, thrd_join, thrd_sleep, thrd_yield, and required types.
>>>>>>>>
>>>>>>>> Mostly of the definitions are composed based on POSIX conterparts,
>>>>>>>> such as
>>>>>>>> thrd_t (using pthread_t).
>>>>>>>
>>>>>>> I have skimmed the C11 discussion of these types, and C11 says that
>>>>>>> mtx_t et al. are “identifiersâ€. To me, this suggests they are
>>>>>>> handles, just like pthread_t in the POSIX threads implementation.
>>>>>
>>>>>> My understanding is "identifiers" follow the definition from C11 6.2.1
>>>>>> which does not exclude a tag/struct to represent it.
>>>>>
>>>>> I don't think “identifier†is used in this sense here.
>>>>>
>>>>> The standard says (7.2.6.1/4):
>>>>>
>>>>> “
>>>>> The types are
>>>>> \begin{quote}
>>>>> Â Â Â \verb|cnd_t|
>>>>> \end{quote}
>>>>> which is a complete object type that holds an identifier for a
>>>>> condition variable;
>>>>> â€
>>>>>
>>>>> The “holds an identifier†suggests to me that this use of the term
>>>>> “identifier†does not refer to the C language construct. The
>>>>> definitions in ISO/IEC 2382:2015(en) do not seem to be applicable,
>>>>> either.
>>>
>>>> I find it quite inconsistent and improbable that the threads definition
>>>> in C11
>>>> standard is using a defined vocabulary in a different meaning than the rest
>>>> of document.
>>>
>>> But how can a complete object *type* hold a C identifier? The language does not support that. We don't have call-by-name or anything like that.
>>
>> Why do we need call-by-name to provide a complete identifier for C11 mtx_t
>> type? My understanding is we have the init functions to initialize the
>> objects and C11 threads avoid static initializers.
>
> I read “holds†as “stores†in this context, as in:
>
> “
> \begin{quote}
> Â Â Â \verb|struct timespec|
> \end{quote}
> which holds an interval specified in seconds and nanoseconds
> â€
>
> I think using this wording in the context of identifiers is extremely sloppy because an object cannot store an identifier.
>
> I would have expected language like this if indirection is not required:
>
> “
> The types are
> \begin{quote}
> Â Â Â \verb|cnd_t|
> \end{quote}
> which denotes a complete object type which holds a condition variable;
> â€
>
I agree with you the wording could be more carefully picked in this case,
but the DR for C11 threads also points to a description you put.
>>> So this usage doesn't make sense to me, so I assume that something else is meant here.
>>>
>>> I'm trying to get access to the WG papers on which the text is based. Maybe those illuminate what is meant here.
>>
>>
>> Similar objections were already raised in DR#493 [1], more specifically for
>>
>> "1. What is the behavior of mtx_init() when called with a pointer to an object
>> initialized to all zeros (such as a mutex object with static storage duration)?
>> Are such calls valid, or if not, must the function fail by returning thrd_error,
>> or is its behavior unspecified, or perhaps undefined? (If it is the same as
>> calling it on an uninitialized object then how does one statically initialize a
>> mutex?)"
>>
>> The committee discussion for this specific topic is aiming for:
>>
>> "Problems with mtx_t
>>
>> The semantics of copying a mtx_t are not specified, much like FILE §7.21.3p6."
>>
>> [1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/summary.htm#dr_493
>
> Oh, this and the rest of the committee response assumes that the synchronization objects are not just identifiers. I really wish this was specified more explicitly.
>
> So my concerns are apparently not shared by the committee.
We had some discussion back in v3 about the opened DR for C11 threads [1].
I has the assumption we had no block back then regarding base glibc
implementation on underlying POSIX one.
[1] https://sourceware.org/ml/libc-alpha/2017-03/msg00461.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] nptl: Add C11 threads thrd_* functions
2017-11-15 15:46 ` Adhemerval Zanella
@ 2017-11-15 15:50 ` Florian Weimer
0 siblings, 0 replies; 21+ messages in thread
From: Florian Weimer @ 2017-11-15 15:50 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: libc-alpha
On 11/15/2017 04:46 PM, Adhemerval Zanella wrote:
> We had some discussion back in v3 about the opened DR for C11 threads [1].
> I has the assumption we had no block back then regarding base glibc
> implementation on underlying POSIX one.
I just want to minimize the risk that we implement something which is
clearly incompatible with the standard. But it seems that at least as
far as the handle matter is concerned, the standard doesn't say what it
means, and a non-handle implementation would be conforming, so that
shouldn't be a problem for us.
Thanks,
Florian
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2017-11-15 15:50 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 20:27 [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 2/8] nptl: Add C11 threads mtx_* functions Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 5/8] nptl: Add C11 threads tss_* functions Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 1/8] nptl: Add C11 threads thrd_* functions Adhemerval Zanella
2017-11-15 8:09 ` Florian Weimer
2017-11-15 11:22 ` Adhemerval Zanella
2017-11-15 12:03 ` Florian Weimer
2017-11-15 12:43 ` Adhemerval Zanella
2017-11-15 12:49 ` Florian Weimer
2017-11-15 13:21 ` Adhemerval Zanella
2017-11-15 13:35 ` Florian Weimer
2017-11-15 15:46 ` Adhemerval Zanella
2017-11-15 15:50 ` Florian Weimer
2017-09-22 20:27 ` [PATCH 7/8] nptl: Add test cases for ISO C11 threads Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 3/8] nptl: Add C11 threads call_once functions Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 8/8] Add manual documentation for threads.h Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 6/8] nptl: Add abilist symbols for C11 threads Adhemerval Zanella
2017-09-22 20:27 ` [PATCH 4/8] nptl: Add C11 threads cnd_* functions Adhemerval Zanella
2017-10-03 19:07 ` [PATCH v7 0/8] Add support for ISO C threads.h Adhemerval Zanella
2017-10-10 18:48 ` Adhemerval Zanella
2017-10-26 12:19 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).