From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
Date: Thu, 10 Jan 2019 13:47:00 -0000 [thread overview]
Message-ID: <5357970.k6zCfxj4Tn@porto> (raw)
In-Reply-To: <87zhs8lqvb.fsf@oldenburg2.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
Am Donnerstag, 10. Januar 2019, 12:00:08 CET schrieb Florian Weimer:
> * Andreas K. Hüttel:
> > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the
> > puzzling
> > output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
> > Turns out the switch statement is missing a break, so the "T_AAAA" case
> > continues with "default".
>
> The change is obviously correct. I will commit it for you.
>
> However, how do you encounter this issue? Did you change some test?
> The current IDN tests do not actually send AAAA queries, I think.
>
> Thanks,
> Florian
That's a puzzling question indeed. I didnt change anything with the test
suite; the code is ~ tip of 2.28 release branch (plus few Gentoo-specific
patches).
The only Gentoo-specific commit which could be relevant is that we revert
8479f23aa1d5e5477a37f46823856bdafaedfa46 ("sysdeps/posix/getaddrinfo.c
(gaih_inet): Only use gethostbyname4_r ..."). For the background see
https://bugs.gentoo.org/600632
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-10 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 0:17 Andreas K. Hüttel
2019-01-10 11:01 ` Florian Weimer
2019-01-10 13:47 ` Andreas K. Huettel [this message]
2019-01-10 13:51 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357970.k6zCfxj4Tn@porto \
--to=dilfridge@gentoo.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).