From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1.1] __gconv_translit_find: Actually append ".so" to module name [BZ #17187]
Date: Tue, 26 Aug 2014 12:25:00 -0000 [thread overview]
Message-ID: <53FC7CA5.2000100@redhat.com> (raw)
In-Reply-To: <mvmvbpfqwox.fsf@hawking.suse.de>
On 08/26/2014 02:09 PM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
>> + /* This function always fails. Transliteration module loading is
>> + not implemented. */
>> + return 1;
>
> Since it always fails you can just remove the function completely.
If taken to the logical conclusion, this has a ripple effect and is not
suitable for backporting:
<https://sourceware.org/ml/libc-alpha/2014-08/msg00119.html>
So I had to stop somewhere, and I think the patch from last week is a
reasonable compromise for backports and the 2.20 release.
--
Florian Weimer / Red Hat Product Security
next prev parent reply other threads:[~2014-08-26 12:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 13:01 [PATCH] " Florian Weimer
2014-07-28 23:02 ` Roland McGrath
2014-07-29 5:50 ` Florian Weimer
[not found] ` <CAJ_zFkJLdEpJzKSM3HDN6PuVriTd4vKNqq=EubtCR5qqvt1U8g@mail.gmail.com>
2014-07-29 19:05 ` Florian Weimer
2014-07-31 18:09 ` Tavis Ormandy
2014-07-31 20:29 ` Joseph S. Myers
2014-08-08 15:34 ` Florian Weimer
2014-08-21 17:33 ` [PATCH v1.1] " Florian Weimer
2014-08-26 6:35 ` Siddhesh Poyarekar
2014-08-26 9:52 ` Florian Weimer
2014-08-26 11:23 ` Allan McRae
2014-08-26 14:33 ` Carlos O'Donell
2014-08-26 16:46 ` Carlos O'Donell
2014-08-26 12:09 ` Andreas Schwab
2014-08-26 12:25 ` Florian Weimer [this message]
2014-08-26 14:36 ` Carlos O'Donell
2014-08-26 16:45 ` Carlos O'Donell
2014-08-26 16:55 ` Florian Weimer
2014-08-26 17:54 ` Carlos O'Donell
2014-08-26 18:45 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC7CA5.2000100@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).