From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Lukasz Majewski <lukma@denx.de>,
Joseph Myers <joseph@codesourcery.com>,
Florian Weimer <fweimer@redhat.com>
Cc: Paul Eggert <eggert@cs.ucla.edu>,
Alistair Francis <alistair23@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fw@deneb.enyo.de>,
Zack Weinberg <zackw@panix.com>
Subject: Re: [PATCH v3] tst: Provide test for sched_rr_get_interval
Date: Mon, 15 Feb 2021 17:15:45 -0300 [thread overview]
Message-ID: <53af6d81-e2bc-cf03-8e61-afe70ce7f068@linaro.org> (raw)
In-Reply-To: <20210210124229.32367-1-lukma@denx.de>
On 10/02/2021 09:42, Lukasz Majewski wrote:
> This change adds new test to assess sched_rr_get_interval's
> functionality.
>
> To be more specific - following use cases are checked:
> - If the read interval is correct
> - If the proper ABI is used - to check if adjacent data is not
> overwritten
>
> ---
> Changes for v2:
> - Move test execution from tests to xtests
> - Use TEST_VERIFY_EXIT () macro instead of if () clause with FAIL_EXIT1 ()
>
> Changes for v3:
> - Replace TEST_VERIFY_EXIT () with TEST_VERIFY () to allow executing all
> tests (do not quit early after error)
Ok with the small nit below.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> posix/Makefile | 2 +-
> posix/tst-sched_rr_get_interval.c | 45 +++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+), 1 deletion(-)
> create mode 100644 posix/tst-sched_rr_get_interval.c
>
> diff --git a/posix/Makefile b/posix/Makefile
> index f54015b9a8..239fbb340a 100644
> --- a/posix/Makefile
> +++ b/posix/Makefile
> @@ -108,7 +108,7 @@ tests-internal := bug-regex5 bug-regex20 bug-regex33 \
> tst-rfc3484 tst-rfc3484-2 tst-rfc3484-3 \
> tst-glob_lstat_compat tst-spawn4-compat
> tests-container := bug-ga2
> -xtests := tst-getaddrinfo4 tst-getaddrinfo5
> +xtests := tst-getaddrinfo4 tst-getaddrinfo5 tst-sched_rr_get_interval
> ifeq (yes,$(build-shared))
> test-srcs := globtest
> tests += wordexp-test tst-exec tst-spawn tst-spawn2 tst-spawn3
Ok.
> diff --git a/posix/tst-sched_rr_get_interval.c b/posix/tst-sched_rr_get_interval.c
> new file mode 100644
> index 0000000000..e5ebe4d004
> --- /dev/null
> +++ b/posix/tst-sched_rr_get_interval.c
> @@ -0,0 +1,45 @@
> +/* Test for sched_rr_get_interval
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <time.h>
> +#include <sched.h>
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> + struct timespec ts[2] = { { -1, -1 }, { -1, -1 } };
> + const struct sched_param param = {
> + .sched_priority = sched_get_priority_max (SCHED_RR) - 10,
> + };
> + int result = sched_setscheduler (0, SCHED_RR, ¶m);
> +
> + if (result != 0)
> + FAIL_UNSUPPORTED ("*** sched_setscheduler error: %m\n");
No need of '***'.
> +
> + TEST_COMPARE (sched_rr_get_interval (0, ts), 0);
> +
> + /* Check if returned time values are correct. */
> + TEST_VERIFY (ts[0].tv_sec >= 0);
> + TEST_VERIFY (ts[0].tv_nsec >= 0 && ts[0].tv_nsec < 1000000000);
> + TEST_VERIFY (ts[1].tv_sec == -1 && ts[1].tv_nsec == -1);
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
>
Ok.
prev parent reply other threads:[~2021-02-15 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 12:42 Lukasz Majewski
2021-02-15 9:44 ` Lukasz Majewski
2021-02-15 20:15 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53af6d81-e2bc-cf03-8e61-afe70ce7f068@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).