From: Florian Weimer <fweimer@redhat.com>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: [PATCH] Turn implict-function-declaration warnings into errors
Date: Mon, 08 Sep 2014 12:17:00 -0000 [thread overview]
Message-ID: <540D9E47.6020904@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
GCC 4.4, the minimum compiler version, supports this option. Unlike
other warnings, -Wimplicit-function-declaration warnings should be
independent of compiler versions, so this change should not cause
compiler-specific build failures (the usual trouble with -Werror).
Testing this change revealed one missing #include file in a test case.
--
Florian Weimer / Red Hat Product Security
[-- Attachment #2: 0001-Turn-on-Werror-implicit-function-declaration.patch --]
[-- Type: text/x-patch, Size: 1664 bytes --]
From 842685f0c3f38d81474e809ff0b112099ed11e1c Mon Sep 17 00:00:00 2001
From: Florian Weimer <fweimer@redhat.com>
Date: Mon, 8 Sep 2014 13:49:36 +0200
Subject: [PATCH 1/2] Turn on -Werror=implicit-function-declaration
GCC 4.4, the minimum compiler version, supports this option. Unlike
other warnings, -Wimplicit-function-declaration warnings should be
independent of compiler versions, so this change should not cause
compiler-specific build failures.
---
ChangeLog | 8 ++++++++
Makeconfig | 2 +-
stdlib/tst-tls-atexit-lib.c | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
2014-09-08 Florian Weimer <fweimer@redhat.com>
* Makeconfig (gccwarn-c): Turn implicit-function-declaration
warnings into errors.
* stdlib/tst-tls-atexit-lib.c: Include <stdlib.h>, for the
__cxa_thread_atexit_impl prototype.
diff --git a/Makeconfig b/Makeconfig
index cef0f06..0f8069b 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -717,7 +717,7 @@ else
+gccwarn := -Wall -Wwrite-strings -Winline
endif
+gccwarn += -Wundef
-+gccwarn-c = -Wstrict-prototypes
++gccwarn-c = -Wstrict-prototypes -Werror=implicit-function-declaration
# We do not depend on the address of constants in different files to be
# actually different, so allow the compiler to merge them all.
diff --git a/stdlib/tst-tls-atexit-lib.c b/stdlib/tst-tls-atexit-lib.c
index 964f94b..b67d62f 100644
--- a/stdlib/tst-tls-atexit-lib.c
+++ b/stdlib/tst-tls-atexit-lib.c
@@ -16,6 +16,8 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
+#include <stdlib.h>
+
extern void *__dso_handle;
typedef struct
--
1.9.3
next reply other threads:[~2014-09-08 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:17 Florian Weimer [this message]
2014-09-09 21:06 ` Roland McGrath
2014-09-12 8:28 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540D9E47.6020904@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).