public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Cleanup MIPS preconfigure script
Date: Tue, 09 Sep 2014 17:22:00 -0000	[thread overview]
Message-ID: <540F3760.5010203@linux.vnet.ibm.com> (raw)
In-Reply-To: <1410282834.2740.159.camel@ubuntu-sellcey>

On 09-09-2014 14:13, Steve Ellcey wrote:
> On Tue, 2014-09-09 at 18:08 +0100, Maciej W. Rozycki wrote:
>> On Tue, 9 Sep 2014, Steve Ellcey wrote:
>>
>>> +if test "$abiflag" != "_ABIO32" -a "$mips16flag" = "1"; then
>>> +	as_fn_error $? "mips16 is only supported with the O32 ABI." "$LINENO" 5
>>> +fi
>>  Hmm, I think the capitalisation is weird here, why not:
>>
>> +	as_fn_error $? "MIPS16 is only supported with the o32 ABI." "$LINENO" 5
>>
>> ?
>>
>>   Maciej
> I already checked it in but I can go back and tweak the capitalization
> if you want.
>
> Steve Ellcey
> sellcey@mips.com
>
And patch 0febba23ddabcd971be5259ee20236b9e3efa690 broke powerpc64 configure:

$ /home/azanella/glibc/glibc-git/configure --prefix=/usr --with-cpu=power8 
checking build system type... powerpc64-unknown-linux-gnu
checking host system type... powerpc64-unknown-linux-gnu
checking for gcc... gcc
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for readelf... readelf
checking for sysdeps preconfigure fragments... aarch64 alpha arm hppa i386 m68k microblaze mips configure: error: Unable to determine ABI.

  reply	other threads:[~2014-09-09 17:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 20:58 Steve Ellcey 
2014-09-04 22:29 ` Maciej W. Rozycki
2014-09-04 22:52   ` Steve Ellcey
2014-09-04 23:23     ` Maciej W. Rozycki
2014-09-05 20:17       ` Steve Ellcey
2014-09-05 21:56         ` Joseph S. Myers
2014-09-05 22:37           ` Steve Ellcey
2014-09-09 16:18           ` Steve Ellcey
2014-09-09 16:40             ` Joseph S. Myers
2014-09-09 17:08             ` Maciej W. Rozycki
2014-09-09 17:14               ` Steve Ellcey
2014-09-09 17:22                 ` Adhemerval Zanella [this message]
2014-09-09 17:24                   ` Joseph S. Myers
2014-09-09 17:44                     ` Steve Ellcey
2014-09-09 17:49                       ` Joseph S. Myers
2014-09-09 18:01                         ` Steve Ellcey
2014-09-09 18:21                 ` Maciej W. Rozycki
2014-09-09 18:30                   ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540F3760.5010203@linux.vnet.ibm.com \
    --to=azanella@linux.vnet.ibm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).