From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6747 invoked by alias); 11 Sep 2014 19:42:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 6734 invoked by uid 89); 11 Sep 2014 19:42:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <5411FB27.6000007@redhat.com> Date: Thu, 11 Sep 2014 19:42:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Wilco Dijkstra , libc-alpha@sourceware.org Subject: Re: [PATCH] Improve performance of strcat References: <000101cfb243$63a5b1b0$2af11510$@com> In-Reply-To: <000101cfb243$63a5b1b0$2af11510$@com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00236.txt.bz2 On 08/07/2014 09:27 AM, Wilco Dijkstra wrote: > Hi, > > This patch improves strcat performance by using strlen and strcpy. Strlen has a fast C > implementation, so this improves performance even on targets which don't have an optimized strlen > and strcpy - it is 25% faster in bench-strcat. On targets which don't provide an optimized strcat > but which do have an optimized strlen and strcpy, performance gain is > 2x. What benchmarks did you use to test this performance gain? Did you use glibc's microbenchmark? What numbers did you get? c.