From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 407 invoked by alias); 23 Sep 2014 11:25:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 396 invoked by uid 89); 23 Sep 2014 11:25:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <5421587B.5070303@redhat.com> Date: Tue, 23 Sep 2014 11:25:00 -0000 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Roland McGrath , "Carlos O'Donell" CC: Kalle Olavi Niemitalo , libc-alpha Subject: Re: [PATCH v2] __builtin_expect cleanup for iconv{,data}/*.c References: <540E06B0.50406@redhat.com> <540F501B.2080808@redhat.com> <87ha0g4adb.fsf@Niukka.kon.iki.fi> <541001AC.50107@redhat.com> <87bnqn4b25.fsf@Niukka.kon.iki.fi> <20140910180713.D39B72C39CB@topped-with-meat.com> <54125038.1040109@redhat.com> <20140912175231.301EB2C3981@topped-with-meat.com> In-Reply-To: <20140912175231.301EB2C3981@topped-with-meat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00522.txt.bz2 On 09/12/2014 07:52 PM, Roland McGrath wrote: > I forgot to mention the other exception: if (foo & BIT) or if (!(foo & BIT)) > is fine, no need for if ((foo & BIT) != 0) or if ((foo & BIT) == 0). Thanks, so there shouldn't be a need to change the patch. -- Florian Weimer / Red Hat Product Security