From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B900A3982406 for ; Mon, 28 Jun 2021 12:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B900A3982406 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251--cFuDVMZPvuyya6Am7TdCw-1; Mon, 28 Jun 2021 08:31:12 -0400 X-MC-Unique: -cFuDVMZPvuyya6Am7TdCw-1 Received: by mail-qk1-f198.google.com with SMTP id v1-20020a372f010000b02903aa9be319adso17340552qkh.11 for ; Mon, 28 Jun 2021 05:31:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=k51u1AxdLWdqApOWJ1yxv5Udm1PIUL/aZ633gbDYP8k=; b=TMCw4ERGMlJftwLMbU4Xk+dVfhLP2Q40R5WhJRsCEhuZO5nfVlq/MCLnNE+w7fXOuX WZ1I917wY/ycFHd7XS2FH1dT8DcTYKAdqNDEt7HEWh8fD6YIe1Q4wA41nW4xHvTro26q MIqzoMUGSMFhhrr+yOGZYgdjTK8yKZWFf4Ex+9hUz2KkxR49H+JK76lLHJqOioEmU/Pc 4jgz2RnvM1VJtiy4M52sjkpklizz4UxFvtMAwCQWULSOBIeNsz4E8vyeQh5txWhl/y+s X3TYD6YZPuhjqGC9Mf5vQCH8Ra+08i86+PxC9Eny+nsPBXprZWWnONQdVJDzXU1J8O/9 ue3w== X-Gm-Message-State: AOAM531pfYggg60g/f4XE0D8B+vt7WqCV46u71mws/EoxybfLQtB6pNg +GbW2784fFAfi+xRdGfdoJALdTA/rnRAYbtCdaRLAFhHqMdo7G7S5dY6ghyeDoEHTwtIhVmkhFq DFaCmDalJzzofz99CoktWQErX1oLc715lpCKhw3qOlNX0Fom1v5sTaRsitNHwYDKOfScoLA== X-Received: by 2002:a05:620a:21d9:: with SMTP id h25mr12592892qka.353.1624883472244; Mon, 28 Jun 2021 05:31:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybu/PFDjcIUgfuohY2bQtuQDb7Mpj5yM0XwdczRs123vP/Yh7ReIkZt+rkVerCNhPRhE46ng== X-Received: by 2002:a05:620a:21d9:: with SMTP id h25mr12592879qka.353.1624883472052; Mon, 28 Jun 2021 05:31:12 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id z12sm8003412qtq.25.2021.06.28.05.31.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 05:31:11 -0700 (PDT) Subject: Re: [PATCH 2/3] nptl: Rename nptl_version to __nptl_version To: Florian Weimer , libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <54323a9c-a173-bb30-c99f-3a8056969ad6@redhat.com> Date: Mon, 28 Jun 2021 08:31:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 12:31:15 -0000 On 6/28/21 5:09 AM, Florian Weimer via Libc-alpha wrote: > This prepares it for exporting as a dynamic symbol. This is OK. Avoid namespace conflict. Tested on x86_64 without regression. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > nptl_db/structs.def | 2 +- > nptl_db/td_ta_new.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nptl_db/structs.def b/nptl_db/structs.def > index fb7bb9367d..248ecf4335 100644 > --- a/nptl_db/structs.def > +++ b/nptl_db/structs.def > @@ -73,7 +73,7 @@ DB_STRUCT (td_eventbuf_t) > DB_STRUCT_FIELD (td_eventbuf_t, eventnum) > DB_STRUCT_FIELD (td_eventbuf_t, eventdata) > > -DB_SYMBOL (nptl_version) > +DB_SYMBOL (__nptl_version) OK. Rename. > DB_SYMBOL (__nptl_create_event) > DB_SYMBOL (__nptl_death_event) > DB_SYMBOL (__nptl_threads_events) > diff --git a/nptl_db/td_ta_new.c b/nptl_db/td_ta_new.c > index 501d922ea2..eeca29d5a0 100644 > --- a/nptl_db/td_ta_new.c > +++ b/nptl_db/td_ta_new.c > @@ -39,7 +39,7 @@ td_ta_new (struct ps_prochandle *ps, td_thragent_t **ta) > LOG ("td_ta_new"); > > /* Check whether the versions match. */ > - if (td_lookup (ps, SYM_nptl_version, &versaddr) != PS_OK) > + if (td_lookup (ps, SYM___nptl_version, &versaddr) != PS_OK) OK. Rename. > return TD_NOLIBTHREAD; > if (ps_pdread (ps, versaddr, versbuf, sizeof (versbuf)) != PS_OK) > return TD_ERR; > -- Cheers, Carlos.