From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 441683858412 for ; Thu, 14 Oct 2021 20:25:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 441683858412 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19EJAGJL029810; Thu, 14 Oct 2021 16:25:51 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bptfhshew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 16:25:47 -0400 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19EKPjmd016054; Thu, 14 Oct 2021 16:25:45 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bptfhshe4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 16:25:45 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19EKHn2S031206; Thu, 14 Oct 2021 20:25:43 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma04wdc.us.ibm.com with ESMTP id 3bk2qc8m93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 20:25:43 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19EKOfJ832768420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Oct 2021 20:24:42 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9732EBE074; Thu, 14 Oct 2021 20:24:41 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CA0EBE077; Thu, 14 Oct 2021 20:24:40 +0000 (GMT) Received: from [9.65.203.65] (unknown [9.65.203.65]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 14 Oct 2021 20:24:39 +0000 (GMT) Subject: Re: [PATCH] powerpc: Remove backtrace implementation To: Tulio Magno Quites Machado Filho , Paul E Murphy , Adhemerval Zanella , Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210212170941.1786380-1-adhemerval.zanella@linaro.org> <878s7ti4m0.fsf@oldenburg.str.redhat.com> <90d1d0e5-a31e-fbac-ead0-7f76f2645cd9@linaro.org> <87sg5n3g04.fsf@linux.ibm.com> <87blcbx91u.fsf@oldenburg.str.redhat.com> <20210226173909.nikuk5bohko2clqj@work-tp> <57f96ee4-7586-de09-2234-ad09c347be84@linux.ibm.com> <87y2djzk1a.fsf@linux.ibm.com> From: Raphael M Zinsly Message-ID: <54397dc1-6bf4-b63e-399c-7bb87fea0fd5@linux.ibm.com> Date: Thu, 14 Oct 2021 17:24:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <87y2djzk1a.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BFOGL52lL1B-T7-vi_oXqo0dhuSs5EuK X-Proofpoint-GUID: RFPk4OVSavt4MpPBvbfMPhrZeUu-RfJa Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 12 URL's were un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-14_10,2021-10-14_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 clxscore=1011 spamscore=0 mlxscore=0 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110140112 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 20:25:54 -0000 On 15/04/2021 11:42, Tulio Magno Quites Machado Filho via Libc-alpha wrote: > Paul E Murphy via Libc-alpha writes: > >> Ping? This seems like a beneficial change. Using the unwind >> information makes for a much more robust backtrace with other languages >> which support C bindings but do not use the same ABI (specifically >> calling to and from go code in C). >> >> Should we instead turn the existing ppc backtrace into a compat symbol? >> This seems like it would address Tulio's issue with older binaries. > > If we do this, we'll never be able to remove the old implementation, which was > Adhemerval's goal. > I particularly agree that duplicated code should be removed and I believe it > would be helpful if libgcc had the fallback code. > I sent a patch to include the fallback to libgcc: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=b7561b5d2443f1d5f54f5177f0fb1a13c4205856 This patch LGTM now. Best Regards, -- Raphael Moreira Zinsly