From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] tst: Provide test for select
Date: Mon, 22 Mar 2021 16:23:35 -0300 [thread overview]
Message-ID: <54450734-e163-d14f-e8c9-4c8c1f2c3c0d@linaro.org> (raw)
In-Reply-To: <20210314164625.9312-1-lukma@denx.de>
On 14/03/2021 13:46, Lukasz Majewski wrote:
> This change adds new test to assess select()'s timeout related
> functionality (the rdfs set provides valid fd - stderr - but during
> normal program operation there is no data to be read, so one just
> waits for timeout).
>
> To be more specific - two use cases are checked:
> - if select() times out immediately when passed struct timeval has
> zero values of tv_usec and tv_sec.
> - if select() times out after timeout specified in passed argument
LGTM with the nits below.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> misc/Makefile | 2 +-
> misc/tst-select.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 71 insertions(+), 1 deletion(-)
> create mode 100644 misc/tst-select.c
>
> diff --git a/misc/Makefile b/misc/Makefile
> index a8363d4b76..a3545f047e 100644
> --- a/misc/Makefile
> +++ b/misc/Makefile
> @@ -88,7 +88,7 @@ tests := tst-dirname tst-tsearch tst-fdset tst-mntent tst-hsearch \
> tst-preadvwritev tst-preadvwritev64 tst-makedev tst-empty \
> tst-preadvwritev2 tst-preadvwritev64v2 tst-warn-wide \
> tst-ldbl-warn tst-ldbl-error tst-dbl-efgcvt tst-ldbl-efgcvt \
> - tst-mntent-autofs tst-syscalls tst-mntent-escape
> + tst-mntent-autofs tst-syscalls tst-mntent-escape tst-select
>
> tests-time64 := tst-pselect-time64
>
Ok.
> diff --git a/misc/tst-select.c b/misc/tst-select.c
> new file mode 100644
> index 0000000000..ea776c8880
> --- /dev/null
> +++ b/misc/tst-select.c
> @@ -0,0 +1,70 @@
> +/* Test for select timeout
Missing period.
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <time.h>
> +#include <errno.h>
> +#include <stdbool.h>
> +#include <sys/select.h>
> +#include <support/check.h>
> +#include <support/xtime.h>
> +#include <support/timespec.h>
> +
> +#define TST_SELECT_TIMEOUT 1
> +#define TST_SELECT_FD_ERR 2
> +
> +static int test_select_timeout (bool zero_tmo)
Move the function to next line:
| static int
| test_select_timeout (bool zero_tmo)
> +{
> + const int fds = TST_SELECT_FD_ERR;
> + int timeout = TST_SELECT_TIMEOUT;
> + struct timeval to = { 0, 0 };
> + struct timespec ts;
> + fd_set rfds;
> +
> + FD_ZERO (&rfds);
> + FD_SET (fds, &rfds);
> +
> + if (zero_tmo)
> + timeout = 0;
> +
> + to.tv_sec = timeout;
> + ts = xclock_now (CLOCK_REALTIME);
> + ts = timespec_add (ts, (struct timespec) { timeout, 0 });
> +
> + /* Wait for timeout. */
> + int ret = select (fds + 1, &rfds, NULL, NULL, &to);
> + if (ret == -1)
> + FAIL_EXIT1 ("select failed: %m\n");
> +
> + TEST_TIMESPEC_NOW_OR_AFTER (CLOCK_REALTIME, ts);
> +
> + return 0;
> +}
> +
Ok.
> +static int
> +do_test (void)
> +{
> + /* Check if select exits immediately. */
> + test_select_timeout (true);
> +
> + /* Check if select exits after specified timeout. */
> + test_select_timeout (false);
> +
> + return 0;
> +}
> +
> +#include <support/test-driver.c>
>
Ok.
prev parent reply other threads:[~2021-03-22 19:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 16:46 Lukasz Majewski
2021-03-14 19:17 ` DJ Delorie
2021-03-15 9:50 ` Lukasz Majewski
2021-03-15 17:11 ` DJ Delorie
2021-03-22 11:32 ` Lukasz Majewski
2021-03-24 19:17 ` H.J. Lu
2021-03-24 19:47 ` Adhemerval Zanella
2021-03-24 20:13 ` H.J. Lu
2021-03-24 21:14 ` Adhemerval Zanella
2021-03-24 21:21 ` H.J. Lu
2021-03-24 21:24 ` Adhemerval Zanella
2021-03-24 21:35 ` Samuel Thibault
2021-03-24 21:43 ` Adhemerval Zanella
2021-03-24 22:30 ` H.J. Lu
2021-03-25 11:35 ` Adhemerval Zanella
2021-03-25 12:20 ` Andreas Schwab
2021-03-25 12:48 ` Adhemerval Zanella
2021-03-25 13:22 ` H.J. Lu
2021-03-25 13:31 ` Adhemerval Zanella
2021-03-22 19:23 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54450734-e163-d14f-e8c9-4c8c1f2c3c0d@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).