From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74237-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 113513 invoked by alias); 31 Oct 2016 09:16:45 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 113496 invoked by uid 89); 31 Oct 2016 09:16:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*r:192.168.8, Hx-spam-relays-external:!192.168.8.100!, H*RU:!192.168.8.100!, H*r:ip*192.168.8.100
X-HELO: mail-qt0-f174.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:cc:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=mXvEuog1jxPb7i2+nAx+FKA4UkbO9QTO+jDW6LdOGdY=;
        b=GwNM+vZ6UXbBcQ2Qyu/7kiOAi0QLUJHHVAtB9vb2wsMDkVlH/fJbQcZz2ZDVMJAhQZ
         NXygYeqLjf6UuUo51KJdPmK7M/LdDnTZanTYpprO4G3ry7i+UOYujlIj3kYGMAOSFUGb
         3zW892wSTMJzUmhLz1zHsYRfSd8+s6chHYv8NPRY3NDD1jmH0oKUudBKJavZjmWQte8f
         jqJYkhtuQEb4f/3f8WE+BBrcwP/CKbqHIB0+rFnXumHiwF7qJVsuTWlk/X5oKqy6klNx
         Z+bZFwNMo0D/AcclN2CwWd5z7/C6LC4Dnq029hnVX77pHZ2ZcfmiGyHdilhcEq0oVDZC
         6L5A==
X-Gm-Message-State: ABUngvcrW2glDZdfPmN7DajnA0mPu4IH/jsg/3P0V4VhAduZF0Vlez7y5AmeKQgFGno42vYA
X-Received: by 10.237.50.37 with SMTP id y34mr11133424qtd.40.1477905392119;
        Mon, 31 Oct 2016 02:16:32 -0700 (PDT)
Subject: Re: [PATCH v4] Fix -Os related build and test failures.
To: Andreas Schwab <schwab@suse.de>
References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com>
 <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com>
 <alpine.DEB.2.20.1610281248260.32491@digraph.polyomino.org.uk>
 <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com>
 <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com>
 <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com>
 <alpine.DEB.2.20.1610281413340.7606@digraph.polyomino.org.uk>
 <db9cd7c1-1f32-8fc9-873d-f13bf563a301@redhat.com>
 <alpine.DEB.2.20.1610291734390.11193@digraph.polyomino.org.uk>
 <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com>
 <mvmins8hq95.fsf@hawking.suse.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
 Florian Weimer <fweimer@redhat.com>,
 GNU C Library <libc-alpha@sourceware.org>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <54572ad0-f92b-14d2-5238-428978285750@redhat.com>
Date: Mon, 31 Oct 2016 09:16:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <mvmins8hq95.fsf@hawking.suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-10/txt/msg00597.txt.bz2

On 10/31/2016 04:33 AM, Andreas Schwab wrote:
> https://build.opensuse.org/project/monitor/home:Andreas_Schwab:glibc
> 
> In file included from strxfrm_l.c:48:0:
> ../locale/weight.h: In function ‘findidx’:
> ../locale/weight.h:69:4: error: ‘DIAG_PUSH_NEEDS_COMMENT’ undeclared (first use in this function)
>     DIAG_PUSH_NEEDS_COMMENT;
>     ^~~~~~~~~~~~~~~~~~~~~~~
> ../locale/weight.h:69:4: note: each undeclared identifier is reported only once for each function it appears in
> ../locale/weight.h:70:4: error: implicit declaration of function ‘DIAG_IGNORE_Os_NEEDS_COMMENT’ [-Werror=implicit-function-declaration]
>     DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../locale/weight.h:74:4: error: ‘DIAG_POP_NEEDS_COMMENT’ undeclared (first use in this function)
>     DIAG_POP_NEEDS_COMMENT;
>     ^~~~~~~~~~~~~~~~~~~~~~

I'm fixing this. I don't know why this didn't fail on my x86_64 build.

I'm moving the #include <libc-internal.h> into the weight header fragments.

Cheers,
Carlos.