public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: Add macros for diagnostic control, use them in locale/weightwc.h
Date: Fri, 21 Nov 2014 17:29:00 -0000	[thread overview]
Message-ID: <546F7662.4060109@cs.ucla.edu> (raw)
In-Reply-To: <alpine.DEB.2.10.1411191455100.28145@digraph.polyomino.org.uk>

Joseph Myers wrote:
> The point is it's something you can grep for so that only a subset of the
> diagnostic disabling needs checking each time the minimum GCC version
> increases.

This worries me, because it implies these macros will be so commonly used that 
the cost in adding (and more importantly, having developers read) GCC version 
numbers every time the macros are used is worth the benefit of checking only a 
subset of the uses once in a blue moon.  If these macros are rarely used, the 
version numbers won't help much; and if the macros are used often I expect we 
will have so many other problems that the version numbers won't help much.

  reply	other threads:[~2014-11-21 17:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 18:04 Joseph Myers
2014-11-18 20:53 ` Paul Eggert
2014-11-18 21:18   ` Roland McGrath
2014-11-18 22:29     ` Paul Eggert
2014-11-18 23:16       ` Joseph Myers
2014-11-18 23:58         ` Paul Eggert
2014-11-19  0:06           ` Joseph Myers
2014-11-19  6:52             ` Paul Eggert
2014-11-19  9:09             ` Andreas Schwab
2014-11-19 15:42               ` Joseph Myers
2014-11-18 23:00   ` Joseph Myers
2014-11-18 23:49     ` Paul Eggert
2014-11-19  0:03       ` Joseph Myers
2014-11-19  6:51         ` Paul Eggert
2014-11-19 14:56           ` Joseph Myers
2014-11-21 17:29             ` Paul Eggert [this message]
2014-11-21 18:27               ` Joseph Myers
2014-11-21 17:05 ` Joseph Myers
2014-11-21 17:43   ` Paul Eggert
2014-11-21 18:12     ` Joseph Myers
2014-11-21 19:17       ` Paul Eggert
2014-11-21 22:47         ` Joseph Myers
2014-11-21 23:03           ` Joseph Myers
2014-11-22  5:14           ` Paul Eggert
2014-11-24 23:47             ` Roland McGrath
2014-11-25  1:29               ` Joseph Myers
2014-11-25 22:35                 ` Paul Eggert
2014-11-25 22:42                   ` Roland McGrath
2014-11-25 22:42                   ` Joseph Myers
2014-11-26  0:24                     ` Paul Eggert
2014-11-26  0:36                       ` Joseph Myers
2014-11-26  0:42                         ` Paul Eggert
2014-11-25  0:00             ` Roland McGrath
2014-11-25 22:23               ` Paul Eggert
2014-11-21 22:29   ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546F7662.4060109@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).