From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25391 invoked by alias); 27 Nov 2014 17:38:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 25374 invoked by uid 89); 27 Nov 2014 17:38:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp04.br.ibm.com Message-ID: <547761A6.5030705@linux.vnet.ibm.com> Date: Thu, 27 Nov 2014 17:38:00 -0000 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: libc-alpha@sourceware.org Subject: Re: [PATCH v2] Add x86 32 bit vDSO time function support References: <5436D48C.2090509@linux.vnet.ibm.com> <5436F50C.9070002@codesourcery.com> <5457E5D5.6000103@linux.vnet.ibm.com> <54581516.9010908@codesourcery.com> <545A1D38.8030700@linux.vnet.ibm.com> <545A4EC3.80003@codesourcery.com> <546655C2.7090308@linux.vnet.ibm.com> In-Reply-To: <546655C2.7090308@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14112717-0029-0000-0000-00000225F9FA X-SW-Source: 2014-11/txt/msg00852.txt.bz2 On 14-11-2014 17:19, Adhemerval Zanella wrote: > On 05-11-2014 14:22, Nathan Lynch wrote: >> On 11/05/2014 06:51 AM, Adhemerval Zanella wrote: >>> On 03-11-2014 21:51, Nathan Lynch wrote: >>>>> i386 does not define HAVE_CLOCK_GETTIME_VSYSCALL and thus: >>>>> >>>>> sysdeps/unix/sysv/linux/clock_gettime.c: >>>>> >>>>> 26: # define INTERNAL_VSYSCALL INTERNAL_SYSCALL >>>>> >>>>> and then if INTERNAL_GETTIME is not defined, it will as: >>>>> >>>>> 37 #ifndef INTERNAL_GETTIME >>>>> 38 # define INTERNAL_GETTIME(id, tp) \ >>>>> 39 INTERNAL_VSYSCALL (clock_gettime, err, 2, id, tp) >>>>> 40 #endif >>>>> >>>>> And without proper set the PTR_DEMANGLE is not called either. >>>> I think my point might be better expressed as: why is INTERNAL_GETTIME >>>> defined in linux/clock_gettime.c at all? It is not used in the >>>> clock_gettime implementation. >>>> >>>> The only use in glibc of a macro by that name is in >>>> linux/timespec_get.c, and the arch can override it in its own >>>> timespec_get.c (as x86_64 currently does). >>>> >>> I see your point and I removed its definition now for x86. Below it's the revised >>> patchset. >> I have no further concerns, thanks. >> > Ping, is this patch ok to commit? > Ping.