From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4761 invoked by alias); 20 Apr 2017 13:40:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 4737 invoked by uid 89); 20 Apr 2017 13:40:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=cloud X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 15D3CA3281 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 15D3CA3281 Subject: Re: [PATCH] grp: testgrp should exit unsupported properly. To: Wainer dos Santos Moschetta , libc-alpha@sourceware.org References: <1492030877-22569-1-git-send-email-wainersm@gmail.com> <2a5059be-f3b5-f3f0-9e37-c4944bca14d9@redhat.com> From: Florian Weimer Message-ID: <54793c3d-ace3-8ce5-edb4-79d9ae03e867@redhat.com> Date: Thu, 20 Apr 2017 13:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00420.txt.bz2 On 04/20/2017 03:26 PM, Wainer dos Santos Moschetta wrote: > On 20-04-2017 08:56, Florian Weimer wrote: >> On 04/12/2017 11:01 PM, Wainer dos Santos Moschetta wrote: >>> grp/testgrp should properly exit unsupported if getpweuid() returns >>> NULL and it does not set errno since it indicates that tests are >>> executed by a passwordless user. >> >> Shouldn't this be a regular FAIL? We should assume that the user >> running the testsuite has a name. > > Is there a consensus about FAIL vs UNSUPPORTED? > > In https://sourceware.org/glibc/wiki/Testing/Testsuite you read: > "EXIT_UNSUPPORTEDfromis a magic exit status (77) > which indicates that the test is not supported on this particular system > (perhaps due to lack of hardware or kernel support detected at run time).". > > But I tend to think a test should exit unsupported if the environment > doesn't provide all requirements to execute the it properly. > > Giving a bit of context: I ran glibc's testsuite in an VM provided by a > cloud provider, which access is granted through SSH keys. Other tests > also exit FAIL due lack of user's password. In your case, it's an environment issue. But I think what you are proposing reduces the scope of the test itself, which is why I think this change is not appropriate. Thanks, Florian