public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <carlos@redhat.com>
To: John David Anglin <dave.anglin@bell.net>,
	Mike Frysinger <vapier@gentoo.org>
Cc: libc-alpha@sourceware.org, carlos@systemhalted.org
Subject: Re: [PATCH] hppa: fix __O_SYNC to match the kernel
Date: Wed, 11 Mar 2015 06:29:00 -0000	[thread overview]
Message-ID: <54FFE0D0.2070001@redhat.com> (raw)
In-Reply-To: <BLU437-SMTP89A288FA36C212A076A4A1971D0@phx.gbl>

On 03/07/2015 12:13 PM, John David Anglin wrote:
> On 2015-02-27, at 1:53 AM, Mike Frysinger wrote:
> 
>> On 24 Feb 2015 09:48, John David Anglin wrote:
>>> Mike, thanks for sending this change.  Reminds me I should go through 
>>> the Debian glibc
>>> patches and see what else needs sending.
>>
>> this should be an easy one:
>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1c1d3f4f11b4a911a3b6ffab0aac61d5f8e02873
>>
>> if you could provide context, i could shepherd it through.
>> -mike
> 
> 
> Attached is an updated patch.  It fixes the saving and updating of the floating-point environment
> in feholdexcept and fesetenv.  The glibc test "test-fenv" passes with this change.
> 
> The patch has been tested with Debian glibc 2.19-15+b1 with no observed regressions.

Applied.

commit fae1aa8d226ce860124efd67ede03004b19b89e2
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Tue Mar 10 23:43:50 2015 -0400

    hppa: Fix feholdexcpt and fesetenv (Bug 18110).
    
    The constraints in the inline assembly in feholdexcept and fesetenv
    are incorrect. The assembly modifies the buffer pointer, but doesn't
    express that in the constraints. The simple fix is to remove the
    modification of the buffer pointer which is no longer required by
    the existing code, and adjust the one constraint that did express
    the modification of bufptr.
    
    The change fixes test-fenv when glibc is compiled with recent gcc.

Cheers,
Carlos.

  parent reply	other threads:[~2015-03-11  6:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24  5:19 Mike Frysinger
2015-02-24 14:50 ` John David Anglin
2015-02-24 16:20   ` Joseph Myers
2015-02-27  5:06     ` Carlos O'Donell
2015-02-27  6:53   ` Mike Frysinger
2015-03-01 19:55     ` John David Anglin
2015-03-01 22:24       ` Joseph Myers
2015-03-02 13:18         ` John David Anglin
2015-03-02 14:09           ` Joseph Myers
2015-03-11  7:33           ` Mike Frysinger
2015-03-08 19:52       ` Carlos O'Donell
2015-03-08 21:30         ` John David Anglin
2015-03-09 12:36           ` Carlos O'Donell
2015-03-07 17:13     ` John David Anglin
2015-03-08 19:53       ` Carlos O'Donell
2015-03-11  6:29       ` Carlos O'Donell [this message]
2015-02-27  6:46 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FFE0D0.2070001@redhat.com \
    --to=carlos@redhat.com \
    --cc=carlos@systemhalted.org \
    --cc=dave.anglin@bell.net \
    --cc=libc-alpha@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).