From: Alejandro Colomar <alx@kernel.org>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc.c: Remove bogus __nonnull attribute
Date: Wed, 12 Jul 2023 01:07:53 +0200 [thread overview]
Message-ID: <54edf83e-8003-c1b6-2930-c9a2b11e6af4@kernel.org> (raw)
In-Reply-To: <xn4jmacrrd.fsf@greed.delorie.com>
[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]
On 2023-07-11 18:55, DJ Delorie wrote:
> Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> writes:
>> This function doesn't accept pointers.
>
> Does __nonnull() tell the compiler anything about not-pointers that
> can't be zero? Asking for a friend... ;-)
>
> LGTM
> Reviewed-by: DJ Delorie <dj@redhat.com>
Thanks! :-)
Whoever applies this, you could also add:
Fixes: 7519dee356a0 ("malloc: Simplify checked_request2size interface")
>
>> -checked_request2size (size_t req) __nonnull (1)
>> +checked_request2size (size_t req)
>
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-11 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 13:59 Alejandro Colomar
2023-07-11 16:55 ` DJ Delorie
2023-07-11 23:07 ` Alejandro Colomar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54edf83e-8003-c1b6-2930-c9a2b11e6af4@kernel.org \
--to=alx@kernel.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).