From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by sourceware.org (Postfix) with ESMTPS id 142523858D1E for ; Tue, 11 Jul 2023 23:07:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 142523858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B12B461625; Tue, 11 Jul 2023 23:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94AE4C433C8; Tue, 11 Jul 2023 23:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689116876; bh=4PmhiNdJ5DraLCGsWYicDKU8iherdfYKL8NYMI+2t5E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JF07ioRYOOto/pZNCz0F45j/hisUxtx9AExb+Wc4C5qU2wi8XZsWZ/uOGaUKk0X2j H7oq75CMm3pUf06jdAeoVrzMcnsAXN5i6aHlVB/sEl/tB4p7ZYBhxByqYR0M3prZ7W 2vj4VtlicxiosXcDF9f3BQTJ1Os3fR9cD5JDirT1fhdM0riMjHd8xoWovSKUfK0kn1 6rGSL4odnKyGcLSTWxM83TYDzUM3Vxl5WFxiaqklrKUiXnn5kZ2Bw9u6d/+7kR2PcD 8S4YKUZVoVUhGX7P/7RDTzTAAngB7ZLTr9x0V0Z4Uc44ukhmSsOfv02/mLkxjuWbkm 4/waf9aTtDFLA== Message-ID: <54edf83e-8003-c1b6-2930-c9a2b11e6af4@kernel.org> Date: Wed, 12 Jul 2023 01:07:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] malloc.c: Remove bogus __nonnull attribute Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Alejandro Colomar Organization: Linux In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------h1tVmvOhuZsfEqW8bVG0wnht" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------h1tVmvOhuZsfEqW8bVG0wnht Content-Type: multipart/mixed; boundary="------------IHiftru0BBFMPg8W7wDloIdR"; protected-headers="v1" From: Alejandro Colomar To: DJ Delorie Cc: libc-alpha@sourceware.org Message-ID: <54edf83e-8003-c1b6-2930-c9a2b11e6af4@kernel.org> Subject: Re: [PATCH] malloc.c: Remove bogus __nonnull attribute References: In-Reply-To: --------------IHiftru0BBFMPg8W7wDloIdR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2023-07-11 18:55, DJ Delorie wrote: > Alejandro Colomar via Libc-alpha writes: >> This function doesn't accept pointers. >=20 > Does __nonnull() tell the compiler anything about not-pointers that > can't be zero? Asking for a friend... ;-) >=20 > LGTM > Reviewed-by: DJ Delorie Thanks! :-) Whoever applies this, you could also add: Fixes: 7519dee356a0 ("malloc: Simplify checked_request2size interface") >=20 >> -checked_request2size (size_t req) __nonnull (1) >> +checked_request2size (size_t req) >=20 --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------IHiftru0BBFMPg8W7wDloIdR-- --------------h1tVmvOhuZsfEqW8bVG0wnht Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmSt4MkACgkQnowa+77/ 2zKMmw/6AlZEmrDxNvZZykrMZWFclx/17GLhE/qlo4xJ51edpzisJAwDSjwhl5Kc KZinzAxhh96CxCzpaR+Ih8BCwg6alEdAHoddCGvfa/z2Y3hWGouXsFTDP8TN9kjI GHn8cGurW6YKaMMVdYkPRlAEi0Sj/D6/LU6mQqRogWwEyX6Kuv549zpPzRDeawuu tD61VCmIJz9+EzYjW8szSeJ9MwFNZT8SsOCfEsP3xDJQtFwuie4qzvMYERuLPrth /5e3RqSzLwJl0FwIaKzhbyQBlevhF0Uv//IhaEcJPf2Hi1mu4SOXtK1/BXAwQ39Z wbqo4xwj66nqtBbhscC/nmNP8kSu/yYDISaMAVXp5aTRivf5GxFL67JQvEnulECM 8vfV84ceRW56P8r+nuollY3OY2NaKICvzJ1SgW/RI90vHXpvuFYmuy1gzI91QBxv CARRQHoA4yXRRDgoUu3RCESypM/Wxqc2Xs3y4OtXgCGdaEb0Ml0zjuLX9g1QiPBU 1dVsbTIdcRpMleu4DjK81f3xHxAthFal2Gc4g91CSft3mriuuqDC0iOrE8/z3Fyk mqK8BcSjbLn+K0MItZGKCt6ca7vWeXMkexApCh9qoK8ooTrtp3paRe0WTDm6xwJp 6PtREm8xYMGCa3OQcJOGJjEr49wSARCCsIQ9H8T3dAxcxHreQYo= =mskc -----END PGP SIGNATURE----- --------------h1tVmvOhuZsfEqW8bVG0wnht--