From: Carlos O'Donell <carlos@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
paul zimmermann <Paul.Zimmermann@inria.fr>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/4] Add a routine for accurate reduction mod (2pi), for j0f/j1f/y0f/y1f.
Date: Tue, 9 Feb 2021 08:30:46 -0500 [thread overview]
Message-ID: <54f13253-c99e-0400-dd48-990691aef6b8@redhat.com> (raw)
In-Reply-To: <VE1PR08MB55999E368C3EA41FDE4CF3E1838E9@VE1PR08MB5599.eurprd08.prod.outlook.com>
On 2/9/21 6:35 AM, Wilco Dijkstra via Libc-alpha wrote:
> Do we really need another range reducer here? Would it be possible to use the
> much faster reduce_fast and reduce_large in sysdeps/ieee754/flt-32/s_sincosf.h?
> Given that returns a 62-bit modulo of PI/4, it should be more accurate as well.
Paul and I were talking about this off-list, and my opinion was that we did not
need to block this patch on this issue.
I believe the range reducer here is *more* accurate than the one used for sincos,
so there would be a difference.
Refactoring to have one range reducer with sufficient accuracy to meet the needs
of both set of functions should not be a blocker for inclusion.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2021-02-09 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:35 Wilco Dijkstra
2021-02-09 13:30 ` Carlos O'Donell [this message]
2021-02-09 16:32 ` Paul Zimmermann
2021-02-09 18:27 ` Wilco Dijkstra
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 5:28 Paul Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f13253-c99e-0400-dd48-990691aef6b8@redhat.com \
--to=carlos@redhat.com \
--cc=Paul.Zimmermann@inria.fr \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).