From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Nathan Lynch <Nathan_Lynch@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 2/3] Consolidate gettimeofday across aarch64/s390/tile
Date: Tue, 19 May 2015 22:12:00 -0000 [thread overview]
Message-ID: <555B940A.9040105@linaro.org> (raw)
In-Reply-To: <555B7605.9040803@codesourcery.com>
On 19-05-2015 14:42, Nathan Lynch wrote:
> On 05/11/2015 02:11 PM, Adhemerval Zanella wrote:
>> This patch removes the architecture specific gettimeofday implementation
>> to use the vDSO symbol and consolidate it on a common Linux one.
>> Similat to gettime and getres vDSO implementation, each arch that supports
>> gettimeofday through vDSO should just implement INLINE_VSYSCALL to access
>> the symbol and define HAVE_GETTIMEOFDAY_VSYSCAL as 1.
>>
>> Tested on i386, x32, x86_64, ppc64le and aarch64. Ok to apply?
>>
>> Changes from previous version:
>>
>> - Fix SYSCALL spelling.
>>
>> --
>>
>> * sysdeps/unix/sysv/linux/aarch64/gettimeofday.c: Remove file.
>> * sysdeps/unix/sysv/linux/s390/gettimeofday.c: Likewise.
>> * sysdeps/unix/sysv/linux/tile/gettimeofday.c: Likewise.
>> * sysdeps/unix/sysv/linux/aarch64/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Define.
>> * sysdeps/unix/sysv/linux/s390/s390-32/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
>> * sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
>> * sysdeps/unix/sysv/linux/tile/sysdep.h
>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
>> * sysdeps/unix/sysv/linux/gettimeofday.c: New file: gettimeofday
>> using vDSO syscall macro.
>>
>
> With this change, do the #undefs in init-first.c (seen in aarch64, s390,
> powerpc, but not tile or x86) become unnecessary?
>
> # include <dl-vdso.h>
> # undef __gettimeofday
> # undef __clock_gettime
> # undef __clock_getres
> # include <libc-vdso.h>
>
>
> Otherwise looks fine to me.
>
Indeed the #undef's are not really required any more and in my testing builds
aarch64, s390 and powerpc all built fine without. I will remove them.
Any more concerns about it? I would like to install it.
next prev parent reply other threads:[~2015-05-19 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 19:12 Adhemerval Zanella
2015-05-19 19:40 ` Nathan Lynch
2015-05-19 22:12 ` Adhemerval Zanella [this message]
2015-05-26 22:17 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B940A.9040105@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Nathan_Lynch@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).