From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49647 invoked by alias); 19 May 2015 19:50:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49635 invoked by uid 89); 19 May 2015 19:50:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=VtNWjjGoidFefX7jX2lAcqjLGpBLbv9EdHlefVIqyi0=; b=fAgZrIPTyBiS12CYfoKy0HgjHpqrhLCatzx7sXFszxtnsX+Isj1bKswoysWyN7t71S KilgqfO+yiQKPfgNBC9IebmeM+EppD2GrWwSPEbhMvVqqvGuDrKh0w8UNvxHkZiH9QuL ABpSTIM7mK1RVsikGIuZUxcezTx9eBY0bpVnC5yul15MvV6EAKLL2h7muK2zoEK1xdi8 VsGUyJt7S30ooT+zZpF7nLClNT9QJXWE/nbRwbFHbCeG3L6c6SXCcK3NMV3S3wyQ6quC oslf2bQKVNyLPFb6NzEwZOS1OU/Am0RbT5Xn1vq/IGBA3fQJOGSXdf8RAY90njbIjE3q RUpg== X-Gm-Message-State: ALoCoQlOCl7Q+iCwfqvHjgiybJ4EZjqC1W+VIfbwutWVOadX4GO4b5tZgmgEKwF82EZMo4BBdiB+ X-Received: by 10.55.50.140 with SMTP id y134mr46643617qky.91.1432065037545; Tue, 19 May 2015 12:50:37 -0700 (PDT) Message-ID: <555B940A.9040105@linaro.org> Date: Tue, 19 May 2015 22:12:00 -0000 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nathan Lynch CC: GNU C Library Subject: Re: [PATCH v3 2/3] Consolidate gettimeofday across aarch64/s390/tile References: <5550FEF8.50501@linaro.org> <555B7605.9040803@codesourcery.com> In-Reply-To: <555B7605.9040803@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00390.txt.bz2 On 19-05-2015 14:42, Nathan Lynch wrote: > On 05/11/2015 02:11 PM, Adhemerval Zanella wrote: >> This patch removes the architecture specific gettimeofday implementation >> to use the vDSO symbol and consolidate it on a common Linux one. >> Similat to gettime and getres vDSO implementation, each arch that supports >> gettimeofday through vDSO should just implement INLINE_VSYSCALL to access >> the symbol and define HAVE_GETTIMEOFDAY_VSYSCAL as 1. >> >> Tested on i386, x32, x86_64, ppc64le and aarch64. Ok to apply? >> >> Changes from previous version: >> >> - Fix SYSCALL spelling. >> >> -- >> >> * sysdeps/unix/sysv/linux/aarch64/gettimeofday.c: Remove file. >> * sysdeps/unix/sysv/linux/s390/gettimeofday.c: Likewise. >> * sysdeps/unix/sysv/linux/tile/gettimeofday.c: Likewise. >> * sysdeps/unix/sysv/linux/aarch64/sysdep.h >> [HAVE_GETTIMEOFDAY_VSYSCALL]: Define. >> * sysdeps/unix/sysv/linux/s390/s390-32/sysdep.h >> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >> * sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h >> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >> * sysdeps/unix/sysv/linux/tile/sysdep.h >> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >> * sysdeps/unix/sysv/linux/gettimeofday.c: New file: gettimeofday >> using vDSO syscall macro. >> > > With this change, do the #undefs in init-first.c (seen in aarch64, s390, > powerpc, but not tile or x86) become unnecessary? > > # include > # undef __gettimeofday > # undef __clock_gettime > # undef __clock_getres > # include > > > Otherwise looks fine to me. > Indeed the #undef's are not really required any more and in my testing builds aarch64, s390 and powerpc all built fine without. I will remove them. Any more concerns about it? I would like to install it.