From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26390 invoked by alias); 21 May 2015 21:03:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 26377 invoked by uid 89); 21 May 2015 21:03:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f41.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=JEr2yV6rukxxi4bL0RgVEjK92j9YgPcXAUzP/fkx2YE=; b=ifJPggFjqtxvIF+fPeoEaugrTu8LZ8Zn48B9Yl7z+fHL9cmG0VRFuhxNP/udVGWWPZ bvnSvl1QhhZ/VgXGd/PRBzib+WMJtHMAyh1Ut7LlO+pg69MCZznPsChM/cOVAOFhwGGK dbxKi7qjuN9IEWbPmhexauH5du4WeH4o4/MY4x8/bJdbJPvv9OOk5Y9q/wbh2AIyJOg4 MlxsHUseHX1NY9jYjVGINfvrZsxD2bNcwenJEh6wf0Ti6jL1TexqVDgqqrMdd4ao/Myj 6UeZ/3U5VrpuZTCFqZAWSCEE4sirEBp4ZpE5ZDsOzvSp1LlXHQXv8gwpocg3s5EdbKZy 5dXw== X-Gm-Message-State: ALoCoQkQmEGlw4oBxZ3fJW5+WLJ2EOZt0BVJFou4zN3JHb5NsE8WeCriXmXTV+SsrHLNIFqVPeuo X-Received: by 10.140.233.140 with SMTP id e134mr6941055qhc.63.1432242212118; Thu, 21 May 2015 14:03:32 -0700 (PDT) Message-ID: <555E481E.90101@linaro.org> Date: Fri, 22 May 2015 10:02:00 -0000 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Henderson , GNU C Library Subject: Re: [PATCH v2] Remove socket.S implementation References: <555E3876.3010805@linaro.org> <555E3B7A.9080604@twiddle.net> In-Reply-To: <555E3B7A.9080604@twiddle.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00517.txt.bz2 On 21-05-2015 17:09, Richard Henderson wrote: > On 05/21/2015 12:56 PM, Adhemerval Zanella wrote: >> +#define __SOCKETCALL0(__name) \ >> + INLINE_SYSCALL (socketcall, 2, __name) > > If there really are any zero-arg socket calls, the second argument here must be > 1, or you must pass a second argument (null?). > > If there are no zero-arg socket calls, as I suspect, then remove this so that > someone gets a compile-time error for such a typo in the argument list. Indeed there is zero-arg socket call, so I will just remove it. > > >> +#define __SOCKETCALL1(__name, __a1) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [1]) { (long int) __a1 })) > > (1) you don't need __ in the macros; it just messies the text. > (2) you need parenthesis around the arguments before casting. > > Right, I will fix both (1) and (2). Thanks! > r~ > > >> +#define __SOCKETCALL2(__name, __a1, __a2) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [2]) { (long int) __a1, (long int) __a2 })) >> +#define __SOCKETCALL3(__name, __a1, __a2, __a3) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [3]) { (long int) __a1, (long int) __a2, (long int) __a3 })) >> +#define __SOCKETCALL4(__name, __a1, __a2, __a3, __a4) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [4]) { (long int) __a1, (long int) __a2, (long int) __a3, \ >> + (long int) __a4 })) >> +#define __SOCKETCALL5(__name, __a1, __a2, __a3, __a4, __a5) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [5]) { (long int) __a1, (long int) __a2, (long int) __a3, \ >> + (long int) __a4, (long int) __a5 })) >> +#define __SOCKETCALL6(__name, __a1, __a2, __a3, __a4, __a5, __a6) \ >> + INLINE_SYSCALL (socketcall, 2, __name, \ >> + ((long int [6]) { (long int) __a1, (long int) __a2, (long int) __a3, \ >> + (long int) __a4, (long int) __a5, (long int) __a6 })) >