From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id DFCE13857680 for ; Mon, 31 Oct 2022 19:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFCE13857680 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id t62so3054296oib.12 for ; Mon, 31 Oct 2022 12:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XpzfKNEoc6cI3LQy1nJsz+6Qa65Nh4gUXu/4vwPFRO0=; b=tXsPUJzzp4WYrcLOFj2Z4WWYTUxMQu2xNNtWvoPAOdeMmiJzwVSPOTzjocuPiqBsTF hUNisEMDvXvdfLPK9Z7QSoaqQkslwZvhuxF7kV2osm6ZDclJQ/9b3xR26s0SyQ9s4myc Vv3UvnMLAhHOjC1+QeZQzGaZRLHwIid7lzUREB3iui4pZdC0AXMZT8plAeY674EL3Tyb UJ8/hGyBdYkNRnqQkCDsI8OyXVCaGg4/6f0gayZB+7G9QB2rPsk/l9oLHY6bfGcXElIk hHc/IDl+Qj93fcxfsUztWUHwfmrYpbz1+CI3Gszh2DBe5VQ4QA6pSPFtmkm9ogwhhftc qjuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XpzfKNEoc6cI3LQy1nJsz+6Qa65Nh4gUXu/4vwPFRO0=; b=LnH1nav9RzzdY3ftnIV8YsXoxtK+TfM3QtmqQivQeaWWnhmdzyJj7q/W+c8rGVASQ9 6LTYaYdkk8jQbPc73Ed1nDiDCbbEdI96BNlcbIYz7U0BHMOJsD2Pw2CFYT3j4hJ3grzf meksyaQ5t/wtp4ACGPr8RJvdGQljEcAolfNoxuxH1yhGXmOQEd8YKDWUK4A21zV2boNC vjcCWjEfSFFQi1zZFdv01yRMYzi+WzeRHimjV+uW1gdOc2J4ZBBpjHqOsTq5o351E4Pv XykZ59KP0EQAeS2pHGBjRQ1+QqzlZuH8xLUECdbvPFr+UmOw9eog3fUCTqrOk71kOjHO 9LsA== X-Gm-Message-State: ACrzQf2NkGUuZ3fMTbLpS/tsGKpdGm3fCwflbxcJjAkHgYjkv+dtBv7g VKw3BtcXnzhK1Gli9NItHwWx/eNg7tEMs/LY X-Google-Smtp-Source: AMsMyM7C2atfUFqaZxTJmC5lMl/i+eUyXAo0fv+2k5kbNUUe9sDe/gzP2ITQYsgwMqCEHtJgE63qOA== X-Received: by 2002:aca:1019:0:b0:359:e535:bf92 with SMTP id 25-20020aca1019000000b00359e535bf92mr7400528oiq.90.1667246084166; Mon, 31 Oct 2022 12:54:44 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1? ([2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1]) by smtp.gmail.com with ESMTPSA id f14-20020a056830204e00b006393ea22c1csm2246963otp.16.2022.10.31.12.54.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 12:54:43 -0700 (PDT) Message-ID: <555aaef3-f310-4cb1-2c05-2e0d492fd313@linaro.org> Date: Mon, 31 Oct 2022 16:54:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Content-Language: en-US To: Fangrui Song Cc: libc-alpha@sourceware.org References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-6-adhemerval.zanella@linaro.org> <20221029004435.o6mhtrlsmugm7ufg@google.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20221029004435.o6mhtrlsmugm7ufg@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/10/22 21:44, Fangrui Song wrote: > On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >> Clang warns that '__gettextnerrs' set but not used: >> >>  intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used >>  [-Werror,-Wunused-but-set-variable] >>      int yynerrs = 0; >>        ^ >> >> Since the file is auto-generated, suppress the warning with a compiler >> flag. >> --- >> intl/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/intl/Makefile b/intl/Makefile >> index 315c75a18f..1c3b2a2273 100644 >> --- a/intl/Makefile >> +++ b/intl/Makefile >> @@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out >> $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out >> >> CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \ >> -        -D'LOCALE_ALIAS_PATH="$(localedir)"' >> +        -D'LOCALE_ALIAS_PATH="$(localedir)"' \ >> +        -Wno-unused-but-set-variable >> BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output >> >> $(inst_localedir)/locale.alias: locale.alias $(+force) >> --  >> 2.34.1 >> > > yynerrs is incremented but its value is unused. > Clang 15 (https://reviews.llvm.org/D122271) -Wunused-but-set-variable > gives a warning while GCC doesn't. > -Wunused-but-set-variable is available in GCC 4.6, smaller than the minimum required version 6.2. I will add this on commit message. > > Reviewed-by: Fangrui Song Thanks.