From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-59212-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 99631 invoked by alias); 24 May 2015 02:22:39 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 99453 invoked by uid 89); 24 May 2015 02:21:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Message-ID: <556135BA.6070705@redhat.com>
Date: Sun, 24 May 2015 03:43:00 -0000
From: "Carlos O'Donell" <carlos@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
        GNU C Library <libc-alpha@sourceware.org>,
        Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH] Use inline syscalls for non-cancellable versions
References: <555C97F7.1060700@linaro.org> <555E4B67.6000104@linaro.org>
In-Reply-To: <555E4B67.6000104@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2015-05/txt/msg00568.txt.bz2

On 05/21/2015 05:17 PM, Adhemerval Zanella wrote:
> On issue I found for this patchset is it fails for tile (and it is the
> only architecture I found that this warning shows) with:
> 
> --
> 
> malloc.c: In function ‘_int_free’:
> ../sysdeps/unix/sysv/linux/malloc-sysdep.h:51:35: error: ‘val’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>     may_shrink_heap = n > 0 && val == '2';
>                                    ^
> ../sysdeps/unix/sysv/linux/malloc-sysdep.h:49:9: note: ‘val’ was declared here
>     char val;
> 
> --
> 
> It is due the fact 'read_not_cancel' now calls the INLINE_SYSCALL for the
> architecture and so 'tile' version is triggering this issue for some reason
> (I did not check exactly why, any tile expert could help me out here?).
> 
> The straightforward fix would just initialize this variable, but this is
> just clobbering tile potential issue.  Any recommendations? 

Ask Chris Metcalf for help? :-)

Cheers,
Carlos.