From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-59292-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 64714 invoked by alias); 26 May 2015 13:24:59 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 64570 invoked by uid 89); 26 May 2015 13:24:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qg0-f48.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
         :cc:subject:references:in-reply-to:content-type
         :content-transfer-encoding;
        bh=ChJq7MmnM9l07bASK6+8lthUlB198D5RFzvQZy8tEZE=;
        b=QNMknf8jcu/ro9Obm2p2fT15wzsNKBWLhqIkPKnPQmY6TGsVJtlfErFVhMIXWAuuKI
         fOa6Wv+sYn0zgvFkAzPn6cWGMKV/Q+L5tw4xycbcyXp8C9uKGppaU3hzfqZsFNEOahcJ
         5K5TZzbIO4sm79DVTUrl1csz65A3AbFmg07HFsBYMAgWTcgUC2RU+qPnXrPi9s6yItBS
         EETqBtMa0upMH6Dd37IFlMeKOzmTOre8T37sLORNYJrNYBGdaRwsH0BwB+54piSoKtbR
         asbik90AeGqoKFQfrXgTQPsfjVIGxPjtETurky3wNLO3Q44JIpMfiERdgVOdtHGBhm6E
         is/A==
X-Gm-Message-State: ALoCoQm3PrpBM/N4WHzEsIhEWz+rwlaCgylKc15P0m/k4FcdGoap4Y/oC6Wh3NMY1Mp1RKbxhg4u
X-Received: by 10.140.33.21 with SMTP id i21mr13883637qgi.4.1432646690175;
        Tue, 26 May 2015 06:24:50 -0700 (PDT)
Message-ID: <5564741E.6000401@linaro.org>
Date: Tue, 26 May 2015 15:21:00 -0000
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Nathan Lynch <Nathan_Lynch@codesourcery.com>
CC: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 1/3] Consolidate vDSO macros and usage
References: <5550FEF5.3080202@linaro.org> <555B7625.1070801@codesourcery.com> <555B93A7.1020208@linaro.org> <555E01EF.2070606@codesourcery.com>
In-Reply-To: <555E01EF.2070606@codesourcery.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-05/txt/msg00648.txt.bz2



On 21-05-2015 13:03, Nathan Lynch wrote:
> On 05/19/2015 02:48 PM, Adhemerval Zanella wrote:
>>
>>
>> On 19-05-2015 14:43, Nathan Lynch wrote:
>>> On 05/11/2015 02:11 PM, Adhemerval Zanella wrote:
>>>> This patch consolidate the Linux vDSO define and usage across all ports
>>>> that uses it.  The common vDSO definitions and calling through
>>>> {INLINE/INTERNAL}_VSYSCALL macros are moved to a common header
>>>> sysdep-vdso.h and vDSO name declaration and prototype is defined
>>>> using a common macro.
>>>>
>>>> Also PTR_{MANGLE,DEMANGLE} is added to ports that does not use them
>>>> for vDSO calls (aarch64, powerpc, s390, and tile) and thus it will
>>>> reflect in code changes.  For ports that already implement pointer
>>>> mangling/demangling in vDSO system (i386, x32, x86_64) this patch
>>>> is mainly a code refactor.
>>>>
>>>> Checked on x32, x86_64, x32, ppc64le, and aarch64.  Ok to apply?
>>>>
>>>> Changes from previous version:
>>>>
>>>> - Rename INTERNAL_VSYSCALL_NCS to INTERNAL_VSYSCALL_CALL on all
>>>>   ports.
>>>
>>> I believe this series leaves a stray definition of INTERNAL_VSYSCALL_NCS
>>> in aarch64:
>>>
>>> /* List of system calls which are supported as vsyscalls.  */
>>> # define HAVE_CLOCK_GETRES_VSYSCALL     1
>>> # define HAVE_CLOCK_GETTIME_VSYSCALL    1
>>> # define HAVE_GETTIMEOFDAY_VSYSCALL     1
>>>
>>> # define INTERNAL_VSYSCALL_NCS(funcptr, err, nr, args...)       \
>>>
>>> Otherwise it looks fine to me and I have reworked the ARM VDSO support
>>> patch on top of it.
>>
>> Indeed, I will remove it.  Any more concerns about this patch?
> 
> I have none.  Thanks for doing this refactoring.
> 

Pushed as f534255e4d276ee7b20b45637d16a00b122e5df3 with stray INTERNAL_VSYSCALL_NCS
removed.