From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14594 invoked by alias); 26 May 2015 20:28:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 14583 invoked by uid 89); 26 May 2015 20:28:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f173.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=d3dGZxgckuAq1HnvnHQXP/MXwQlCfn9G9B5WAdYKvCY=; b=HzVJQbwC759/MQIon0Y6epGf+IpnfNhmMCNpm3ES+w/mB6ViUAciaQx8hmAU5t0XWm TtJM1pctZO+qmAiE++01BLR/+BfyylKhWwc1lhI2BrgZPifcPFcffWxJiNSdQ+I4ZzEk Vi8rNldMu92zADDo/0oXIk3rU5W5QWoPmiHgmMFpN1vK82Ucd5iObFb3gyMhYZ3DWEmN rGH6eEi8MCJ6IzIvs39o+sF43WhA/Eyd28NGlNAOD3ivU8ehtJzoNsEMaSR+jMmrAQwg ouhkn9+BA+o0r0IvoNykpJplurp0XzyBgrIRMwxt+QpasMWdHrmLd+LRk3zRxZVLBYc+ gx8g== X-Gm-Message-State: ALoCoQllvw0R6Z8gQdhBnuTnFuZcDZQAKnVstwJiL7oQeft8T8jeLNHLI6M6Sq+7R6sZHiZOVF8a X-Received: by 10.229.224.202 with SMTP id ip10mr37843601qcb.14.1432672131208; Tue, 26 May 2015 13:28:51 -0700 (PDT) Message-ID: <5564D77E.3060103@linaro.org> Date: Tue, 26 May 2015 22:17:00 -0000 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nathan Lynch CC: GNU C Library Subject: Re: [PATCH v3 2/3] Consolidate gettimeofday across aarch64/s390/tile References: <5550FEF8.50501@linaro.org> <555B7605.9040803@codesourcery.com> <555B940A.9040105@linaro.org> In-Reply-To: <555B940A.9040105@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00682.txt.bz2 On 19-05-2015 16:50, Adhemerval Zanella wrote: > > > On 19-05-2015 14:42, Nathan Lynch wrote: >> On 05/11/2015 02:11 PM, Adhemerval Zanella wrote: >>> This patch removes the architecture specific gettimeofday implementation >>> to use the vDSO symbol and consolidate it on a common Linux one. >>> Similat to gettime and getres vDSO implementation, each arch that supports >>> gettimeofday through vDSO should just implement INLINE_VSYSCALL to access >>> the symbol and define HAVE_GETTIMEOFDAY_VSYSCAL as 1. >>> >>> Tested on i386, x32, x86_64, ppc64le and aarch64. Ok to apply? >>> >>> Changes from previous version: >>> >>> - Fix SYSCALL spelling. >>> >>> -- >>> >>> * sysdeps/unix/sysv/linux/aarch64/gettimeofday.c: Remove file. >>> * sysdeps/unix/sysv/linux/s390/gettimeofday.c: Likewise. >>> * sysdeps/unix/sysv/linux/tile/gettimeofday.c: Likewise. >>> * sysdeps/unix/sysv/linux/aarch64/sysdep.h >>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Define. >>> * sysdeps/unix/sysv/linux/s390/s390-32/sysdep.h >>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >>> * sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h >>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >>> * sysdeps/unix/sysv/linux/tile/sysdep.h >>> [HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise. >>> * sysdeps/unix/sysv/linux/gettimeofday.c: New file: gettimeofday >>> using vDSO syscall macro. >>> >> >> With this change, do the #undefs in init-first.c (seen in aarch64, s390, >> powerpc, but not tile or x86) become unnecessary? >> >> # include >> # undef __gettimeofday >> # undef __clock_gettime >> # undef __clock_getres >> # include >> >> >> Otherwise looks fine to me. >> > > Indeed the #undef's are not really required any more and in my testing builds > aarch64, s390 and powerpc all built fine without. I will remove them. > > Any more concerns about it? I would like to install it. > Pushed as 97554e4382e5d85eccf146b58f85aaad7e3d687c