From: Martin Sebor <msebor@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] pthread_once hangs when init routine throws an exception [BZ #18435]
Date: Mon, 01 Jun 2015 16:27:00 -0000 [thread overview]
Message-ID: <556C8062.4010309@redhat.com> (raw)
In-Reply-To: <556C1A22.30504@redhat.com>
On 06/01/2015 02:38 AM, Florian Weimer wrote:
> On 05/31/2015 11:37 PM, Martin Sebor wrote:
>> The C++ 2011 std::call_once function is specified to allow
>> the initialization routine to exit by throwing an exception.
>> Such an execution, termed exceptional, requires call_once to
>> propagate the exception to its caller. A program may contain
>> any number of exceptional executions but only one returning
>> execution (which, if it exists, must be the last execution
>> with the same once flag).
>
> What do you propose as the commit message?
I usually repeat the ChangeLog entry in my commit messages
(included in the patch) but I'd be happy to add more detail
or change the format if there's a preference one way or the
other.
>
> It's not immediately obvious to me why this change works. :)
The pthread_cleanup_push and pthread_cleanup_pop macros are
defined in sysdeps/nptl/pthread.h. In C code outside of
glibc compiled with -fexceptions (with __EXCEPTIONS defined),
they make use of GCC attribute cleanup to invoke the cleanup
handler during stack unwinding. (In C++ they make use of
a destructor of a class object.) These macros do the right
thing when an exception is thrown in the code they surround.
The problem is that the nptl/pthreadP.h header redefines
the macros for internal use by glibc without the use of
the cleanup attribute. As a result, when an exception is
thrown, the cleanup handler is not invoked. This is what
happens in pthread_once.c.
By removing the macro redefinitions from nptl/pthreadP.h
the change causes pthread_once.c to be compiled with the
more robust macros defined in pthread.h and allows cleanup
to take place even after an exception has been thrown so
long as glibc has been compiled with -fexceptions.
Martin
next prev parent reply other threads:[~2015-06-01 15:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <556B7F10.40209@redhat.com>
2015-06-01 8:39 ` Florian Weimer
2015-06-01 16:27 ` Martin Sebor [this message]
2015-06-02 9:53 ` Mike Frysinger
2015-06-04 21:12 ` Martin Sebor
2015-06-03 11:36 ` Torvald Riegel
2015-06-01 10:20 ` Szabolcs Nagy
2015-06-01 19:47 ` Martin Sebor
2015-06-03 11:07 ` Torvald Riegel
2015-06-03 11:11 ` Jonathan Wakely
2015-06-03 20:14 ` Rich Felker
2015-06-03 20:24 ` Martin Sebor
2015-06-03 23:49 ` Rich Felker
2015-06-04 1:47 ` Martin Sebor
2015-06-04 5:38 ` Rich Felker
2015-06-04 7:29 ` Martin Sebor
2015-06-08 11:41 ` Jonathan Wakely
2015-06-08 14:38 ` Szabolcs Nagy
2015-06-04 8:20 ` Torvald Riegel
2015-06-08 11:48 ` Jonathan Wakely
2015-06-08 16:01 ` Florian Weimer
2015-06-03 11:07 ` Torvald Riegel
2015-06-01 14:39 ` Andreas Schwab
2015-06-09 19:49 ` Martin Sebor
2015-06-15 22:14 ` Martin Sebor
2015-06-23 7:48 ` [PING 2] " Martin Sebor
[not found] ` <5593256B.5060402@redhat.com>
2015-07-01 0:06 ` [PING 3] " Rich Felker
2015-07-01 20:18 ` Martin Sebor
2015-07-01 21:27 ` Joseph Myers
2015-07-06 13:18 ` Szabolcs Nagy
2015-07-06 14:16 ` Martin Sebor
2015-07-06 14:58 ` Adhemerval Zanella
2015-07-06 16:33 ` Szabolcs Nagy
2015-07-06 17:09 ` Szabolcs Nagy
2015-07-08 11:00 ` Szabolcs Nagy
2015-07-08 16:09 ` Carlos O'Donell
2015-07-08 16:33 ` Torvald Riegel
2015-07-08 16:52 ` Szabolcs Nagy
2015-07-08 17:14 ` Carlos O'Donell
2021-03-02 16:43 ` Jakub Jelinek
2015-07-08 16:16 ` Carlos O'Donell
2015-07-08 21:28 ` Martin Sebor
2015-07-08 22:13 ` Szabolcs Nagy
2015-07-08 22:52 ` Martin Sebor
2015-07-08 23:42 ` Szabolcs Nagy
2015-07-09 4:46 ` Martin Sebor
2015-07-09 23:41 ` Martin Sebor
2021-03-03 12:52 Jakub Jelinek
2021-03-04 11:50 ` Florian Weimer
2021-03-04 13:00 ` Jakub Jelinek
2021-03-04 13:26 ` Florian Weimer
2021-03-04 14:14 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C8062.4010309@redhat.com \
--to=msebor@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).