From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: PATCH] arm: Assembly implementation cleanup
Date: Mon, 06 Jul 2015 13:22:00 -0000 [thread overview]
Message-ID: <559A811D.6030406@linaro.org> (raw)
This patch removes arm assembly implementation of mmap and mmap64.
The new implementation used is the wordsize-32 generic linux one.
Tested on armhf.
--
* sysdeps/unix/sysv/linux/arm/mmap.c: Add file.
* sysdeps/unix/sysv/linux/arm/mmap.S: Remove file.
* sysdeps/unix/sysv/linux/arm/mmap64.S: Likewise.
--
diff --git a/sysdeps/unix/sysv/linux/arm/mmap.S b/sysdeps/unix/sysv/linux/arm/mmap.S
deleted file mode 100644
index 4fb5bf4..0000000
--- a/sysdeps/unix/sysv/linux/arm/mmap.S
+++ /dev/null
@@ -1,64 +0,0 @@
-/* Copyright (C) 1998-2015 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
- <http://www.gnu.org/licenses/>. */
-
-#include <sysdep.h>
-
-#define EINVAL 22
-
- .text
-
-ENTRY (__mmap)
- /* shuffle args */
- push { r5 }
- cfi_adjust_cfa_offset (4)
- cfi_rel_offset (r5, 0)
- ldr r5, [sp, #8]
- push { r4 }
- cfi_adjust_cfa_offset (4)
- cfi_rel_offset (r4, 0)
- cfi_remember_state
- ldr r4, [sp, #8]
-
- /* convert offset to pages */
- movs ip, r5, lsl #20
- bne .Linval
- mov r5, r5, lsr #12
-
- /* do the syscall */
- DO_CALL (mmap2, 0)
-
- /* restore registers */
-2:
- pop { r4 }
- cfi_adjust_cfa_offset (-4)
- cfi_restore (r4)
- pop { r5 }
- cfi_adjust_cfa_offset (-4)
- cfi_restore (r5)
-
- cmn r0, $4096
- it cc
- RETINSTR(cc, lr)
- b PLTJMP(syscall_error)
-
- cfi_restore_state
-.Linval:
- mov r0, #-EINVAL
- b 2b
-PSEUDO_END (__mmap)
-
-weak_alias (__mmap, mmap)
diff --git a/sysdeps/unix/sysv/linux/arm/mmap.c b/sysdeps/unix/sysv/linux/arm/mmap.c
new file mode 100644
index 0000000..2cb4907
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/arm/mmap.c
@@ -0,0 +1,18 @@
+/* Copyright (C) 2015 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c>
diff --git a/sysdeps/unix/sysv/linux/arm/mmap64.S b/sysdeps/unix/sysv/linux/arm/mmap64.S
deleted file mode 100644
index d574df0..0000000
--- a/sysdeps/unix/sysv/linux/arm/mmap64.S
+++ /dev/null
@@ -1,72 +0,0 @@
-/* Copyright (C) 2000-2015 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
- <http://www.gnu.org/licenses/>. */
-
-#include <sysdep.h>
-
- .syntax unified
-
-#define EINVAL 22
-
-#ifdef __ARMEB__
-# define LOW_OFFSET 8 + 4
-/* The initial + 4 is for the stack postdecrement. */
-# define HIGH_OFFSET 4 + 8 + 0
-#else
-# define LOW_OFFSET 8 + 0
-# define HIGH_OFFSET 4 + 8 + 4
-#endif
-
- /* The mmap2 system call takes six arguments, all in registers. */
- .text
-ENTRY (__mmap64)
- ldr ip, [sp, $LOW_OFFSET]
- push { r5 }
- cfi_adjust_cfa_offset (4)
- cfi_rel_offset (r5, 0)
- ldr r5, [sp, $HIGH_OFFSET]
- push { r4 }
- cfi_adjust_cfa_offset (4)
- cfi_rel_offset (r4, 0)
- cfi_remember_state
- movs r4, ip, lsl $20 @ check that offset is page-aligned
- mov ip, ip, lsr $12
- it eq
- movseq r4, r5, lsr $12 @ check for overflow
- bne .Linval
- ldr r4, [sp, $8] @ load fd
- orr r5, ip, r5, lsl $20 @ compose page offset
- DO_CALL (mmap2, 0)
- cmn r0, $4096
- pop {r4, r5}
- cfi_adjust_cfa_offset (-8)
- cfi_restore (r4)
- cfi_restore (r5)
- it cc
- RETINSTR(cc, lr)
- b PLTJMP(syscall_error)
-
- cfi_restore_state
-.Linval:
- mov r0, $-EINVAL
- pop {r4, r5}
- cfi_adjust_cfa_offset (-8)
- cfi_restore (r4)
- cfi_restore (r5)
- b PLTJMP(syscall_error)
-PSEUDO_END (__mmap64)
-
-weak_alias (__mmap64, mmap64)
next reply other threads:[~2015-07-06 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 13:22 Adhemerval Zanella [this message]
2015-07-09 18:58 ` Adhemerval Zanella
2015-07-22 13:43 ` Joseph Myers
2015-08-05 14:20 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A811D.6030406@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).