Re: [PATCH 3/6] sysvipc: Fix IPC_INFO and MSG_INFO handling [BZ #26639]

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 29/09/2020 10:01, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> On 29/09/2020 09:37, Adhemerval Zanella wrote:
>>>
>>>
>>> On 29/09/2020 04:57, Florian Weimer wrote:
>>>> * Adhemerval Zanella via Libc-alpha:
>>>>
>>>>> +static int
>>>>> +read_proc_file (const char *file)
>>>>> +{
>>>>> +  FILE *f = fopen (file, "r");
>>>>> +  if (f == NULL)
>>>>> +    return -1;
>>>>> +
>>>>> +  int v;
>>>>> +  int r = fscanf (f, "%d", & v);
>>>>> +  TEST_VERIFY_EXIT (r == 1);
>>>>> +
>>>>> +  fclose (f);
>>>>> +  return v;
>>>>> +}
>>>>
>>>> You could use xfopen and xfclose.
>>>
>>> Indeed, I will change it.
>>
>> In fact I though about it before and for this test we do want to 
>> check if the /proc file is accessible and just check against the 
>> tunable value if it were the case.  Otherwise the test will always
>> fail if /proc is not mounted (not really the expected scenario I 
>> give you).
> 
> Maybe add FAIL_UNSUPPORTED for this case at the start of the test?

I don't have a strong opinion, I will add the FAIL_UNSUPPORTED for
case /proc is not accessible then.