From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "peterz@infradead.org" <peterz@infradead.org>
Cc: "xry111@xry111.site" <xry111@xry111.site>,
"andrealmeid@igalia.com" <andrealmeid@igalia.com>,
"fweimer@redhat.com" <fweimer@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: Several tst-robust* tests time out with recent Linux kernel
Date: Wed, 15 Nov 2023 23:28:00 +0000 [thread overview]
Message-ID: <564119521b61b5a38f9bdfe6c7a41fcbb07049c9.camel@intel.com> (raw)
In-Reply-To: <20231115085102.GY3818@noisy.programming.kicks-ass.net>
On Wed, 2023-11-15 at 09:51 +0100, Peter Zijlstra wrote:
> On Wed, Nov 15, 2023 at 01:11:20AM +0000, Edgecombe, Rick P wrote:
> > On Tue, 2023-11-14 at 21:14 +0100, Peter Zijlstra wrote:
> > > Urgh, thanks!
> > >
> > > Confirmed, the below cures things. Although I should probably
> > > make
> > > that
> > > FLAGS_SIZE_32 | FLAGS_SHARED against Linus' tree.
> > >
> > > Let me go do a proper patch.
> >
> > I saw these fail on the glibc shadow stack branch today, and I also
> > saw
> > this one failing:
> > FAIL: nptl/tst-robustpi8
>
> tip/locking/urgent (branch with the fix on) gets me:
>
> root@ivb-ep:/usr/local/src/glibc# ./build/nptl/tst-robustpi8
> running child
> verifying locks
> running child
> verifying locks
> running child
> verifying locks
> running child
> verifying locks
> running child
> verifying locks
> root@ivb-ep:/usr/local/src/glibc#
>
> Which, to my untrained eye, looks like a pass to me.
It bisects to this for me:
fbeb558b0dd0 ("futex/pi: Fix recursive rt_mutex waiter state")
Reading the patch, I'm not immediately clear what is going on but a few
comments stood out: "There be dragons here" "What could possibly go
wrong..." "This is a somewhat dangerous proposition".
Seems a likelihood of some race, but it reproduces reliably on my
machine. Haven't dug into debugging it yet. Any pointers?
next prev parent reply other threads:[~2023-11-15 23:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 18:33 Xi Ruoyao
2023-11-14 9:46 ` Xi Ruoyao
2023-11-14 15:31 ` Peter Zijlstra
2023-11-14 15:40 ` Peter Zijlstra
2023-11-14 16:43 ` Florian Weimer
2023-11-14 20:14 ` Peter Zijlstra
2023-11-15 1:11 ` Edgecombe, Rick P
2023-11-15 8:51 ` Peter Zijlstra
2023-11-15 23:28 ` Edgecombe, Rick P [this message]
2023-11-17 1:22 ` Edgecombe, Rick P
2024-01-19 13:56 ` Stefan Liebler
2024-01-22 14:34 ` Stefan Liebler
2024-01-29 22:23 ` Edgecombe, Rick P
2024-01-30 10:12 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564119521b61b5a38f9bdfe6c7a41fcbb07049c9.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=andrealmeid@igalia.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).