From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57319 invoked by alias); 23 Sep 2019 17:54:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57310 invoked by uid 89); 23 Sep 2019 17:54:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 4/6] [powerpc] libc_feholdsetround_noex_ppc_ctx: optimize FPSCR write To: Paul E Murphy , libc-alpha@sourceware.org Cc: tuliom@ascii.art.br References: <1568918810-20393-1-git-send-email-pc@us.ibm.com> <1568918810-20393-5-git-send-email-pc@us.ibm.com> <943be10e-497d-1066-42cf-12164c71ed28@linux.ibm.com> From: Paul Clarke Message-ID: <5651ac5e-8b7e-3596-b7c9-617cae7dea3f@us.ibm.com> Date: Mon, 23 Sep 2019 17:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <943be10e-497d-1066-42cf-12164c71ed28@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-09/txt/msg00364.txt.bz2 Thanks for the review, Paul! Question... On 9/23/19 10:54 AM, Paul E Murphy wrote: > On 9/19/19 1:46 PM, Paul A. Clarke wrote: >> libc_feholdsetround_noex_ppc_ctx currently does, basically: > The listing reads awkwardly for me. I suggest a little cleanup. There is no need to post a new patch against my suggestion. Here you say "listing", and there is a list (1-2-3) immediately below this text, and below you say "commit message", . Where would you like to see improvement? Happy to change, but it's hard for me to see what you're seeing. (And, of course, it's all perfectly clear to me since I wrote it! ;-) >> 1. Read FPSCR, save to context. >> 2. Create new FPSCR value: clear enables and set new rounding mode. >> 3. Write new value to FPSCR. >> >> Since other bits just pass through, there is no need to write them. >> >> Instead, write just the changed values (enables and rounding mode), >> which can be a bit more efficient. >> >> 2019-09-19  Paul A. Clarke  >> >>     * sysdeps/powerpc/fpu/fenv_private.h >>     (libc_feholdsetround_noex_ppc_ctx): Call fesetenv_mode instead >>     of fesetenv_register. >> --- >> v2: No change. >> >>   sysdeps/powerpc/fpu/fenv_private.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sysdeps/powerpc/fpu/fenv_private.h b/sysdeps/powerpc/fpu/fenv_private.h >> index 9496026..ade0bfa 100644 >> --- a/sysdeps/powerpc/fpu/fenv_private.h >> +++ b/sysdeps/powerpc/fpu/fenv_private.h >> @@ -142,7 +142,7 @@ libc_feholdsetround_noex_ppc_ctx (struct rm_ctx *ctx, int r) >>     if (__glibc_unlikely (new.l != old.l)) >>       { >>         __TEST_AND_ENTER_NON_STOP (old.l, 0ULL); >> -      fesetenv_register (new.fenv); >> +      fesetenv_mode (new.fenv); >>         ctx->updated_status = true; >>       } >>     else >> > > OK, with suggested cleanup to commit message. > > Reviewed-By: Paul E Murphy PC