From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 47D853858401 for ; Thu, 18 May 2023 12:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47D853858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-394690088acso1484560b6e.0 for ; Thu, 18 May 2023 05:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684413449; x=1687005449; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ickatd2inyxP5YESGVPNHcAeXCCfxuxr2Rd2weFNSB8=; b=s86DGmQj4d4xImZPy6xFWvWEUj10FYHX9xjl6w0UatFMCerK99tME8mnbzgJfIF+e8 kVPGtXvLG5dq9XxSBu8U40f48hHbQH5v14uUxa9GRO1wyMxoBLNoOn6QOsjiMWKpUC2G 8IpLtjV+WhfYNVmn4j2q4eBrTyBp9jHfgvf1C9vXmkkTcgsI+Y/cRNkZIBjHRv0YP4aL cB3K1IwjF38Gd76XlzYgp5v6aspDIMIXGIRfnlzbLoctG0SNRBlO25MUC058Qk9bywpv /gJ6+9kEV2vbyXRUcUPMgGCh2+vnO299Zw2OWovWIktEm4xA9kvpjjNYk1zzhi0RCfKm T2Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684413449; x=1687005449; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ickatd2inyxP5YESGVPNHcAeXCCfxuxr2Rd2weFNSB8=; b=CqLAGTxivMt5PzXGYTU80nES0MFrZgjIrBbdkDw6LjZllsswF7W7UNsPV/88fNQw8V mW84mQ/JnCnwFNECt0wsgjJLarG+kPK9FL9AxqZwfTgUdfb5c9tweH36a3JsQCNcEKdv sQ5U8ZmrXZSI0WQS34Qk4yWFdt4A8pF5AcipmVfDtSGoFiw0bM0hGHN1H73lLBF3+NX1 9/rWHx59SjOws0pLr0LhjZBDNx3ZQIEgCCozg5cPLgo+06El43Y9y3ey3jqcqectsD5K jREM0Lx1ejYKRf14DKJQrXiICVAe4cyxs4ncd4Qf3LLXS7LN3DLu+EOwDOb9cFR/lt8W w/Hw== X-Gm-Message-State: AC+VfDwKufu7URJKrfcvXwABxdWrmBsNwk5ciQ9wY558Ag9uR0TpNMxv c8pfVK9g1nPSWevk7yi9ec9gPw== X-Google-Smtp-Source: ACHHUZ5HzDvV+dPfzrFl6QRZisxBM93CU0sLVUghrk6lTRHmU5XkCka2GDGYNkd1veibhdf06zfzxw== X-Received: by 2002:a05:6808:1818:b0:395:de70:a268 with SMTP id bh24-20020a056808181800b00395de70a268mr1035155oib.38.1684413449580; Thu, 18 May 2023 05:37:29 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c914:a525:210b:3f9e:9366? ([2804:1b3:a7c0:c914:a525:210b:3f9e:9366]) by smtp.gmail.com with ESMTPSA id x12-20020a05680801cc00b00397bc1af159sm134262oic.18.2023.05.18.05.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 05:37:28 -0700 (PDT) Message-ID: <5697b425-a56e-9e12-08fd-ad48ded9c0f1@linaro.org> Date: Thu, 18 May 2023 09:37:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Remove last remnants of have-protected Content-Language: en-US To: Andreas Schwab , libc-alpha@sourceware.org References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks. Reviewed-by: Adhemerval Zanella On 08/05/23 11:02, Andreas Schwab via Libc-alpha wrote: > --- > sysdeps/hppa/Makefile | 3 --- > sysdeps/powerpc/powerpc32/Makefile | 3 --- > sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +--- > 3 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile > index 9531504c4b..b7765c31ec 100644 > --- a/sysdeps/hppa/Makefile > +++ b/sysdeps/hppa/Makefile > @@ -30,9 +30,6 @@ endif > ifeq ($(subdir),csu) > ifeq (yes,$(build-shared)) > # Compatibility > -ifeq (yes,$(have-protected)) > -CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN > -endif > sysdep_routines += libgcc-compat > shared-only-routines += libgcc-compat > endif > diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile > index cf620c8269..1fff5b83bf 100644 > --- a/sysdeps/powerpc/powerpc32/Makefile > +++ b/sysdeps/powerpc/powerpc32/Makefile > @@ -35,9 +35,6 @@ CFLAGS-gmon-start.o = -G0 > > ifeq (yes,$(build-shared)) > # Compatibility > -ifeq (yes,$(have-protected)) > -CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN > -endif > sysdep_routines += libgcc-compat > shared-only-routines += libgcc-compat > endif > diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S > index ffa8f0a44a..6beac24039 100644 > --- a/sysdeps/powerpc/powerpc32/libgcc-compat.S > +++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S > @@ -36,20 +36,18 @@ > .symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0 > #endif > > -#ifdef HAVE_DOT_HIDDEN > .hidden __ashldi3 > .hidden __ashrdi3 > .hidden __lshrdi3 > .hidden __cmpdi2 > .hidden __ucmpdi2 > -# if !defined _SOFT_FLOAT && !defined __NO_FPRS__ > +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__ > .hidden __fixdfdi > .hidden __fixsfdi > .hidden __fixunsdfdi > .hidden __fixunssfdi > .hidden __floatdidf > .hidden __floatdisf > -# endif > #endif > > .section ".text"