From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107193 invoked by alias); 2 Feb 2016 12:46:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 107172 invoked by uid 89); 2 Feb 2016 12:46:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-MS-Exchange-CrossTenant-FromEntityHeader:Hosted X-HELO: eu-smtp-delivery-143.mimecast.com Message-ID: <56B0A530.5090508@arm.com> Date: Tue, 02 Feb 2016 12:46:00 -0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Florian Weimer , Adhemerval Zanella CC: Joseph Myers , , Subject: Re: [PATCH v2 1/3] posix: Remove dynamic memory allocation from execl{e,p} References: <1454343665-1706-1-git-send-email-adhemerval.zanella@linaro.org> <1454343665-1706-2-git-send-email-adhemerval.zanella@linaro.org> <56AF936C.6070907@linaro.org> <56B09201.4010502@redhat.com> In-Reply-To: <56B09201.4010502@redhat.com> X-ClientProxiedBy: DB3PR08CA0014.eurprd08.prod.outlook.com (25.161.51.152) To DB5PR08MB0840.eurprd08.prod.outlook.com (25.164.43.18) X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0840;2:cUyXrcKAYmq8S8sZNuQWmEX7a6SXiyC/IaxWsn+FVpIifY8IlZIQgZiQ5c7LjyucR5zI4ViLav9z/fb8sKt8cryD1WXo3Y/Ok6KKxHRJTqmtsEqRx0pucKOqPq/yN8e9J/2seyF5SZiL+IW/eriM0A==;3:S+aoiJ1tYObGuarkH113S/WzjOHNwe/swaOFkEJyDIqi3XHqjDwaWXAtOyPOMKwHMi9cR6ZuCYywIy53++jWCoqKq3pjUQ3Jt1FsUuUIHkh20gQjhBOxqKNA1vdp0Sk3;25:r2kdsOfq5agEE1o+giRfhbT8QBk8rJEl3mPh8N2hiLkMPlGyyLJPZGn6MOzxu7YP3uaFnHlAJ8G5W9/eHgYPo3E0UOTW7sFKKqDLTfZ0TMM5GMWtpbU89IlYRXaoIIeicjoQN7+ynGy6J61z+qbydqE5pn+yUqOdM3+y93eC33MIzNQoKPrkOsTc56h/y0yJRHyAxuTxXVxWHcE5V952wlHTtWs4fdlHXq5M7rGb5EOW+r0CG/Sgs5UI3SBTm7KV;20:lfMfymH9aDUJ1X41htW4q5HJv8z9ZpnwACGql3VLHip4EWRP6auSsu1lo1X7p+aWFyEL1E2QYNhsKvEi3N+7TJNTMIzK13GnncHWeOi0jdXATOTvaSQXPOvjfDuP+MzcpAzGUWchKCzeLn6v/jo+cC4yiH8ACKfQw3RR/F4cV+w= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0840; X-MS-Office365-Filtering-Correlation-Id: e22a427a-14ef-4f45-ec03-08d32bcee756 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DB5PR08MB0840;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0840; X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0840;4:amYCdmAR9iuBUQEhHe+KKrfnjsGak9BE9OHJocdPvsuSrp843bR92MyZ9HaKb3kw3aqNSEYK9yPCRrAETxhf8sAbVYD769EKKnhuBY+krsdi0Zkdf7ERTy4+VrcwE11ZUMUpoxot0ZgWLYoyADzULRMIVP63Ehb+UcARoCt9EXHiT+H4OHe/NUKDe/Rl6uAdJKU30REPnX82ZaYv5XOn0rMbNxQpdSkAcZg8DRQr2ov3NutdqYwReVpSLUsDaZrmg+Zn5r5hTqmdELxK9j89OUbEjzTrauYznTb9wNotNXb3haupKZlLm71NARdAUWjmz1GMvKTRJuUuah8mh8MM+4xfsWZJhw60y+n0v44zSjEKx/ydfaKbSpXZazJlug5o X-Forefront-PRVS: 084080FC15 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(479174004)(377454003)(51444003)(57704003)(24454002)(80316001)(59896002)(47776003)(65956001)(65806001)(92566002)(66066001)(42186005)(83506001)(33656002)(86362001)(40100003)(50466002)(4326007)(5001960100002)(5008740100001)(3470700001)(122386002)(93886004)(36756003)(76176999)(189998001)(54356999)(50986999)(65816999)(230700001)(87266999)(2906002)(1096002)(586003)(6116002)(4001350100001)(87976001)(5004730100002)(23746002)(2950100001)(5001770100001)(77096005)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR08MB0840;H:[10.2.206.73];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB5PR08MB0840;23:jorRXVIsPaUTIzzdfXhXZAFgomwu8As5mOeE4?= =?Windows-1252?Q?uA5ZG5tCb7JfcpoytNCkgZ9D26IsdP4FrJ8MsN+yNP7yI1XXrN0cYiqr?= =?Windows-1252?Q?UMEvd3lcKfLIeZM0gbZa78sAA3CgRJmoHWqNe5WRnWXlp/sH92wS3Xq0?= =?Windows-1252?Q?gfhT9uW0aplOJz9cecDZb0us9I6WHi2O9M9qyd55aOhFpdsPDLFlKRVD?= =?Windows-1252?Q?YlDhoMKhcmRyaq79OsveFYFflQb6Fr4mSknHNEizDByt+zkzAM1NDI7a?= =?Windows-1252?Q?x32urdylBIOGMUNKRq1o6EfeaMOarnjycU37JLbRQOfweZinq/l54S6P?= =?Windows-1252?Q?zcJQKBOMLJvlaOlEj3BEaB3QSV9To6kQINge6QX1GHESsq9majdYNyQq?= =?Windows-1252?Q?+vbkb+mJ0b4B5Zp41bYgiYU2kd5rDDpbMEC7tcLyLsjf0KCkWSVXvJve?= =?Windows-1252?Q?qj+zkK4FRp5sULqaddmf8z2RXOvhDkHnp6xWInVqOVgpdNwJK2UlOcyT?= =?Windows-1252?Q?a8FxqwOahcU2tXFYFmccfqo0CtB42ZL0mxkWTfjFCqv1sA0wc9FIUypq?= =?Windows-1252?Q?7evJaVzpcyNFbyb+MjcCE4FQimOKpQ40qrY3VayfrMJ93/gYlgDIsFal?= =?Windows-1252?Q?uEiO7hzbuNjaJSII+GE3qU9fLbptxoIz7GeZi1Gld5L7AMoYhPzAg13x?= =?Windows-1252?Q?zhlPTjH3odrq+mXK1xbp8Mn4ByboDO3TlBCrHNKK3GmdVAW9YFyYORgq?= =?Windows-1252?Q?8/dG70/tnm2MF4K6OyVXFZ1vt5UkiG9hOYO05eXCocWcgWWVKA8qaSGm?= =?Windows-1252?Q?sFCgNC60NfwR1s98FM/f4fwiJGMj+0rN+66/vmn4ZBVqMxFuXtDaVh+x?= =?Windows-1252?Q?wO+01UQGfDzgsuPpyZ5kW++/3hgOotR+Ium3x262MLFh2Ecgicv1Ve41?= =?Windows-1252?Q?xAVVsDBFErzzBeeqLhqgfRzZbRrnmGlF36b9smciVrLP4+HF1UOxLvnX?= =?Windows-1252?Q?8eSQzm4nPHmXlfF9Xa2YuyGTDqBuxFT/qyjWJ1g6lNAx9rlcle3+ohk4?= =?Windows-1252?Q?onnF28ddxy5LwpNQHqZne7shexN4GDc+D7QoGt9L0PRIsgymy9UAk2a0?= =?Windows-1252?Q?93LZS2Mfu2JQkczQkzoCBqiAu9UTrbP5kILRdKYV2Njo5XI+M5BF/ffr?= =?Windows-1252?Q?75/2gPz5lmTFrHC53ai7MVGPNO7XRikicsylMAHeaJP7bhLDVzHDrD8c?= =?Windows-1252?Q?GoroUW9RLvIvOZ0uc77qfAVFAsBSlUPOGuhNAKTJt5gtoIhWfZ4QhjKy?= =?Windows-1252?Q?Q8F?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR08MB0840;5:ykVWB2x5vYgr7rha54nreb6a+PWYKvPFL41x+qqXgUReMUjzZxSLwFCVp34D7pfgBmi+2600TPZ503PClMF1QnrDoTcB7ASxGjpuxtf74VSM2TVuVsXxU16ay4WfV+1wFi1HPrzXOwcfUSY9kcLKcQ==;24:a+8QzNVF+NDIAaAk09HAOh20CEBd0GmrQbGmBNP1BBQpW85+uC2wum3M7Y4WqhAX9sRsEgq63UI0WJkv4mf5axCaYWekyNaRkc4bG9AayiE=;20:UOO7k4Xxtm4s5nkTIN+viAQNOtoCHWA2VuBFm5kWzjdTuZhvQPOL7f8iwMkoV65913USBPDACNCcdpeAeVwpIUYjEJJBYVRAuUMfXSlA5Mx8nGZAvYS2BFceLxaGdLkbCTblrnZdYmCzkPdwnMYrN0+KpjcUWMaH1E6ozDnyGjo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2016 12:46:42.9956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0840 X-MC-Unique: 39jGXvZJTb6-JhtnC8UryA-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2016-02/txt/msg00039.txt.bz2 On 02/02/16 11:24, Florian Weimer wrote: > On 02/01/2016 06:18 PM, Adhemerval Zanella wrote: >=20 >> Right, it is not ensuring the safeness. Is '-fstack-check' the suffice=20 >> option to ensure it or do we need a more strict one? >=20 > In my tests, the initial stack banging probe is sometimes more than a > page away from the current stack pointer, so it does not look safe to me. i think that can be fixed by memset(argv, 0, sizeof argv); even if it clobbers other threads it will hit the guard page eventually.