From: "Carlos O'Donell" <carlos@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Jakub Jelinek <jakub@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
Date: Tue, 09 Feb 2016 17:38:00 -0000 [thread overview]
Message-ID: <56BA240E.2080405@redhat.com> (raw)
In-Reply-To: <20160209172356.GC8441@redhat.com>
On 02/09/2016 12:23 PM, Jonathan Wakely wrote:
> On 03/02/16 16:04 -0200, Adhemerval Zanella wrote:
>>
>>
>> On 03-02-2016 15:40, Mike Frysinger wrote:
>>> On 03 Feb 2016 14:55, Adhemerval Zanella wrote:
>>>> I will quote the email referenced:
>>>>
>>>>> C++11 code using isinf and isnan continues to compile after that
>>>>> change, because the C++11 standard library provides its own versions
>>>>> conforming to the C++11 requirements. However, the C++11 library
>>>>> doesn't provide isinff, isinfl etc. and so code using those
>>>>> (non-standard) functions will no longer compile if they are not
>>>>> declared by glibc.
>>>>
>>>> This was not clear to me, what kind of build issue are you seeing now?
>>>> Using isinf{f,l} by including just <cmath> along with C++11? If it is the
>>>> case please open a bugzilla (or update the original) and please commit
>>>> the fix.
>>>
>>> if the change hasn't seen a release yet, then we can just re-use the
>>> existing bug since it's really just a direct follow up to that ?
>>> -mike
>>>
>>
>> I do not see why not.
>
> Hi, what's the status of this then - do we need to add a testcase or
> can it be committed for 2.23? (or wait for 2.24?)
Yes, we want always want a test case. It's perfectly fine to use C++
in tests in glibc, and if the C++ compiler isn't present those tests
should become UNSUPPORTED tests, which is OK (when bootstrapping).
In summary:
- Add C++ test.
- Use BZ #19439 and provide ChangeLog.
- Post v2
I'll review it and commit, or someone else will.
Cheers,
Carlos.
next prev parent reply other threads:[~2016-02-09 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 16:22 Jakub Jelinek
2016-02-01 16:34 ` Jonathan Wakely
2016-02-03 16:56 ` Adhemerval Zanella
2016-02-03 17:15 ` Jonathan Wakely
2016-02-03 17:29 ` Jakub Jelinek
2016-02-03 17:40 ` Mike Frysinger
2016-02-03 18:04 ` Adhemerval Zanella
2016-02-09 17:24 ` Jonathan Wakely
2016-02-09 17:38 ` Carlos O'Donell [this message]
2016-02-09 21:54 ` Carlos O'Donell
2016-02-10 16:30 ` Adhemerval Zanella
2016-02-15 1:20 ` Carlos O'Donell
2016-02-23 15:32 ` Andreas Schwab
2016-02-23 15:41 ` Jakub Jelinek
2016-02-23 17:41 ` Carlos O'Donell
2016-02-24 8:59 ` Andreas Schwab
2016-02-24 9:39 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA240E.2080405@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).