From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92725 invoked by alias); 7 Mar 2016 15:58:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 92704 invoked by uid 89); 7 Mar 2016 15:58:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=silence, tend, 19633, strfmon_l X-HELO: mx1.redhat.com Subject: Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633] To: carlos@redhat.com, Martin Sebor References: <56CF62D0.8060803@redhat.com> <56CF7D30.2090000@redhat.com> <56DD80AF.3000408@redhat.com> <56DD9E1C.5030408@redhat.com> Cc: GNU C Library From: Florian Weimer Message-ID: <56DDA516.4090509@redhat.com> Date: Mon, 07 Mar 2016 15:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56DD9E1C.5030408@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00156.txt.bz2 On 03/07/2016 04:28 PM, Carlos O'Donell wrote: > I tend to agree with Martin here, having that separation between > test and data makes it easier to read and change the test or add > more tests. > > If you're getting a warning from the compiler you expect but don't > care about then you can just silence the warning with the appropriate > attribute? The warning is not enabled by default (or even -W), so I'm not sure if that's even necessary. What's your opinion on the separate static test? Should I include it? Thanks, Florian