From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57841 invoked by alias); 25 Mar 2016 10:40:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57787 invoked by uid 89); 25 Mar 2016 10:40:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Verify, zmm, ymm, Hx-languages-length:1039 X-HELO: mx1.redhat.com Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h To: Florian Weimer , "H.J. Lu" References: <1457049161-13783-1-git-send-email-hjl.tools@gmail.com> <20160311214735.4CAE52C3C21@topped-with-meat.com> <20160311220031.3A5672C3BC5@topped-with-meat.com> <20160311222939.654342C3C24@topped-with-meat.com> <874mcc636j.fsf@mid.deneb.enyo.de> <20160311225548.C6A7E2C3C24@topped-with-meat.com> <87y49o4ntk.fsf@mid.deneb.enyo.de> Cc: Roland McGrath , GNU C Library From: Florian Weimer Message-ID: <56F5158A.5040302@redhat.com> Date: Fri, 25 Mar 2016 10:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87y49o4ntk.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00627.txt.bz2 On 03/12/2016 12:06 AM, Florian Weimer wrote: > This would seem more reasonable: > > diff --git a/sysdeps/x86_64/tst-audit10.c b/sysdeps/x86_64/tst-audit10.c > index a487b40..0df2275 100644 > --- a/sysdeps/x86_64/tst-audit10.c > +++ b/sysdeps/x86_64/tst-audit10.c > @@ -17,13 +17,13 @@ > . */ > > #include > -#include > > int tst_audit10_aux (void); > > static int > avx512_enabled (void) > { > +#ifdef bit_AVX512F > unsigned int eax, ebx, ecx, edx; > > if (__get_cpuid (1, &eax, &ebx, &ecx, &edx) == 0 > @@ -38,6 +38,9 @@ avx512_enabled (void) > > /* Verify that ZMM, YMM and XMM states are enabled. */ > return (eax & 0xe6) == 0xe6; > +#else > + return 0; > +#endif > } > > static int I have committed this, after testing compilation with GCC 4.7 and GCC 5.3. Bug 19860 mentions a second compilation error, which I did not see. I'm waiting for details on that one, maybe it was a spurious issue. Florian