From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879]
Date: Tue, 29 Mar 2016 13:49:00 -0000 [thread overview]
Message-ID: <56FA87E8.5050908@redhat.com> (raw)
In-Reply-To: <56FA607D.4070803@redhat.com>
On 03/29/2016 07:01 AM, Florian Weimer wrote:
> This is a minor security issue in nss_dns, triggered by a very long name
> passed to getnetbyname.
>
> The defensive copy is not needed because the name may not alias the
> output buffer.
This code dates back to the original 1996 sources that were included in glibc
and I expect that at that point the propagation of `const char *` for name
was not entirely complete and that at some point the internals assumed they
could scribble on name. That is not the case today, we propagate `const char *`
to all callers, and a rather deep review that I just did using ctags shows
that the call tree preserves the constness of name.
This patch looks good to me.
> 2016-03-29 Florian Weimer <fweimer@redhat.com>
>
> [BZ #19879]
> CVE-2016-3075
> * resolv/nss_dns/dns-network.c (_nss_dns_getnetbyname_r): Do not
> copy name.
>
> diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c
> index 2eb2f67..8f301a7 100644
> --- a/resolv/nss_dns/dns-network.c
> +++ b/resolv/nss_dns/dns-network.c
> @@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result,
> } net_buffer;
> querybuf *orig_net_buffer;
> int anslen;
> - char *qbuf;
> enum nss_status status;
>
> if (__res_maybe_init (&_res, 0) == -1)
> return NSS_STATUS_UNAVAIL;
>
> - qbuf = strdupa (name);
> -
> net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024);
>
> - anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf,
> + anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf,
> 1024, &net_buffer.ptr, NULL, NULL, NULL, NULL);
> if (anslen < 0)
> {
--
Cheers,
Carlos.
next prev parent reply other threads:[~2016-03-29 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 11:01 Florian Weimer
2016-03-29 13:49 ` Carlos O'Donell [this message]
2016-03-29 21:41 ` Joseph Myers
2016-04-29 8:49 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FA87E8.5050908@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).