public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [microblaze] Remove __ASSUME_FUTIMESAT
@ 2016-03-22 21:42 Joseph Myers
  2016-03-29 21:24 ` Ping " Joseph Myers
  0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2016-03-22 21:42 UTC (permalink / raw)
  To: libc-alpha

MicroBlaze has a special version of futimesat.c because it gained the
futimesat syscall later than other non-asm-generic architectures.  Now
the minimum kernel is recent enough that this syscall can always be
assumed to be present for MicroBlaze, so this patch removes the
special version and the __ASSUME_FUTIMESAT macro, resulting in the
sysdeps/unix/sysv/linux/futimesat.c version being used.

Untested.

2016-03-22  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/unix/sysv/linux/microblaze/kernel-features.h
	(__ASSUME_FUTIMESAT): Remove macro.
	* sysdeps/unix/sysv/linux/microblaze/futimesat.c: Remove file.

diff --git a/sysdeps/unix/sysv/linux/microblaze/futimesat.c b/sysdeps/unix/sysv/linux/microblaze/futimesat.c
deleted file mode 100644
index 9ce6190..0000000
--- a/sysdeps/unix/sysv/linux/microblaze/futimesat.c
+++ /dev/null
@@ -1,30 +0,0 @@
-/* Implement futimesat for MicroBlaze.
-   Copyright (C) 2014-2016 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <http://www.gnu.org/licenses/>.  */
-
-/* MicroBlaze always had the utimensat syscall but gained the
-   futimesat syscall later, so use the linux-generic implementation of
-   futimesat in terms of the utimensat syscall unless the futimesat
-   syscall is known to be available.  */
-
-#include <kernel-features.h>
-
-#ifdef __ASSUME_FUTIMESAT
-# include <sysdeps/unix/sysv/linux/futimesat.c>
-#else
-# include <sysdeps/unix/sysv/linux/generic/futimesat.c>
-#endif
diff --git a/sysdeps/unix/sysv/linux/microblaze/kernel-features.h b/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
index 3938989..a331b9f 100644
--- a/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
@@ -41,9 +41,6 @@
 /* Support for the accept4 and recvmmsg syscalls was added in 2.6.33.  */
 #define __ASSUME_RECVMMSG_SYSCALL_WITH_SOCKETCALL      1
 
-/* Support for the futimesat syscall was added in 2.6.33.  */
-#define __ASSUME_FUTIMESAT              1
-
 #include_next <kernel-features.h>
 
 /* Support for the pselect6, preadv and pwritev syscalls was added in

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Ping Re: [microblaze] Remove __ASSUME_FUTIMESAT
  2016-03-22 21:42 [microblaze] Remove __ASSUME_FUTIMESAT Joseph Myers
@ 2016-03-29 21:24 ` Joseph Myers
  2016-03-29 21:28   ` Adhemerval Zanella
  0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2016-03-29 21:24 UTC (permalink / raw)
  To: libc-alpha; +Cc: david

Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2016-03/msg00588.html> is pending 
review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Ping Re: [microblaze] Remove __ASSUME_FUTIMESAT
  2016-03-29 21:24 ` Ping " Joseph Myers
@ 2016-03-29 21:28   ` Adhemerval Zanella
  0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2016-03-29 21:28 UTC (permalink / raw)
  To: libc-alpha



On 29-03-2016 18:24, Joseph Myers wrote:
> Ping.  This patch 
> <https://sourceware.org/ml/libc-alpha/2016-03/msg00588.html> is pending 
> review.
> 

LGTM.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-29 21:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-22 21:42 [microblaze] Remove __ASSUME_FUTIMESAT Joseph Myers
2016-03-29 21:24 ` Ping " Joseph Myers
2016-03-29 21:28   ` Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).