From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eggert@cs.ucla.edu>
Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68])
 by sourceware.org (Postfix) with ESMTPS id 0A3A13858C53
 for <libc-alpha@sourceware.org>; Wed, 13 Apr 2022 19:11:50 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A3A13858C53
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=cs.ucla.edu
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4AE041600ED;
 Wed, 13 Apr 2022 12:11:49 -0700 (PDT)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id LLYNDQuoWwx5; Wed, 13 Apr 2022 12:11:48 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 943711600F1;
 Wed, 13 Apr 2022 12:11:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id pi0XEJEfkfes; Wed, 13 Apr 2022 12:11:48 -0700 (PDT)
Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com
 [172.91.119.151])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 709BD1600ED;
 Wed, 13 Apr 2022 12:11:48 -0700 (PDT)
Message-ID: <56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu>
Date: Wed, 13 Apr 2022 12:11:47 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Noah Goldstein <goldstein.w.n@gmail.com>
References: <20220411165835.4028009-1-goldstein.w.n@gmail.com>
 <9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu>
 <CAFUsyfJ7Zba--qet3yzROomaf8Zdq-qhXAgS6=534nobws8fJg@mail.gmail.com>
 <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu>
 <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t
In-Reply-To: <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2022 19:11:51 -0000

On 4/13/22 08:23, Noah Goldstein wrote:

>> Both, I expect. We can assume int is at least 32 bits.
> 
> Disagree with that a bit. fast32 is saving pretty specifically at least 32 bits
> which int doesn't say but int32_t does.

I thought the idea was to not worry about losing the 16-bit vs 32-bit vs 
whatever info, since it doesn't really matter and keeping the info 
around just encourages bikeshedding later.

If we want to keep that info then we should create private types like 
glibc_int_fast32_t as I mentioned earlier. If not, let's just use 'int'.


> Can you confirm all the tz changes are okay?

Oh, sorry, I didn't notice that you were changing zic.c.

Unfortunately the zic.c changes are not OK, as zic.c is supposed to 
portable to platforms that lack int32_t (the C standard allows such 
platforms).