From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tarta.nabijaczleweli.xyz (unknown [139.28.40.42]) by sourceware.org (Postfix) with ESMTP id 4241C3858032 for ; Mon, 3 Jul 2023 17:52:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4241C3858032 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=nabijaczleweli.xyz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nabijaczleweli.xyz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nabijaczleweli.xyz; s=202305; t=1688406740; bh=E7FMZk6Yio0r7JkLy8BJoFcBdDEveElyl5HhIROepyk=; h=Date:From:Cc:Subject:From; b=dX+FJrhXnuj+N1iG/loxJbCGFmFqWfUEcVGiWEzNB4UgeIgxpxTbzAKknbXgvf9Dz GbDRl3L1d/z64163weyAP1kAu5W/tyi4ZmwR3w+EhArYfAmmHAFHNMDBF5ASdDZ2ra lK70SakFvJqXRcEypo7riPXXt9NyBhoQ54FEwbxY0If8B5ioaGRmS6YORDmWnDjsVf FlWwVDaSsvWO8hkc2wNm4JU/BZptr56n7WATf00by77VsrmVb6T9t+qRnDZUHN2G8e yusKRObwwDEEMpOpYQV8ls/Wpi2TtQ+bc+gqk0dME+Py4+r6h2MO4LaBDP6hkoypXO sj9Lo1JvrcWTg== Received: from tarta.nabijaczleweli.xyz (unknown [192.168.1.250]) by tarta.nabijaczleweli.xyz (Postfix) with ESMTPSA id A6B2E2386; Mon, 3 Jul 2023 19:52:20 +0200 (CEST) Date: Mon, 3 Jul 2023 19:52:19 +0200 From: =?utf-8?B?0L3QsNCx?= Cc: Carlos O'Donell , Adhemerval Zanella Netto , Paul Eggert , libc-alpha@sourceware.org Subject: [PATCH v9 1/3] posix: regcomp(): clear RE_DOT_NOT_NULL Message-ID: <56ba55edd43630bdd5658c8648c0ef3ef7d6f938.1688406716.git.nabijaczleweli@nabijaczleweli.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hky2vn4gevziz5fx" Content-Disposition: inline User-Agent: NeoMutt/20230517 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_INFOUSMEBIZ,MISSING_HEADERS,PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --hky2vn4gevziz5fx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The POSIX API always stops at first NUL so there's no change for that. The BSD REG_STARTEND API, with its explicit range, can include NULs within that range, and those NULs are matched with . and [^]. Heretofor, for a string of "a\0c", glibc would match "[^q]c", but not ".c". This is both inconsistent and nonconformant to BSD REG_STARTEND. With this patch, they're identical like you'd expect, and the tst-reg-startend.c: ..c: a^@c: no match$ failure is removed. Another approach would be to remove it from _RE_SYNTAX_POSIX_COMMON, but it's unclear to me what the custody chain is like for that and what other regex APIs glibc offers that could be affected by this. Signed-off-by: Ahelenia Ziemia=C5=84ska --- I hereby disclaim all copyright interest in this changeset. No-change clean rebase. posix/regcomp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/posix/regcomp.c b/posix/regcomp.c index 12650714c0..a928ef6c2d 100644 --- a/posix/regcomp.c +++ b/posix/regcomp.c @@ -462,7 +462,7 @@ regcomp (regex_t *__restrict preg, const char *__restri= ct pattern, int cflags) { reg_errcode_t ret; reg_syntax_t syntax =3D ((cflags & REG_EXTENDED) ? RE_SYNTAX_POSIX_EXTEN= DED - : RE_SYNTAX_POSIX_BASIC); + : RE_SYNTAX_POSIX_BASIC) & ~RE_DOT_NOT_NULL; =20 preg->buffer =3D NULL; preg->allocated =3D 0; --=20 2.39.2 --hky2vn4gevziz5fx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSjCtAACgkQvP0LAY0m WPFkZxAAulcX2lx0l3Ahdw5JcyruHfhKCgoSyUScVZC9dUl3npIx1ePJSJHdDbu2 4/3yRtJ/CigAHCunaunJhAau2fs09IClfTG/kMblc0ftgGFCy+E7lbRTymK6Q7Cv pKuMZhOc72qKadyNaJ9cSyFBwdHdZMJ6croQ4rAMtOsk7d1tP+II8t6lsAifENe4 +OiNP7P4keOFaZOIa2umWaGmqvC3i28AHvvp5iPyNEPmsatN/6yLjpaOF50Q7KrX Ok8XzQlEzcB90XOrC7voCmKKrxOtXtDRWMaBkYLfJNrve/1JhxHN6CBWaWAUJXP7 HddHIiHcSHGID0gZg7V2PSDC9HjRfdcQN0j7b3dTM8ja+MSUVXHT3NmGIOqLVCKZ bbjlf38is/pQXo4KptHJs5psl69idFnaVR3fWoJtF9aU4xPGlMSSx5HrmM3dpVCd x0+mnfxlWedsYn3uApS3oYKXXVT4TcPle7ch+ld3v99OIC2TtlawepsVyrKyNUL8 0sVVoCFG2befTKgqgyuL1dgL53HZXd0i/aor3IPnl2QNt62GZafP+bqCF3oFr3hQ QuuLHd4y/pPV3njXnO9+M75IP06TE/KLJFNO3ZMCAvzg0PjxHwelAzp3dgZDV8oq o8LeTsu/1TYbucFGC7C6+WFLomPRp43hSRcMYO9pbqXMgiprENc= =Ztq5 -----END PGP SIGNATURE----- --hky2vn4gevziz5fx--