From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 3D4C6385781D for ; Fri, 29 Oct 2021 12:14:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D4C6385781D Received: by mail-qt1-x82a.google.com with SMTP id h16so4392765qtk.0 for ; Fri, 29 Oct 2021 05:14:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=P/Br6XOBhiuokaPqbrkRGSNQuizk7b8eyo1nfCeb2mA=; b=4ybxS1IVVtJJn18UpkDekyDAoN0gBY+84TyS5KdyXmgbSdqu2ZfoF6rXSkfylMpCT2 2C2ocuGehqey8aq4wBPKZirVrae6DHjkcIH87Gy7lunzkdvt1XrRqApvoc0uKbfrr2ov AhzOVKUxfKhDZ5//w6we24twnZ5RIJ5pxjUV1WxkELViF6O9XQuWKcVEOe/RGIh7x5zY Gc8V9DEqbICljwRO1eLHa8zTsDEAhWQeLa5SUcwxjuSzM0MHiBeq9kzNkXAKS7IGTMtF ZN18zyX/R5Kgb2j6WG8EeAkFE6FbJxkAk0JCiyQIeWz3uu+mz5mNoOu2CmxY80vuCmNW h31Q== X-Gm-Message-State: AOAM531g/tKfmZodOKAXwSNbQ5qSSbMnu89CxPerl7fTB39JWjHWc9yp X1tozE43qSaluYMT7a0YNR6m1NVneF4Thg== X-Google-Smtp-Source: ABdhPJwvJlygDGqlC6hcoFUt+fqq/IHzPB/dcsnWS3+RTrdbuj5lkSVh2n+Cx1UKLIRIMbdQvV2r0Q== X-Received: by 2002:a05:622a:1102:: with SMTP id e2mr11184014qty.171.1635509667730; Fri, 29 Oct 2021 05:14:27 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:b64f:a500:ef25:9b66:6e05? ([2804:431:c7cb:b64f:a500:ef25:9b66:6e05]) by smtp.gmail.com with ESMTPSA id g8sm3801395qka.45.2021.10.29.05.14.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 05:14:27 -0700 (PDT) Message-ID: <56cc5592-0dd6-a830-dca8-9d5470c06d39@linaro.org> Date: Fri, 29 Oct 2021 09:14:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] Fix compiler issue with mmap_internal Content-Language: en-US To: libc-alpha@sourceware.org References: <20211028212717.2311696-1-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: <20211028212717.2311696-1-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 12:14:30 -0000 On 28/10/2021 18:27, Stafford Horne via Libc-alpha wrote: > Compiling mmap_internal fails to compile when we use -1 for MMAP2_PAGE_UNIT > on 32 bit architectures. The error is as follows: > > ../sysdeps/unix/sysv/linux/mmap_internal.h:30:8: error: unknown type > name 'uint64_t' > | > 30 | static uint64_t page_unit; > | > | ^~~~~~~~ > > Fix by adding including stdint.h. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix/sysv/linux/mmap_internal.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sysdeps/unix/sysv/linux/mmap_internal.h b/sysdeps/unix/sysv/linux/mmap_internal.h > index 5ca6976191..35e112cc77 100644 > --- a/sysdeps/unix/sysv/linux/mmap_internal.h > +++ b/sysdeps/unix/sysv/linux/mmap_internal.h > @@ -19,6 +19,8 @@ > #ifndef MMAP_INTERNAL_LINUX_H > #define MMAP_INTERNAL_LINUX_H 1 > > +#include > + > /* This is the minimum mmap2 unit size accept by the kernel. An architecture > with multiple minimum page sizes (such as m68k) might define it as -1 and > thus it will queried at runtime. */ >