From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Subject: Re: [PATCHv2] powerpc: Add optimized P8 strspn
Date: Mon, 04 Apr 2016 14:48:00 -0000 [thread overview]
Message-ID: <57027ECE.7070101@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160402234040.GA17716@gate.crashing.org>
On 04/02/2016 06:40 PM, Segher Boessenkool wrote:
> Hi Paul,
>
> Sorry for not reviewing this earlier. Some minor things; this is
> not a full review.
>
>> +++ b/sysdeps/powerpc/powerpc64/multiarch/strspn.c
>> @@ -0,0 +1,35 @@
>> +/* Multiple versions of strspn. PowerPC64 version.
>
> Two spaces after full stop.
>
>> +++ b/sysdeps/powerpc/powerpc64/power8/strspn.S
>
>> +/* size_t [r3] strspn (const char *string [r3],
>> + const char *needleAccept [r4] */
>
> Missing ")".
ack.
>
>> + lvsr v11, r0, r3
>
> That is 0, not r0.
>
>> + lvx v0, r0, r3 /* Note, unaligned load ignores lower bits. */
>
> Same for lvx.
I'd intentionally used r0 in those cases to explicitly exploit its special
meaning under those instructions. It it customary to explicitly use 0 in
such cases?
Thank you for reviewing!
-Paul
next prev parent reply other threads:[~2016-04-04 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:34 Paul E. Murphy
2016-04-02 23:40 ` Segher Boessenkool
2016-04-04 14:48 ` Paul E. Murphy [this message]
2016-04-04 16:42 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57027ECE.7070101@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=segher@kernel.crashing.org \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).