From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-68563-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 128980 invoked by alias); 4 Apr 2016 14:48:57 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 128969 invoked by uid 89); 4 Apr 2016 14:48:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:859
X-HELO: e38.co.us.ibm.com
X-IBM-Helo: d03dlp03.boulder.ibm.com
X-IBM-MailFrom: murphyp@linux.vnet.ibm.com
X-IBM-RcptTo: libc-alpha@sourceware.org
Subject: Re: [PATCHv2] powerpc: Add optimized P8 strspn
To: Segher Boessenkool <segher@kernel.crashing.org>
References: <56FC0008.7030302@linux.vnet.ibm.com>
 <20160402234040.GA17716@gate.crashing.org>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
        Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
Message-ID: <57027ECE.7070101@linux.vnet.ibm.com>
Date: Mon, 04 Apr 2016 14:48:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160402234040.GA17716@gate.crashing.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16040414-0029-0000-0000-000019C1949D
X-SW-Source: 2016-04/txt/msg00049.txt.bz2



On 04/02/2016 06:40 PM, Segher Boessenkool wrote:
> Hi Paul,
> 
> Sorry for not reviewing this earlier.  Some minor things; this is
> not a full review.
> 
>> +++ b/sysdeps/powerpc/powerpc64/multiarch/strspn.c
>> @@ -0,0 +1,35 @@
>> +/* Multiple versions of strspn. PowerPC64 version.
> 
> Two spaces after full stop.
> 
>> +++ b/sysdeps/powerpc/powerpc64/power8/strspn.S
> 
>> +/* size_t [r3] strspn (const char *string [r3],
>> +                       const char *needleAccept [r4]  */
> 
> Missing ")".

ack.

> 
>> +	lvsr	v11, r0, r3
> 
> That is 0, not r0.
> 
>> +	lvx	v0, r0, r3	/* Note, unaligned load ignores lower bits.  */
> 
> Same for lvx.

I'd intentionally used r0 in those cases to explicitly exploit its special
meaning under those instructions. It it customary to explicitly use 0 in
such cases?

Thank you for reviewing!

-Paul