From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] powerpc: Add optimized P8 strspn
Date: Thu, 07 Apr 2016 20:55:00 -0000 [thread overview]
Message-ID: <5706C927.9060209@linux.vnet.ibm.com> (raw)
In-Reply-To: <87r3eh8dvr.fsf@totoro.br.ibm.com>
Pushed as 25dba0a with the trivial change pointed out by Tulio.
On 04/07/2016 01:36 PM, Tulio Magno Quites Machado Filho wrote:
> "Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
>
>> diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> index 3b0e3a0..7ed56bf 100644
>> --- a/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> +++ b/sysdeps/powerpc/powerpc64/multiarch/Makefile
>> @@ -19,7 +19,8 @@ sysdep_routines += memcpy-power7 memcpy-a2 memcpy-power6 memcpy-cell \
>> strcmp-power8 strcmp-power7 strcmp-ppc64 \
>> strcat-power8 strcat-power7 strcat-ppc64 \
>> memmove-power7 memmove-ppc64 wordcopy-ppc64 bcopy-ppc64 \
>> - strncpy-power8 strstr-power7 strstr-ppc64
>> + strncpy-power8 strstr-power7 strstr-ppc64 \
>> + strspn-power8 strspn-ppc64
>
> I'm afraid you'll have another conflict here with due to the strlen
> optimization and the strcasestr optimization.
>
>> +/* size_t [r3] strspn (const char *string [r3],
>> + const char *needleAccept [r4] */
>
> Missing ) here ----------------------------------------^
>
> LGTM.
>
prev parent reply other threads:[~2016-04-07 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:47 Paul E. Murphy
2016-04-04 20:46 ` Adhemerval Zanella
2016-04-07 18:36 ` Tulio Magno Quites Machado Filho
2016-04-07 20:55 ` Paul E. Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706C927.9060209@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).