From: Paul Eggert <eggert@cs.ucla.edu>
To: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] vfprintf: Fix memory with large width and precision [BZ #19931]
Date: Mon, 11 Apr 2016 15:52:00 -0000 [thread overview]
Message-ID: <570BC840.6060807@cs.ucla.edu> (raw)
In-Reply-To: <570BC02D.2040901@redhat.com>
On 04/11/2016 08:18 AM, Florian Weimer wrote:
> + /* Deallocate any previously allocated buffer because it is
> + too small. */
> + if (workstart != NULL)
> + {
> + free (workstart);
> + workstart = NULL;
> + }
Other places in that function use this code instead:
if (__glibc_unlikely (workstart != NULL))
free (workstart);
workstart = NULL;
Is there some reason to do things differently here?
next prev parent reply other threads:[~2016-04-11 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 15:18 Florian Weimer
2016-04-11 15:52 ` Paul Eggert [this message]
2016-04-11 16:02 ` Florian Weimer
2016-04-14 12:23 ` Florian Weimer
2016-04-14 16:17 ` Paul Eggert
2016-04-15 12:02 ` Florian Weimer
2016-04-15 19:38 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BC840.6060807@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).